devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Krishna Manikandan <quic_mkrishn@quicinc.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: display/msm: Add reg bus interconnect
Date: Tue, 18 Apr 2023 09:24:36 +0200	[thread overview]
Message-ID: <cec395c8-83b0-8626-7229-dd8427db48fc@linaro.org> (raw)
In-Reply-To: <20230417-topic-dpu_regbus-v1-1-06fbdc1643c0@linaro.org>

On 17/04/2023 17:30, Konrad Dybcio wrote:
> Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there's
> another path that needs to be handled to ensure MDSS functions properly,
> namely the "reg bus", a.k.a the CPU-MDSS interconnect.
> 
> Gating that path may have a variety of effects.. from none to otherwise
> inexplicable DSI timeouts..
> 
> Describe it in bindings to allow for use in device trees.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  Documentation/devicetree/bindings/display/msm/mdss-common.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
> index ccd7d6417523..9eb5b6d3e0b9 100644
> --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
> @@ -72,6 +72,7 @@ properties:
>      items:
>        - const: mdp0-mem
>        - const: mdp1-mem
> +      - const: cpu-cfg

You added only interconnect-name, not actual interconnect.

Best regards,
Krzysztof


  reply	other threads:[~2023-04-18  7:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 15:30 [PATCH 0/5] MDSS reg bus interconnect Konrad Dybcio
2023-04-17 15:30 ` [PATCH 1/5] dt-bindings: display/msm: Add " Konrad Dybcio
2023-04-18  7:24   ` Krzysztof Kozlowski [this message]
2023-04-19 20:05   ` [Freedreno] " Jeykumar Sankaran
2023-04-20  0:26     ` Dmitry Baryshkov
2023-04-17 15:30 ` [PATCH 2/5] drm/msm/dpu1: Rename path references to mdp_path Konrad Dybcio
2023-04-20  0:27   ` Dmitry Baryshkov
2023-04-17 15:30 ` [PATCH 3/5] drm/msm/mdss: " Konrad Dybcio
2023-04-20  0:27   ` Dmitry Baryshkov
2023-04-17 15:30 ` [PATCH 4/5] drm/msm/mdss: Handle the reg bus ICC path Konrad Dybcio
2023-04-17 15:30 ` [PATCH 5/5] drm/msm/dpu1: " Konrad Dybcio
2023-04-17 15:55   ` Konrad Dybcio
2023-04-19 19:06   ` [Freedreno] " Jeykumar Sankaran
2023-04-19 19:48     ` Konrad Dybcio
2023-04-19 20:11       ` Jeykumar Sankaran
2023-04-19 21:26         ` Konrad Dybcio
2023-04-20  0:34           ` Dmitry Baryshkov
2023-04-19 20:07 ` [Freedreno] [PATCH 0/5] MDSS reg bus interconnect Jeykumar Sankaran
2023-05-29  2:42 ` Dmitry Baryshkov
2023-05-29  7:42   ` Konrad Dybcio
2023-05-29  8:47     ` Dmitry Baryshkov
2023-05-29  9:08       ` Konrad Dybcio
2023-05-29 10:01         ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cec395c8-83b0-8626-7229-dd8427db48fc@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_mkrishn@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).