From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 668C7C46467 for ; Mon, 16 Jan 2023 11:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230034AbjAPL1J (ORCPT ); Mon, 16 Jan 2023 06:27:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbjAPL0y (ORCPT ); Mon, 16 Jan 2023 06:26:54 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F313616AE7 for ; Mon, 16 Jan 2023 03:26:51 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id cf42so42309185lfb.1 for ; Mon, 16 Jan 2023 03:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jiUo/N+/H2Pgfs41Qven/kqGQqI/RDTr+JF+6I51Y0I=; b=T1J2SJHsBxGppAAo5sv0RrnuDSLD8utVMtUC2nXGpGdm4IdfoN9QP2jRwFf0gHOMrj TX6/K5BpojJNvN9CTuOMdjTAs2OI1KiGTop2DYTBDlH+Hd7igd6MHpnAva8qpxVYbJQx gAtphZ/xmEDCX384mmL8jokBAnI8v4Q+KKko+Sk5//wqYMDK2A2FHY8j5w/2IXYxlrjJ qY4UoA37NLv9/4zmXKbXPc0gw2x0KHmwg0uK/hKZ+FRClAoTqxToH71i7F8SS8RG6P9R LjUIt+ho6NOPm9nXYFJjmfBPS5n8WXYK3eI+FaLn+fMj22b6O0I4Cqxyk8ssFIlPY7O/ e++g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jiUo/N+/H2Pgfs41Qven/kqGQqI/RDTr+JF+6I51Y0I=; b=YICTi1+4gisVMIWwPLp9+diVReWjsp8jmPKoP2nlaCJiV9SN2NGfYQpq2qc/12le0X bACjryTXVWFhS+6ARQqAN0YPPxe7jtWi4jUaX9CbY1/QLY5bNnCHgj7TWUCoTrsUr2Ff wbeT21dVaqc/wn0UsBos9a0lT/VIj5TwfoROK2VyoWI4u1Gww5Y8iIQie4gw2J82G3U1 StYbM4MzN1dHv4UeulOhPHgyATTxHl851ue7tgeNtPVQuvrNO0+Y42tMG1jEW7a1baxf BsIAdEE9lQcyaTOP9HrAu+YbllWR0W/2ZoA7pQJffIckvCCrb3EJgoDzJztcAKFcQI9y RqqQ== X-Gm-Message-State: AFqh2kr6rE3+GQEQalFVUu+T8ZVQfxMWjvjFNJBxJvT6l0xtA5rH5KNg ZAqdMrWpkLp8yTE88R4pu/LCA1eqMQloH2KY X-Google-Smtp-Source: AMrXdXt/i6ezRt6Jo2A4YzNxx5Sj3zxB7QCQxsBoBNuETjthUDfx7QIyvEnaVBjMj6B9ENBiDc47AA== X-Received: by 2002:a05:6512:694:b0:4cb:436b:a70f with SMTP id t20-20020a056512069400b004cb436ba70fmr15269415lfe.64.1673868410283; Mon, 16 Jan 2023 03:26:50 -0800 (PST) Received: from [192.168.1.101] (abym53.neoplus.adsl.tpnet.pl. [83.9.32.53]) by smtp.gmail.com with ESMTPSA id c5-20020a056512074500b004b53eb60e3csm349211lfs.256.2023.01.16.03.26.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 03:26:49 -0800 (PST) Message-ID: Date: Mon, 16 Jan 2023 12:26:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v9 2/6] dt-bindings: soc: qcom: cpr3: Add bindings for CPR3 driver Content-Language: en-US To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, AngeloGioacchino Del Regno , AngeloGioacchino Del Regno , Rob Herring , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230116093845.72621-1-konrad.dybcio@linaro.org> <20230116093845.72621-3-konrad.dybcio@linaro.org> From: Konrad Dybcio In-Reply-To: <20230116093845.72621-3-konrad.dybcio@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16.01.2023 10:38, Konrad Dybcio wrote: > From: AngeloGioacchino Del Regno > > Add the bindings for the CPR3 driver to the documentation. > > Reviewed-by: Rob Herring > Signed-off-by: AngeloGioacchino Del Regno > [Konrad: Make binding check pass; update AGdR's email] > Signed-off-by: Konrad Dybcio > --- > .../bindings/soc/qcom/qcom,cpr3.yaml | 314 ++++++++++++++++++ > 1 file changed, 314 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > new file mode 100644 > index 000000000000..eb11af375e54 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > @@ -0,0 +1,314 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,cpr3.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Core Power Reduction v3/v4/Hardened (CPR3, CPR4, CPRh) > + > +description: | > + CPR (Core Power Reduction) is a technology to reduce core power on a CPU > + or other device. Each OPP of a device corresponds to a "corner" that has > + a range of valid voltages for a particular frequency. While the device is > + running at a particular frequency, CPR monitors dynamic factors such as > + temperature, etc. and suggests or, in the CPR-Hardened case performs, > + adjustments to the voltage to save power and meet silicon characteristic > + requirements. > + > +maintainers: > + - AngeloGioacchino Del Regno > + > +properties: > + compatible: > + oneOf: > + - description: CPRv3 controller > + items: > + - const: qcom,cpr3 > + - description: CPRv4 controller > + items: > + - const: qcom,cpr4 > + - description: CPRv4-Hardened controller > + items: > + - enum: > + - qcom,msm8998-cprh > + - qcom,sdm630-cprh > + - const: qcom,cprh > + > + reg: > + description: Base address and size of the CPR controller(s) > + minItems: 1 > + maxItems: 2 > + > + interrupts: > + maxItems: 1 > + > + clock-names: > + items: > + - const: "ref" > + > + clocks: > + items: > + - description: CPR reference clock > + > + vdd-supply: > + description: Autonomous Phase Control (APC) or other power supply > + > + '#power-domain-cells': > + const: 1 > + > + acc-syscon: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to syscon for writing ACC settings > + > + nvmem-cells: > + description: Cells containing the fuse corners and revision data > + minItems: 10 > + maxItems: 32 > + > + nvmem-cell-names: > + minItems: 10 > + maxItems: 32 > + > + operating-points-v2: true > + > + power-domains: true > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - operating-points-v2 > + - "#power-domain-cells" > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,msm8998-cprh > + then: > + properties: > + nvmem-cell-names: > + items: > + - const: "cpr_speed_bin" > + - const: "cpr_fuse_revision" > + - const: "cpr0_quotient1" > + - const: "cpr0_quotient2" > + - const: "cpr0_quotient3" > + - const: "cpr0_quotient4" > + - const: "cpr0_quotient_offset2" > + - const: "cpr0_quotient_offset3" > + - const: "cpr0_quotient_offset4" > + - const: "cpr0_init_voltage1" > + - const: "cpr0_init_voltage2" > + - const: "cpr0_init_voltage3" > + - const: "cpr0_init_voltage4" > + - const: "cpr0_ring_osc1" > + - const: "cpr0_ring_osc2" > + - const: "cpr0_ring_osc3" > + - const: "cpr0_ring_osc4" > + - const: "cpr1_quotient1" > + - const: "cpr1_quotient2" > + - const: "cpr1_quotient3" > + - const: "cpr1_quotient4" > + - const: "cpr1_quotient_offset2" > + - const: "cpr1_quotient_offset3" > + - const: "cpr1_quotient_offset4" > + - const: "cpr1_init_voltage1" > + - const: "cpr1_init_voltage2" > + - const: "cpr1_init_voltage3" > + - const: "cpr1_init_voltage4" > + - const: "cpr1_ring_osc1" > + - const: "cpr1_ring_osc2" > + - const: "cpr1_ring_osc3" > + - const: "cpr1_ring_osc4" > + else: > + items: > + - const: "cpr_quotient_offset1" > + - const: "cpr_quotient_offset2" > + - const: "cpr_quotient_offset3" > + - const: "cpr_init_voltage1" > + - const: "cpr_init_voltage2" > + - const: "cpr_init_voltage3" > + - const: "cpr_quotient1" > + - const: "cpr_quotient2" > + - const: "cpr_quotient3" > + - const: "cpr_ring_osc1" > + - const: "cpr_ring_osc2" > + - const: "cpr_ring_osc3" > + - const: "cpr_fuse_revision" I suppose this block gotta go, as QCS404 CPR is not handled by this binding! Konrad > + > +examples: > + - | > + #include > + #include > + > + cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + > + cpu@0 { > + compatible = "qcom,kryo280"; > + device_type = "cpu"; > + reg = <0x0 0x0>; > + operating-points-v2 = <&cpu_gold_opp_table>; > + power-domains = <&apc_cprh 0>; > + power-domain-names = "cprh"; > + }; > + > + cpu@100 { > + compatible = "qcom,kryo280"; > + device_type = "cpu"; > + reg = <0x0 0x100>; > + operating-points-v2 = <&cpu_silver_opp_table>; > + power-domains = <&apc_cprh 1>; > + power-domain-names = "cprh"; > + }; > + }; > + > + cpu0_opp_table: opp-table-cpu0 { > + compatible = "operating-points-v2"; > + opp-shared; > + > + opp-1843200000 { > + opp-hz = /bits/ 64 <1843200000>; > + required-opps = <&cprh_opp3>; > + }; > + > + opp-1094400000 { > + opp-hz = /bits/ 64 <1094400000>; > + required-opps = <&cprh_opp2>; > + }; > + > + opp-300000000 { > + opp-hz = /bits/ 64 <300000000>; > + required-opps = <&cprh_opp1>; > + }; > + }; > + > + cpu4_opp_table: opp-table-cpu4 { > + compatible = "operating-points-v2"; > + opp-shared; > + > + opp-2208000000 { > + opp-hz = /bits/ 64 <2208000000>; > + required-opps = <&cprh_opp3>; > + }; > + > + opp-1113600000 { > + opp-hz = /bits/ 64 <1113600000>; > + required-opps = <&cprh_opp2>; > + }; > + > + opp-300000000 { > + opp-hz = /bits/ 64 <300000000>; > + required-opps = <&cprh_opp1>; > + }; > + }; > + > + cprh_opp_table: opp-table-cprh { > + compatible = "operating-points-v2-qcom-level"; > + > + cprh_opp1: opp-1 { > + opp-level = <1>; > + qcom,opp-fuse-level = <1>; > + qcom,opp-cloop-vadj = <0>; > + qcom,opp-oloop-vadj = <0>; > + }; > + > + cprh_opp2: opp-2 { > + opp-level = <2>; > + qcom,opp-fuse-level = <2>; > + qcom,opp-cloop-vadj = <0>; > + qcom,opp-oloop-vadj = <0>; > + }; > + > + cprh_opp3: opp-3 { > + opp-level = <3>; > + qcom,opp-fuse-level = <2 3>; > + qcom,opp-cloop-vadj = <0>; > + qcom,opp-oloop-vadj = <0>; > + }; > + }; > + > + apc_cprh: power-controller@179c8000 { > + compatible = "qcom,msm8998-cprh", "qcom,cprh"; > + reg = <0x0179c8000 0x4000>, <0x0179c4000 0x4000>; > + clocks = <&gcc GCC_HMSS_RBCPR_CLK>; > + clock-names = "ref"; > + > + operating-points-v2 = <&cprh_opp_table>; > + #power-domain-cells = <1>; > + > + nvmem-cells = <&cpr_efuse_speedbin>, > + <&cpr_fuse_revision>, > + <&cpr_quot0_pwrcl>, > + <&cpr_quot1_pwrcl>, > + <&cpr_quot2_pwrcl>, > + <&cpr_quot3_pwrcl>, > + <&cpr_quot_offset1_pwrcl>, > + <&cpr_quot_offset2_pwrcl>, > + <&cpr_quot_offset3_pwrcl>, > + <&cpr_init_voltage0_pwrcl>, > + <&cpr_init_voltage1_pwrcl>, > + <&cpr_init_voltage2_pwrcl>, > + <&cpr_init_voltage3_pwrcl>, > + <&cpr_ro_sel0_pwrcl>, > + <&cpr_ro_sel1_pwrcl>, > + <&cpr_ro_sel2_pwrcl>, > + <&cpr_ro_sel3_pwrcl>, > + <&cpr_quot0_perfcl>, > + <&cpr_quot1_perfcl>, > + <&cpr_quot2_perfcl>, > + <&cpr_quot3_perfcl>, > + <&cpr_quot_offset1_perfcl>, > + <&cpr_quot_offset2_perfcl>, > + <&cpr_quot_offset3_perfcl>, > + <&cpr_init_voltage0_perfcl>, > + <&cpr_init_voltage1_perfcl>, > + <&cpr_init_voltage2_perfcl>, > + <&cpr_init_voltage3_perfcl>, > + <&cpr_ro_sel0_perfcl>, > + <&cpr_ro_sel1_perfcl>, > + <&cpr_ro_sel2_perfcl>, > + <&cpr_ro_sel3_perfcl>; > + nvmem-cell-names = "cpr_speed_bin", > + "cpr_fuse_revision", > + "cpr0_quotient1", > + "cpr0_quotient2", > + "cpr0_quotient3", > + "cpr0_quotient4", > + "cpr0_quotient_offset2", > + "cpr0_quotient_offset3", > + "cpr0_quotient_offset4", > + "cpr0_init_voltage1", > + "cpr0_init_voltage2", > + "cpr0_init_voltage3", > + "cpr0_init_voltage4", > + "cpr0_ring_osc1", > + "cpr0_ring_osc2", > + "cpr0_ring_osc3", > + "cpr0_ring_osc4", > + "cpr1_quotient1", > + "cpr1_quotient2", > + "cpr1_quotient3", > + "cpr1_quotient4", > + "cpr1_quotient_offset2", > + "cpr1_quotient_offset3", > + "cpr1_quotient_offset4", > + "cpr1_init_voltage1", > + "cpr1_init_voltage2", > + "cpr1_init_voltage3", > + "cpr1_init_voltage4", > + "cpr1_ring_osc1", > + "cpr1_ring_osc2", > + "cpr1_ring_osc3", > + "cpr1_ring_osc4"; > + }; > +...