From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Lin <CTLIN0@nuvoton.com>, broonie@kernel.org
Cc: lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, YHCHuang@nuvoton.com,
KCHSU0@nuvoton.com, WTLI@nuvoton.com, SJLIN0@nuvoton.com,
ctlin0.linux@gmail.com
Subject: Re: [PATCH] ASoC: dt-bindings: nau8810: Convert to dtschema
Date: Tue, 16 May 2023 18:11:07 +0200 [thread overview]
Message-ID: <ced69a34-5350-abd4-637a-691bf4af140d@linaro.org> (raw)
In-Reply-To: <20230516054447.1081404-1-CTLIN0@nuvoton.com>
On 16/05/2023 07:44, David Lin wrote:
> Convert the NAU8810 audio CODEC bindings to DT schema.
>
> Signed-off-by: David Lin <CTLIN0@nuvoton.com>
> ---
Thank you for your patch. There is something to discuss/improve.
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + codec@1a {
> + #sound-dai-cells = <0>;
Please put sound-dai-cells at the end. In DTS convention is to have
compatible first, reg second.
With this:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> + compatible = "nuvoton,nau8810";
> + reg = <0x1a>;
> + };
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-16 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 5:44 [PATCH] ASoC: dt-bindings: nau8810: Convert to dtschema David Lin
2023-05-16 16:11 ` Krzysztof Kozlowski [this message]
2023-05-17 6:29 ` AS50 CTLin0
2023-05-17 14:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ced69a34-5350-abd4-637a-691bf4af140d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=SJLIN0@nuvoton.com \
--cc=WTLI@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ctlin0.linux@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).