From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.intel.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
quic_srivasam@quicinc.com,
Geert Uytterhoeven <geert@linux-m68k.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] soundwire: qcom: fix build failures if CONFIG_PM=n
Date: Thu, 3 Mar 2022 16:28:36 +0000 [thread overview]
Message-ID: <cef16c0a-c0a8-3ed2-c35b-09fda2068073@linaro.org> (raw)
In-Reply-To: <YiDlBevX3/BrXmwb@matsya>
On 03/03/2022 15:55, Vinod Koul wrote:
> On 03-03-22, 11:03, Srinivas Kandagatla wrote:
>> Fix below build failure
>> drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
>> but not used [-Werror=unused-function]
>> by marking the resume swrm_runtime_resume() with __maybe_unused attribute.
>
> A patch title should reflect the change and not the cause. So i have
> taken liberty to fix it as:
>
> soundwire: qcom: use __maybe_unused for swrm_runtime_resume()
>
> swrm_runtime_resume() would not be defined when CONFIG_PM=n
>
> This causes below build failure
> drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
> but not used [-Werror=unused-function]
>
> Mark the resume swrm_runtime_resume() with __maybe_unused attribute.
>
> With this i have applied
Thanks Vinod,
--srini
>
prev parent reply other threads:[~2022-03-03 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 11:03 [PATCH] soundwire: qcom: fix build failures if CONFIG_PM=n Srinivas Kandagatla
2022-03-03 15:55 ` Vinod Koul
2022-03-03 16:28 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cef16c0a-c0a8-3ed2-c35b-09fda2068073@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=quic_srivasam@quicinc.com \
--cc=sfr@canb.auug.org.au \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox