From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 518D9C001DE for ; Fri, 28 Jul 2023 12:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236563AbjG1MVS (ORCPT ); Fri, 28 Jul 2023 08:21:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236565AbjG1MVG (ORCPT ); Fri, 28 Jul 2023 08:21:06 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05FDA5BB2; Fri, 28 Jul 2023 05:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=0vGzHPOHRgwV2rrCJY+z+iKt3Xe22jPI5VspopXK2NU=; b=sJRROBhDfmYmeSmTgTGOt8SFY0 bDZz3f0wR6a2kXM2ns6izfQ2/JejJbk0fBYT8Z0R6CPDfwN7OE5/+qH4GRXY2K/AX9E6e/bnP3XCL ykz6XXNDiF/Z8MGhusNxDfsTVmkBajUdMlg/K0p5ULCtiyLdhEDvcnaLmlOtNUmu+4l+nk/Xs3O+J nZG1ZSqdpN9S1DAOySNanAlMYexHD/jIDikdenef6iRzHrnECZd/gwrlGnXPlZ6nTwmmOaOIhLaOq XwDbogXsLoRfxOg90WxvFvBE41953j+8Whg0BaJSrN5laJi8jBknbO5Vav6YQsem8sM/q4sHLNzh1 5x0zbOrQ==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qPMPZ-003JFK-0x; Fri, 28 Jul 2023 12:17:37 +0000 Message-ID: Date: Fri, 28 Jul 2023 05:17:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 2/2] soc: loongson2_pm: add power management support Content-Language: en-US To: Yinbo Zhu , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn, Liu Yun References: <20230728074944.26746-1-zhuyinbo@loongson.cn> <20230728074944.26746-3-zhuyinbo@loongson.cn> From: Randy Dunlap In-Reply-To: <20230728074944.26746-3-zhuyinbo@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi-- On 7/28/23 00:49, Yinbo Zhu wrote: > +config LOONGSON2_PM > + bool "Loongson-2 SoC Power Management Controller Driver" > + depends on LOONGARCH && OF > + help > + The Loongson-2's power management controller was ACPI, supports ACPI > + S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To > + Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods > + (USB, GMAC, PWRBTN, etc.). This driver was to add power management > + controller support that base on dts for Loongson-2 series SoCs. Kconfig help text should be indented with one tab +2 spaces, as documented in Documentation/process/coding-style.rst. thanks. -- ~Randy