From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C9CC46467 for ; Tue, 3 Jan 2023 15:51:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238038AbjACPvp (ORCPT ); Tue, 3 Jan 2023 10:51:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238031AbjACPvn (ORCPT ); Tue, 3 Jan 2023 10:51:43 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8C2B120B1 for ; Tue, 3 Jan 2023 07:51:35 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id t17so74691527eju.1 for ; Tue, 03 Jan 2023 07:51:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=taOMH3TFvYbtpRD0i3FdC+J1eAZMym1mmkB6tNExdDo=; b=y3D0xl6E94OyBJK6MXqzVOiVd651iCiYmyUsGpN5EdFHa2gjM9CkO5Bhy0VW8zDTq3 389xpL0IgOvqC2T6LKVIrZM0xObZnEs9o2ksmqJ+1QyjgjvHrstWySTQcoEVYw2bFRX2 wDn17oz4JWMmhqSonFcJX3a2wB5TDi/YAJUD+4q6h2oRLNJlSqh0xc+Gh7rA3xQRt3oB vWbyKAbtvrh/m/LUqfAileFF+3K7W9cjuIpQJdhG1sHW3jQRpoEsrwZn45GHlLDK555U k1IxsclvndKby6kXn4POiFMyReo1KzZmP3DNiJHHMftvo6rF1+5LdQMSDMSjowF0DGt5 6CcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=taOMH3TFvYbtpRD0i3FdC+J1eAZMym1mmkB6tNExdDo=; b=NOqi4Cv97ELeT4fA3W7Pk2uaO6Hizl7Rc+wFcdyFPIpdhl1+6viw+L8ZcvVtcRhnsN ITeLrLzveETUnvF8drmfTz0CFs+IwSjvyUqigjz7AiTJfj0uxNv6oaghv4ECi+gkbS4d Em9f9qmWSzQ0C+B1wd0N8XUWLWCX0XggPaahbK0iJooWcKCDsbR7nVAn7hMAd4pAO/qN q9RO+veIxsL2xq2HXUQdYuUZqqfwofM7hz+OFVLoOiJ7Wud936pmebcDCVh+uySDdpuf 2tk3YKOl3A/qlczYsXiBvd7Ct19eKyopOhTMEasGr2AvXiO+pFlbmBZyHdF+0jRpXARb ukPw== X-Gm-Message-State: AFqh2kr52R0qaBIyME3gbuo+mcHT8qnaMPnShSVRtHBo4SfsJA5kGq+k eX2WaD3OXpBoKUmai9Gi+Lt3rA== X-Google-Smtp-Source: AMrXdXvSh+smSCJ42CzF9CfpTvWzpF8F03yhi6vtuR/jj6aHCAABZEojnPbol2OjVyIPRT66fpxx3w== X-Received: by 2002:a17:907:d410:b0:7a7:9a38:d284 with SMTP id vi16-20020a170907d41000b007a79a38d284mr31250540ejc.19.1672761094018; Tue, 03 Jan 2023 07:51:34 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id m9-20020a1709062ac900b007c0d41736c0sm14158313eje.39.2023.01.03.07.51.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 07:51:33 -0800 (PST) Message-ID: Date: Tue, 3 Jan 2023 15:51:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v5 00/21] nvmem: core: introduce NVMEM layouts Content-Language: en-US To: Miquel Raynal , Michael Walle Cc: Jonathan Corbet , Rob Herring , Frank Rowand , Sascha Hauer , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Dan Carpenter References: <20221206200740.3567551-1-michael@walle.cc> <20230103163902.218cb5c7@xps-13> From: Srinivas Kandagatla In-Reply-To: <20230103163902.218cb5c7@xps-13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Miquel, On 03/01/2023 15:39, Miquel Raynal wrote: > Hi Srinivas, > > michael@walle.cc wrote on Tue, 6 Dec 2022 21:07:19 +0100: > >> This is now the third attempt to fetch the MAC addresses from the VPD >> for the Kontron sl28 boards. Previous discussions can be found here: >> https://lore.kernel.org/lkml/20211228142549.1275412-1-michael@walle.cc/ >> >> >> NVMEM cells are typically added by board code or by the devicetree. But >> as the cells get more complex, there is (valid) push back from the >> devicetree maintainers to not put that handling in the devicetree. >> >> Therefore, introduce NVMEM layouts. They operate on the NVMEM device and >> can add cells during runtime. That way it is possible to add more complex >> cells than it is possible right now with the offset/length/bits >> description in the device tree. For example, you can have post processing >> for individual cells (think of endian swapping, or ethernet offset >> handling). >> >> The imx-ocotp driver is the only user of the global post processing hook, >> convert it to nvmem layouts and drop the global post pocessing hook. >> >> For now, the layouts are selected by the device tree. But the idea is >> that also board files or other drivers could set a layout. Although no >> code for that exists yet. >> >> Thanks to Miquel, the device tree bindings are already approved and merged. >> >> NVMEM layouts as modules? >> While possible in principle, it doesn't make any sense because the NVMEM >> core can't be compiled as a module. The layouts needs to be available at >> probe time. (That is also the reason why they get registered with >> subsys_initcall().) So if the NVMEM core would be a module, the layouts >> could be modules, too. > > I believe this series still applies even though -rc1 (and -rc2) are out > now, may we know if you consider merging it anytime soon or if there > are still discrepancies in the implementation you would like to > discuss? Otherwise I would really like to see this laying in -next a > few weeks before being sent out to Linus, just in case. Thanks for the work! Lets get some testing in -next. Applied now, --srini > > Thanks, > Miquèl