From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BC5A315D4B for ; Thu, 25 Sep 2025 18:26:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758824821; cv=none; b=dE9DjPzaHfgSCutq42PY9R27bzd1Vx79MVVBaWr8Qih/+7sOShQg3+Gw6fTrv94ZqQPB4I+am7v1phg5igxE/peBjYdljLteK+2U4N1G7qUhihTRkQC0fcHQUuARMU7PCriBrihSFKBkRlewH8ghKdMoJNUP8g9yQ1JQUfoig28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758824821; c=relaxed/simple; bh=NMbylAYq7CYv0fkWtWUtjNn7VgoOmJ+cVhEKuBkCKu0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=noNmoX+TIHTautUx+C62j9owRdtGJGd2A3i/XM5IsUPkG884aTMhCqhd8l4/sv7aubST2r2Ahg6OkWQO/NauT5vDEZA/HksJuTQKTi1g01qdJfH7Q6ud6yFMqLhWIF2namg+JRgSqKb+bDr8+0bBosBgM8NeFijFTFktdYZGPbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZIZuhyS1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZIZuhyS1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58PIQQ2S026539 for ; Thu, 25 Sep 2025 18:26:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PqPeS5NEfA2UAdvDycz41izyD8C9Eo6POeSmVFtB8KQ=; b=ZIZuhyS15etcwleU PGcLB87EG1ZJydefJk/eNnc18pUtxkC3uGPQjqhQrrQfa0AH9aPC/yAkRp+1BNCS A+k6ueej0xFtzjOldX5E7KNwo5l+OhINoci5awS/iFm2BeMFz83m85PV2UQm5yXM KE2doRndk00DnfkJAe5GNWf904f56B10p8svxl8ZSpgNbe8I9m537bD5M6p04JoP q5KjvB/udC1fGqd/mK0uxbPHCm/592WK24GZiaGvMo8bugLgKX+VsMmzraD3gPwA lL3BNUY59qpi+yBBR1iB8KYTSxBuWNj8iVRynSM92fkI4qCSlvZUjHhVILqVuOe1 QuxYsg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49db0u002t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 25 Sep 2025 18:26:58 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-33428befc3aso1425727a91.2 for ; Thu, 25 Sep 2025 11:26:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758824817; x=1759429617; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PqPeS5NEfA2UAdvDycz41izyD8C9Eo6POeSmVFtB8KQ=; b=nANgmET9tH8s+PwBXr9A+04+4lxrkUC3sNJQ8I2/d15wzKUE0mXt58nRLPg9lrPIju 6xsFmftxYqWtWpN+Cz/GbeZPxdWJpHt0TXxX5gkvk1a2rEecWj7xTpkZ2KvZ1RW6FYK7 dUMMOPuaoSsyloVFWxlUz4WfktVxjEUzJwzTnNiv+0wmv1qj15n1edsYzywohfDc7kWU wZKR+PrpNZHfi8DnAFzcSb+SIWscHkq2cswdjArC/sn1F6Y0VkOh6y/A6Qki+UC61mY3 Mhk8c6g9eTFQ61CHd5RXxVuNk3IJaAvG8O1DiV2C7CH0KzVA0TNT0NZnQjYnkIfl8O0Z kh8w== X-Forwarded-Encrypted: i=1; AJvYcCXS6az9J9cpfY0Ezp0aI18tzDFH7W+Q+xIY4M1Ta6TtN9NEb24j3TjqMli/sZUKzUdjZR3FE1QkA+5+@vger.kernel.org X-Gm-Message-State: AOJu0YypfhDCmt11BL20tDzs4MvuRTQLAURcAR9R1vWBdVSZWMdg3rN9 TKAw0r/vaFn2Az0rREHVeTn9uj7YbTGeuBYRMzYR8EQoB0y2ttYpU6sjSB7DvwLXStB+EeJd/G0 nDvSEtftPb5JF6nI5+Ax3h/mQCJ9b35z5gFi01rcjFxu8QZinyLTt8RG00qHjB9Cq X-Gm-Gg: ASbGncvpz3vx/YVeg5yvZx9V4fNfVe1Mq6qGNo+fpL4azW//QByHSn7ambVcYmU/Gqn Lky5nOnfH8uGuu50rzVYXCEnhjTJDbl5nTBlikqDz/0J7MPnKXjKUl5klZGkXZqRGYxT8I3Dg/z eYz8IC6ggHMt/9RWprPLSW/rJezoNDGlmLH6Rg3KPUNuzn8tJjXOWRDiWjWB6RU+Uy1NA4gRXFy 1alIZKhPS/W7BDw92USAbNWn0g1O6iEKuTnbe45ga50trtCH1FtRCZSCAwM5c9k00eV3TGV++sO q8wYCRMJn5ZNzlLPUhueaJHHBVXQwhXRnxR5zNQ7kU0rulSm1FNGLTdRYafzeiqySmba2J0rG/6 sChfL5Z3RQR5ikI0MAHfL5va39LVd+Fg= X-Received: by 2002:a17:90b:3d4b:b0:32d:d4fa:4c3 with SMTP id 98e67ed59e1d1-3342a2ef04fmr3451100a91.31.1758824816745; Thu, 25 Sep 2025 11:26:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8VfXlVS+KwPpyYFd34T8pPu8mdtcmA2+TC/qpR/h7izvQa1fT2HATDC6sqAu3sewVGidgrA== X-Received: by 2002:a17:90b:3d4b:b0:32d:d4fa:4c3 with SMTP id 98e67ed59e1d1-3342a2ef04fmr3451074a91.31.1758824816203; Thu, 25 Sep 2025 11:26:56 -0700 (PDT) Received: from [192.168.86.246] (syn-076-176-048-107.res.spectrum.com. [76.176.48.107]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3342a3cab8fsm1456102a91.1.2025.09.25.11.26.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Sep 2025 11:26:55 -0700 (PDT) Message-ID: Date: Thu, 25 Sep 2025 11:26:42 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/20] arm64: dts: qcom: kaanapali: Add USB support for Kaanapali SoC To: "Aiqun(Maria) Yu" , =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= , Jingyi Wang Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Ronak Raheja References: <20250924-knp-dts-v1-0-3fdbc4b9e1b1@oss.qualcomm.com> <20250924-knp-dts-v1-6-3fdbc4b9e1b1@oss.qualcomm.com> <53d63dd6-a022-4e80-a317-3218976a7474@oss.qualcomm.com> Content-Language: en-US From: Trilok Soni In-Reply-To: <53d63dd6-a022-4e80-a317-3218976a7474@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 7uM4g0ZFJG5jkjkWq5LMLCNUAq0Xf4bY X-Proofpoint-GUID: 7uM4g0ZFJG5jkjkWq5LMLCNUAq0Xf4bY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI1MDE3MSBTYWx0ZWRfX77uWU3fiobOu HPSLFUKyaSG7oDosV9V37WHak83rVjJsREXydX9RFhBPf7frC5E+pkE3DcUJ4BKF4j5J96VJXlN LIFKPZG6GXnixQkzUv925wCyQj3wZTbBPdc/SVuDM5xezcYwy3WLHIIfmHeZj7ySbpB0CQ9XqMd jMlEd0hK7DYqMEJKSNI702WVrgp/GP5JKHKyfaF+vgt3ibS0k9SM9o4lZbAGTM9e2r256GnxfKW I/MUoLxmgR5ZnKnkzLcjyJLgqDJ3+Opy3WtFkDPPqx3nl/elUEiCi62oC7sBE2TcPYWDNQdAUOl fum1fgzHfVnj+dBGkqNoQJaXGsanIMrXsdVw3dZrm0BpYTOPJ4Kol84xQBPDOhzUhvzEHcvmG0i i21y2w3PYHrMuTv19RLrH4q9oMTKgA== X-Authority-Analysis: v=2.4 cv=ZsHg6t7G c=1 sm=1 tr=0 ts=68d58972 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=lsoD3MMNObdLvy1227ExmA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=_4E2EnyzloM2vKAfYDwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-25_01,2025-09-25_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1011 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509250171 On 9/25/2025 12:39 AM, Aiqun(Maria) Yu wrote: > On 9/25/2025 9:50 AM, Krzysztof Kozłowski wrote: >> On Thu, 25 Sept 2025 at 09:17, Jingyi Wang wrote: >>> >>> From: Ronak Raheja >>> >>> Add the base USB devicetree definitions for Kaanapali platform. The overall >>> chipset contains a single DWC3 USB3 controller (rev. 200a), SS QMP PHY >>> (rev. v8) and M31 eUSB2 PHY. >>> >>> Signed-off-by: Ronak Raheja >>> Signed-off-by: Jingyi Wang >>> --- >>> arch/arm64/boot/dts/qcom/kaanapali.dtsi | 155 ++++++++++++++++++++++++++++++++ >>> 1 file changed, 155 insertions(+) >>> >> >> >> Second try, without HTML: >> >> I really don't understand why you created such huge patchset. Year >> ago, two years ago, we were discussing it already and explained that's >> just inflating the patchset without reason. >> >> New Soc is one logical change. Maybe two. Not 18! > > It was previously squashed into the base soc dtsi patch and mark like: > Written with help from Jyothi Kumar Seerapu(added bus), Ronak Raheja > (added USB), Manish Pandey(added SDHCI), Gaurav Kashyap(added crypto), > Manaf Meethalavalappu Pallikunhi(added tsens), Qiang Yu(added PCIE) and > Jinlong Mao(added coresight). > > While it is over 4000+ lines when we squash it together. > Also as offline reviewed with Bjorn, he suggested us to split out the > USB and other parts. > >> >> Not one patch per node or feature. >> >> This hides big picture, makes difficult to review everything, >> difficult to test. Your patch count for LWN stats doesn't matter to >> us. Maria - the point here is to not design the series / code for stats, but per maintainer expectations. Though it is difficult to know one preferred guideline. > > With the current splitting, the different author as each co-developer > can get the meaningful LWN stats.> >> NAK and I'm really disappointed I have to repeat the same review . > Currently, there are 10 SoC DTSI patches sent, structured as follows: > > SoC initial > Base MTP board > SoC PCIe0 > SoC SDC2 > SoC USB > SoC remoteproc > SoC SPMI bus, TSENS, RNG, QCrypto, and Coresight > SoC additional features > SoC audio > SoC CAMSS > SoC video > > Which parts would you prefer to squash into pls? >