From: Amit Sunil Dhamne <amitsd@google.com>
To: gregkh@linuxfoundation.org, robh@kernel.org,
heikki.krogerus@linux.intel.com, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: badhri@google.com, kyletso@google.com, rdbabiera@google.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, dmitry.baryshkov@linaro.org
Subject: Re: [RFC v4 0/2] Add support for time DT property in TCPM
Date: Mon, 21 Oct 2024 16:01:10 -0700 [thread overview]
Message-ID: <cf0f9a77-4981-48af-8fda-76e57f8a54fa@google.com> (raw)
In-Reply-To: <20240925031135.1101048-1-amitsd@google.com>
Hi,
I had a process related question. Once an RFC patchset gets a
Reviewed-by tag, do I need to send a formal [PATCH] or is an RFC patch
sufficient for being accepted?
I tried to look for it in the Kernel documentation but couldn't find.
Please can you help me on the next steps.
Thanks,
Amit
On 9/24/24 8:11 PM, Amit Sunil Dhamne wrote:
> USB PD specification defines a bunch of timers that can have a range of
> acceptable values instead of specific values. These values have to be
> tuned based on the platform. However, TCPM currently sets them to a
> default value without providing a mechanism to set platform specific
> values.
>
> This patchset adds new DT properties per timer to allow users to define
> platform specific values.
>
> Changes compared to v3:
> - nit: removed an extra newline that got added in tcpm_register_port()
>
> Changes compared to v2:
> - Added min, max & default values to DT property in Documentation.
> - Changed return type of tcpm_fw_get_timings to void instead of int.
>
> Changes compared to v1:
> - Defined new properties per timer that we are interested in rather
> than defining a single pd-timers u32 array property.
> - Better description of the timer properties.
> - Since subject has changed, adding link for previous patchset for
> posterity:
> https://lore.kernel.org/all/20240911000715.554184-1-amitsd@google.com/
>
> Amit Sunil Dhamne (2):
> dt-bindings: connector: Add properties to define time values
> usb: typec: tcpm: Add support for parsing time dt properties
>
> .../bindings/connector/usb-connector.yaml | 35 ++++++++-
> drivers/usb/typec/tcpm/tcpm.c | 73 +++++++++++++++----
> 2 files changed, 91 insertions(+), 17 deletions(-)
>
>
> base-commit: 68d4209158f43a558c5553ea95ab0c8975eab18c
next prev parent reply other threads:[~2024-10-21 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 3:11 [RFC v4 0/2] Add support for time DT property in TCPM Amit Sunil Dhamne
2024-09-25 3:11 ` [RFC v4 1/2] dt-bindings: connector: Add properties to define time values Amit Sunil Dhamne
2024-09-25 3:11 ` [RFC v4 2/2] usb: typec: tcpm: Add support for parsing time dt properties Amit Sunil Dhamne
2024-10-21 23:01 ` Amit Sunil Dhamne [this message]
2024-10-22 5:14 ` [RFC v4 0/2] Add support for time DT property in TCPM Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf0f9a77-4981-48af-8fda-76e57f8a54fa@google.com \
--to=amitsd@google.com \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdbabiera@google.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).