From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B558EC43462 for ; Thu, 6 May 2021 09:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94E6161157 for ; Thu, 6 May 2021 09:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233362AbhEFJjt (ORCPT ); Thu, 6 May 2021 05:39:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34457 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233216AbhEFJjt (ORCPT ); Thu, 6 May 2021 05:39:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620293930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p52RRVDShx6NwBL9aQkjgj+5ixdcF28Fa0Bi2oa7Re8=; b=Y74+q95l+avRgtjVgovZ1GVmy81xk7ftI5l543OAkCFY+3V4hjzyaj0TIz72oKI85dajGt 7DVYSuuDVEHy/i8RuoLt+Z2mW5GG+7izqlmcmexvxsLZz51lQmIN1NTHJGlKmQj+4gxWWk T9FsI5lcv+nAXQSRLIObGNtdsfk7bCM= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-pkfluPH_N9qqF3IjNGO-zA-1; Thu, 06 May 2021 05:38:49 -0400 X-MC-Unique: pkfluPH_N9qqF3IjNGO-zA-1 Received: by mail-ed1-f71.google.com with SMTP id y17-20020a0564023591b02903886c26ada4so2340676edc.5 for ; Thu, 06 May 2021 02:38:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p52RRVDShx6NwBL9aQkjgj+5ixdcF28Fa0Bi2oa7Re8=; b=fk08mXZFogQdk+OQSKEDIWfp9OpTbAijBQGvQCj6W2tvL1LL7cOOavdq61U0DHLLmS fjALOQoKNfpnu9mcF5WR8npQP1aMLl8GuNjoiCasaapGRFuqIe9xhlNbFU0NQtK6qMML hkmE/BaPim3YM1zhElZawYJC86macMBhB5vVD/xH6Wdm9plRjVxEtKuyM8Hg0bdgMYRH k6dl+MCgkx8SY+6AKa2qWJjFlrixS4s+ypKXBvsUdh48klv6wfMjkrgAtcRw9Ideg4Tz cwGslGXmCytz1TVxT3LoiIFP708JRuU0B6nIdae62ajIO+4zVMKk1r/gWrD0SJufsBoX XO+Q== X-Gm-Message-State: AOAM532KdWyWq8wDo8Q9lwcuQuy3VHF/GoT+R5qPFgeZtQkGxm4MS7p6 7wmTYkeQNbO8+zyhw+/7fSPIfoQHwyc4ouD8V+3Wo8qDiWlKkBnN5zJrctnYQewwgalPhPLvHQB 13y4MmJpk/Z0mINGhWIBfgQ== X-Received: by 2002:aa7:d84e:: with SMTP id f14mr4064233eds.220.1620293927880; Thu, 06 May 2021 02:38:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+4qyVOHI06BR7s1AYqjMSV9ZbPDO6ac3yUuTtnTY2Clx45ALcLve0fnR6T0PF02cdmOccWQ== X-Received: by 2002:aa7:d84e:: with SMTP id f14mr4064221eds.220.1620293927722; Thu, 06 May 2021 02:38:47 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id e4sm1015832ejh.98.2021.05.06.02.38.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 May 2021 02:38:47 -0700 (PDT) Subject: Re: [PATCH v7 1/7] MAINTAINERS: Add Advantech AHC1EC0 embedded controller entry To: Andy Shevchenko Cc: Campion Kang , Lee Jones , Rob Herring , Mark Gross , Wim Van Sebroeck , Guenter Roeck , Jean Delvare , Jonathan Corbet , devicetree , Linux Kernel Mailing List , linux-watchdog@vger.kernel.org, linux-hwmon@vger.kernel.org, Linux Documentation List , Platform Driver , AceLan Kao References: <20210506081619.2443-1-campion.kang@advantech.com.tw> <6b86bd36-b934-c204-9e56-079ab8cd4b54@redhat.com> From: Hans de Goede Message-ID: Date: Thu, 6 May 2021 11:38:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 5/6/21 11:23 AM, Andy Shevchenko wrote: > On Thu, May 6, 2021 at 11:48 AM Hans de Goede wrote: >> I'm replying here since this series has no cover-letter, for >> the next version for a series touching so many different >> sub-systems it would be good to start with a cover-letter >> providing some background info on the series. >> >> I see this is binding to an ACPI device, yet it is also using >> devicetree bindings and properties. >> >> So I take it this means that your ACPI tables are using the >> optional capability of embedded device-tree blobs inside the >> ACPI tables ? >> >> That is an unusual combination on a x86 device, note it is >> not wrong > > It's actually not okay. We have agreed at some point with DT people, > that ACPI should not use non-native variants of natively supported > things. For example, it shouldn't use "interrupt" property for IOxAPIC > (or xIC) provided interrupts, rather Interrupt() has to be used and so > on. Right, but that is not the case here, they are using 2 device-tree properties (1), from patch 3/7: +properties: + compatible: + const: advantech,ahc1ec0 + + advantech,hwmon-profile: + description: + The number of sub-devices specified in the platform. Defines for the + hwmon profiles can found in dt-bindings/mfd/ahc1ec0-dt. + $ref: /schemas/types.yaml#/definitions/uint32 + maxItems: 1 + + advantech,has-watchdog: + description: + Some implementations of the EC include a watchdog used to monitor the + system. This boolean flag is used to specify whether this watchdog is + present or not. Default is true, otherwise set to false. + type: boolean >> but AFAIK you are the first to do this on x86. > > No, not the first. Once Intel tried to invent the pin control > configuration and muxing properties in ACPI, it was luckily rejected > (ACPI 6.x OTOH provides a set of special resources for that). > > So, NAK from me, *if* it's really the case. ACPI tables must be revisited. AFAIK Advantech are not defining things for which an ACPI standard exists, although these 2 properties might just as well may be 2 simple ACPI integer methods, which would actually make things a bit simpler (.e.g it would allow dropping patch 2/7 and 3/7 from the set). Campion, any reason why you went this route; and can the ACPI tables still be changed? Regards, Hans