From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A34C433FE for ; Fri, 4 Nov 2022 14:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbiKDOEY (ORCPT ); Fri, 4 Nov 2022 10:04:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230003AbiKDOEW (ORCPT ); Fri, 4 Nov 2022 10:04:22 -0400 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9352622BF1 for ; Fri, 4 Nov 2022 07:04:21 -0700 (PDT) Received: by mail-qv1-xf2f.google.com with SMTP id x15so3257158qvp.1 for ; Fri, 04 Nov 2022 07:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SGXI4uOFUmw6tZuPJPIsRTwiUyuymqNGhyu0fMFLngY=; b=Y3Jh7krSivsqUXZ1y8aUKcbH0YggDsbbm62KuXJDGrLqEMYhAVhtbnLmVr4NRE4V7A r4GHd7AzcBHpTxbI3xMOodbEGGBLsebbWXGDsgIxNX3xw0psYxuyvalVEURq+b9dtp42 Zec3/x5TyCr27R6LXpkQWobhyWF+K8Qch0XYMIrrEztR4F+p7R6n08Zf+/RrFIHG8x3i BfjhEM2o+LSWjiNfmZGKk3WTS1D68nb+4SqS9xER9ekgkerDTSeuUJQyM2LsImLODkIk wdEQrfGfAQrGRN8W+vXjgu7mPEazrTEhZPgSCLRKWQMiJraexXUZGW6aPgWjtnX3/fuu mPEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SGXI4uOFUmw6tZuPJPIsRTwiUyuymqNGhyu0fMFLngY=; b=r6L6tsgxpDNMylJNjFXf3R16m29O4j4i++F7F2bUe186yu4uK96eAfOlDlPEBBF0m5 7hZR4LFrGIDM/EEigKqScx0Pr2ZKrxbao3yBKh4muB5yrbQhXiDrm/C8lBFBvfCq3dc/ BDEN8SE/pQB4+A0PPnRMppATAleV71mbA9uI7VIo7B6vZM+6p2lBL6HY6SfSB8Rwq/zG DWVjx9JA5aHsaUbQyPpHRWtGkTuztRSRAK3l5HKKw1jdhN3fPlMt2G5ksETDkE2/uhUQ BOfUWmol+QRrpMWaLjEk+PH1YOXLeAH7b0fKkRuUCAZS+6l9IetyWOl1vko5hV699Czd CcuQ== X-Gm-Message-State: ACrzQf2w26QuZYAh0Fyc5HHew+cbGK8CDejr5++19HIBQ9+cjWn2PA9x 2ElcbELKgtVadpNCPghD0gKAgQ== X-Google-Smtp-Source: AMsMyM7t1UWhJ3+vFZhZ5FsL+3dGPFrNeosAMKKArGnMGgQF1/R8eynBl4jHvCyW6+G61q2kQXzccg== X-Received: by 2002:a05:6214:c63:b0:4bb:d14c:ada4 with SMTP id t3-20020a0562140c6300b004bbd14cada4mr30219758qvj.77.1667570660739; Fri, 04 Nov 2022 07:04:20 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:aad6:acd8:4ed9:299b? ([2601:586:5000:570:aad6:acd8:4ed9:299b]) by smtp.gmail.com with ESMTPSA id u12-20020a05620a430c00b006b640efe6dasm2984286qko.132.2022.11.04.07.04.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 07:04:20 -0700 (PDT) Message-ID: Date: Fri, 4 Nov 2022 10:04:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/2] soc: qcom: Add Qualcomm Ramp Controller driver Content-Language: en-US To: AngeloGioacchino Del Regno , agross@kernel.org Cc: andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marijn.suijten@somainline.org, kernel@collabora.com, AngeloGioacchino Del Regno References: <20221104133506.131316-1-angelogioacchino.delregno@collabora.com> <20221104133506.131316-3-angelogioacchino.delregno@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20221104133506.131316-3-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/11/2022 09:35, AngeloGioacchino Del Regno wrote: > From: AngeloGioacchino Del Regno > > The Ramp Controller is used to program the sequence ID for pulse > swallowing, enable sequence and linking sequence IDs for the CPU > cores on some Qualcomm SoCs. > > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/soc/qcom/Kconfig | 9 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/ramp_controller.c | 330 +++++++++++++++++++++++++++++ > 3 files changed, 340 insertions(+) > create mode 100644 drivers/soc/qcom/ramp_controller.c > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index 024e420f1bb7..1e681f98bad4 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -95,6 +95,15 @@ config QCOM_QMI_HELPERS > tristate > depends on NET > > +config QCOM_RAMP_CTRL > + tristate "Qualcomm Ramp Controller driver" > + depends on ARCH_QCOM I propose: depends on ARCH_QCOM && ARM || COMPILE_TEST I don't think it is used on ARM64 SoCs, so let's make life of distros easier. > + help > + The Ramp Controller is used to program the sequence ID for pulse > + swallowing, enable sequence and linking sequence IDs for the > + CPU cores on some Qualcomm SoCs. > + Say y here to enable support for the ramp controller. > + > config QCOM_RMTFS_MEM > tristate "Qualcomm Remote Filesystem memory driver" > depends on ARCH_QCOM > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index d66604aff2b0..6e02333c4080 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -10,6 +10,7 @@ obj-$(CONFIG_QCOM_OCMEM) += ocmem.o > obj-$(CONFIG_QCOM_PDR_HELPERS) += pdr_interface.o > obj-$(CONFIG_QCOM_QMI_HELPERS) += qmi_helpers.o > qmi_helpers-y += qmi_encdec.o qmi_interface.o > +obj-$(CONFIG_QCOM_RAMP_CTRL) += ramp_controller.o > obj-$(CONFIG_QCOM_RMTFS_MEM) += rmtfs_mem.o > obj-$(CONFIG_QCOM_RPMH) += qcom_rpmh.o > qcom_rpmh-y += rpmh-rsc.o > diff --git a/drivers/soc/qcom/ramp_controller.c b/drivers/soc/qcom/ramp_controller.c > new file mode 100644 > index 000000000000..e28679b545d1 > --- /dev/null > +++ b/drivers/soc/qcom/ramp_controller.c > @@ -0,0 +1,330 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Qualcomm Ramp Controller driver > + * Copyright (c) 2022, AngeloGioacchino Del Regno > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define RC_UPDATE_EN BIT(0) > +#define RC_ROOT_EN BIT(1) > + > +#define RC_REG_CFG_UPDATE 0x60 > + #define RC_CFG_UPDATE_EN BIT(8) > + #define RC_CFG_ACK GENMASK(31, 16) Drop spaces before #define > + > +#define RC_DCVS_CFG_SID 2 > +#define RC_LINK_SID 3 > +#define RC_LMH_SID 6 > +#define RC_DFS_SID 14 > + > +#define RC_UPDATE_TIMEOUT_US 500 > + > +/** > + * struct qcom_ramp_controller_desc - SoC specific parameters > + * @cfg_dfs_sid: Dynamic Frequency Scaling SID configuration > + * @cfg_link_sid: Link SID configuration > + * @cfg_lmh_sid: Limits Management hardware SID configuration > + * @cfg_ramp_pre_en: Ramp Controller pre-enable sequence > + * @cfg_ramp_en: Ramp Controller enable sequence > + * @cfg_ramp_post_en: Ramp Controller post-enable sequence > + * @cfg_ramp_dis: Ramp Controller disable sequence > + * @cmd_reg: Command register offset > + * @num_dfs_sids: Number of DFS SIDs (max 8) > + * @num_link_sids: Number of Link SIDs (max 3) > + * @num_lmh_sids: Number of LMh SIDs (max 8) > + */ > +struct qcom_ramp_controller_desc { > + struct reg_sequence *cfg_dfs_sid; I didn't check much, but can these be pointers to const? > + struct reg_sequence *cfg_link_sid; > + struct reg_sequence *cfg_lmh_sid; > + struct reg_sequence *cfg_ramp_pre_en; > + struct reg_sequence *cfg_ramp_en; > + struct reg_sequence *cfg_ramp_post_en; > + struct reg_sequence *cfg_ramp_dis; > + u8 cmd_reg; > + u8 num_dfs_sids; > + u8 num_link_sids; > + u8 num_lmh_sids; > +}; > + (...) > + > +static struct platform_driver qcom_ramp_controller_driver = { > + .driver = { > + .name = "qcom-ramp-controller", > + .of_match_table = qcom_ramp_controller_match_table, > + .suppress_bind_attrs = true, > + }, > + .probe = qcom_ramp_controller_probe, > + .remove = qcom_ramp_controller_remove, > +}; > + > +static int __init qcom_ramp_controller_init(void) > +{ > + return platform_driver_register(&qcom_ramp_controller_driver); > +} > +arch_initcall(qcom_ramp_controller_init); Does it really have to be arch initcall? Cannot be module platform driver? > + > +MODULE_AUTHOR("AngeloGioacchino Del Regno "); > +MODULE_DESCRIPTION("Qualcomm Ramp Controller driver"); > +MODULE_LICENSE("GPL"); Best regards, Krzysztof