From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Taniya Das <quic_tdas@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 05/16] dt-bindings: clock: qcom,mmcc-msm8998: drop core_bi_pll_test_se
Date: Tue, 3 Jan 2023 18:09:57 +0200 [thread overview]
Message-ID: <cf1f65e4-338a-c519-1401-91e13b5fd937@linaro.org> (raw)
In-Reply-To: <CAOCk7Noa1A4mBqg3OAxk3hnnUg-qjCeCE0tyhq3ktbFcETicqw@mail.gmail.com>
On 03/01/2023 17:38, Jeffrey Hugo wrote:
> On Wed, Dec 28, 2022 at 6:33 AM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
>>
>> The test clock apparently it's not used by anyone upstream. Remove it.
>
> IMO, NACK,
>
> This is not a valid justification.
>
> The DT is supposed to describe the hardware, and should be complete in
> that regard. This clock exists in the hardware, so it should be
> described.
Most of Qualcomm clock controllers can input clocks from
core_bi_pll_test_se. But we are listing them only for a small number of
them. And even on these platforms nobody provides this clock.
Maybe you shed some light here, what is the source of this clock? Who
provides the clock, e.g. on msm8998 platform?
>
> DT is supposed to be separate from Linux, that is it doesn't matter
> that Linux doesn't consume this clock. Maybe FreeBSD does, or some
> other OS. Linux doesn't own Device Tree any more than it owns BIOS or
> ACPI.
>
> Also, I'm listed as a maintainer for this binding, yet this series is
> not addressed to me. Seems like you might need to review how you are
> composing your patches.
Ack, excuse me. I missed the 'in file' maintainers.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-01-03 16:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 13:32 [PATCH 00/16] clk: qcom: get rid of core_bi_pll_test_se Dmitry Baryshkov
2022-12-28 13:32 ` [PATCH 01/16] dt-bindings: clock: qcom,gcc-msm8998: drop core_bi_pll_test_se Dmitry Baryshkov
2022-12-28 17:16 ` Rob Herring
2022-12-28 13:32 ` [PATCH 02/16] dt-bindings: clock: qcom,gcc-sdx55: " Dmitry Baryshkov
2022-12-28 13:32 ` [PATCH 03/16] dt-bindings: clock: qcom,gcc-sdx65: " Dmitry Baryshkov
2022-12-28 13:32 ` [PATCH 04/16] dt-bindings: clock: qcom,gcc-sm8350: " Dmitry Baryshkov
2022-12-28 13:32 ` [PATCH 05/16] dt-bindings: clock: qcom,mmcc-msm8998: " Dmitry Baryshkov
2023-01-03 15:38 ` Jeffrey Hugo
2023-01-03 16:09 ` Dmitry Baryshkov [this message]
2023-01-03 16:31 ` Jeffrey Hugo
2023-01-04 10:45 ` Dmitry Baryshkov
2022-12-28 13:32 ` [PATCH 06/16] dt-bindings: clock: qcom: gcc-sm8350: drop test clock Dmitry Baryshkov
2022-12-28 13:32 ` [PATCH 07/16] dt-bindings: clock: qcom: gcc-sm8450: " Dmitry Baryshkov
2022-12-28 13:32 ` [PATCH 08/16] clk: qcom: dispcc-qcm2290: get rid of " Dmitry Baryshkov
2022-12-28 13:38 ` Konrad Dybcio
2022-12-28 13:32 ` [PATCH 09/16] clk: qcom: gcc-msm8998: " Dmitry Baryshkov
2022-12-28 13:38 ` Konrad Dybcio
2022-12-28 13:32 ` [PATCH 10/16] clk: qcom: gcc-sc7180: " Dmitry Baryshkov
2022-12-28 13:39 ` Konrad Dybcio
2022-12-28 13:32 ` [PATCH 11/16] clk: qcom: gcc-sdx55: use ARRAY_SIZE instead of specifying num_parents Dmitry Baryshkov
2022-12-28 13:39 ` Konrad Dybcio
2022-12-28 13:32 ` [PATCH 12/16] clk: qcom: gcc-sdx55: get rid of test clock Dmitry Baryshkov
2022-12-28 13:40 ` Konrad Dybcio
2022-12-28 13:32 ` [PATCH 13/16] clk: qcom: gcc-sm8150: " Dmitry Baryshkov
2022-12-28 13:40 ` Konrad Dybcio
2022-12-28 13:32 ` [PATCH 14/16] clk: qcom: gcc-sm8350: " Dmitry Baryshkov
2022-12-28 13:40 ` Konrad Dybcio
2022-12-28 13:32 ` [PATCH 15/16] clk: qcom: mmcc-msm8998: " Dmitry Baryshkov
2022-12-28 13:41 ` Konrad Dybcio
2022-12-28 13:32 ` [PATCH 16/16] arm64: dts: qcom: msm8998: " Dmitry Baryshkov
2022-12-28 13:41 ` Konrad Dybcio
2022-12-28 15:07 ` [PATCH 00/16] clk: qcom: get rid of core_bi_pll_test_se Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf1f65e4-338a-c519-1401-91e13b5fd937@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).