From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B34C3DA7D for ; Tue, 3 Jan 2023 16:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231270AbjACQKm (ORCPT ); Tue, 3 Jan 2023 11:10:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233454AbjACQKC (ORCPT ); Tue, 3 Jan 2023 11:10:02 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 752F41277C for ; Tue, 3 Jan 2023 08:10:00 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id bn6so22462108ljb.13 for ; Tue, 03 Jan 2023 08:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=42zZAHf1jxTjkV11A2s0BJ3xhHEnWIKWoo4gYXrvk0I=; b=uXkgYDGeSAi7kzEdyXXMkuc2svB79GOyFQf6YY8NM/QOAcYzXJ4tX24K/r2z1NWvYf i/hqrKc8nMH+OV2DhjQ1GPGMl1fb7ErXRyDOC71a5msAFCHUJ30RVEY1gAjWXxIB2mpN byweSug2pKUY+BFvgefoLmC/ffDN3AYlAfV/garGV1ke38xZKOJKhvwYfD5XnD27Qysn KQZxpDQ3GTPkgEozGj+kNp/mOn7nhKsGOv2w3+N+/b9yoHLC2DEdIgGpCMorRsk5i2Zs sijPZ7KAPS1+YQZl17zXmmqQ6NWBjjQuzSFfuMtlqNWsAskW1d2U3DcX5X8YDai024Ae ee+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=42zZAHf1jxTjkV11A2s0BJ3xhHEnWIKWoo4gYXrvk0I=; b=K021gxKMNLd7LBkgtsICQVjmS17JJDXLTt/Gj6Wf5UQlmucwivN/hn6eYoU5JauVQ0 wbyg9YmTpdNZlMbVOvjvGKx3/cA64OMY9TTiKVzXtdsH8lj813RGA8HAvOAyiNd+LC1P KyvbJ94RPV54nqNcXt0c6mE5xxkX0QSQnyU1V+xzTFI60UTumW0yAIsOJWYS4HKVr5ww t2YWB3ktf/2qxKjnfLGaW2s+dpcodObj32W4Hpo9syecRkwJgz+cmRFQsczl3JqCS4fk 4xlRYTSckN1U2r2hOKfovnxJvw4HApzPMq035rZqpW+x3GeHz8svbC+rcy9r2fnJilSx TqbQ== X-Gm-Message-State: AFqh2kqlCxzrA8GNsbw95GkG1QNN+yk83HKYeX8Xls85TNKF2w7MtTU8 2ituWld4prrfgiXDC8HaZo3dAA== X-Google-Smtp-Source: AMrXdXsezd1AuOVRPAIJpP/L2NKRk9zglMYh3vW1w7m1xoPgT2UfTlkRwg0+k62Mxc8YF7PuWZQCBQ== X-Received: by 2002:a2e:95d9:0:b0:27f:bf70:e55c with SMTP id y25-20020a2e95d9000000b0027fbf70e55cmr8458899ljh.28.1672762198759; Tue, 03 Jan 2023 08:09:58 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id q10-20020a2eb4aa000000b0027fd72dd6a1sm1528831ljm.70.2023.01.03.08.09.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 08:09:58 -0800 (PST) Message-ID: Date: Tue, 3 Jan 2023 18:09:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 05/16] dt-bindings: clock: qcom,mmcc-msm8998: drop core_bi_pll_test_se Content-Language: en-GB To: Jeffrey Hugo Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org References: <20221228133243.3052132-1-dmitry.baryshkov@linaro.org> <20221228133243.3052132-6-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/01/2023 17:38, Jeffrey Hugo wrote: > On Wed, Dec 28, 2022 at 6:33 AM Dmitry Baryshkov > wrote: >> >> The test clock apparently it's not used by anyone upstream. Remove it. > > IMO, NACK, > > This is not a valid justification. > > The DT is supposed to describe the hardware, and should be complete in > that regard. This clock exists in the hardware, so it should be > described. Most of Qualcomm clock controllers can input clocks from core_bi_pll_test_se. But we are listing them only for a small number of them. And even on these platforms nobody provides this clock. Maybe you shed some light here, what is the source of this clock? Who provides the clock, e.g. on msm8998 platform? > > DT is supposed to be separate from Linux, that is it doesn't matter > that Linux doesn't consume this clock. Maybe FreeBSD does, or some > other OS. Linux doesn't own Device Tree any more than it owns BIOS or > ACPI. > > Also, I'm listed as a maintainer for this binding, yet this series is > not addressed to me. Seems like you might need to review how you are > composing your patches. Ack, excuse me. I missed the 'in file' maintainers. -- With best wishes Dmitry