From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH v2 2/4] iio: Documentation: Add Xilinx AMS sysfs documentation Date: Mon, 17 Sep 2018 11:56:08 +0200 Message-ID: References: <1536909510-7166-1-git-send-email-manish.narani@xilinx.com> <1536909510-7166-3-git-send-email-manish.narani@xilinx.com> <20180916111242.73af71ed@archlinux> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180916111242.73af71ed@archlinux> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jonathan Cameron , Manish Narani Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, michal.simek@xilinx.com, robh+dt@kernel.org, mark.rutland@arm.com, sudeep.holla@arm.com, amit.kucheria@linaro.org, leoyang.li@nxp.com, broonie@kernel.org, arnaud.pouliquen@st.com, eugen.hristev@microchip.com, rdunlap@infradead.org, geert@linux-m68k.org, ak@it-klinger.de, freeman.liu@spreadtrum.com, lukas@wunner.de, vilhelm.gray@gmail.com, gregkh@linuxfoundation.org, kstewart@linuxfoundation.org, sgoud@xilinx.com, anirudh@xilinx.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 16.9.2018 12:12, Jonathan Cameron wrote: > On Fri, 14 Sep 2018 12:48:28 +0530 > Manish Narani wrote: > >> Add documentation for xilinx-ams driver. This contains information about >> various voltages and temperatures on PS (Processing System), PL >> (Programmable Logic) and AMS Control Block. >> >> Signed-off-by: Manish Narani > The more I look at this device the more I'm convinced it is very much a dedicated > hardware monitoring function, not a generic ADC sensing unit at all. > > Hmm. It is still fine to have it in IIO but you need to think in detail > about how you are going to interface this to hwmon via the iio-hwmon bridge. > > Some of the interface complexity should only really be apparent when we hit > hwmon perhaps rather than having so many different custom interfaces in IIO. > > Please also loop in the maintainers and lists for hwmon in the next > version so we can get their input. Isn't there iio-hwmon driver for this? Thanks, Michal