devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Banajit Goswami <bgoswami@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Patrick Lai <plai@qti.qualcomm.com>,
	Srinivasa Rao Mandadapu <srivasam@qti.qualcomm.com>
Subject: Re: [PATCH 10/10] ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node
Date: Mon, 14 Nov 2022 11:40:50 +0000	[thread overview]
Message-ID: <cf66aa8f-4bf7-d9c0-e2ae-b6fced7e4948@linaro.org> (raw)
In-Reply-To: <20221111113547.100442-11-krzysztof.kozlowski@linaro.org>



On 11/11/2022 11:35, Krzysztof Kozlowski wrote:
> On SM8450 and SC8280XP, the Q6APM is a bit different:

This is not specific to SM8450 or SC8280XP its part of AudioReach apm 
which deals with both backends and pcm.

In old Elite architecture we had a dedicated service AFE to deal with 
Backend dais, now APM does all.

Thanks,
Srini

> 1. It is used as a platform DAI link, so it needs #sound-dai-cells.
> 2. It has two DAI children, so add new "bedais" node.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   .../devicetree/bindings/sound/qcom,q6apm.yaml    | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> index 7acb832aa557..cd434e8268ce 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> @@ -18,14 +18,24 @@ properties:
>       enum:
>         - qcom,q6apm
>   
> +  bedais:
> +    type: object
> +    $ref: /schemas/sound/qcom,q6apm-lpass-dais.yaml#
> +    unevaluatedProperties: false
> +    description: Qualcomm DSP audio ports
> +
>     dais:
>       type: object
>       $ref: /schemas/sound/qcom,q6apm-dai.yaml#
>       unevaluatedProperties: false
>       description: Qualcomm DSP audio ports
>   
> +  '#sound-dai-cells':
> +    const: 0
> +
>   required:
>     - compatible
> +  - bedais
>     - dais
>   
>   unevaluatedProperties: false
> @@ -41,11 +51,17 @@ examples:
>           service@1 {
>               reg = <GPR_APM_MODULE_IID>;
>               compatible = "qcom,q6apm";
> +            #sound-dai-cells = <0>;
>               qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>   
>               dais {
>                   compatible = "qcom,q6apm-dais";
>                   iommus = <&apps_smmu 0x1801 0x0>;
>               };
> +
> +            bedais {
> +                compatible = "qcom,q6apm-lpass-dais";
> +                #sound-dai-cells = <1>;
> +            };
>           };
>       };

  reply	other threads:[~2022-11-14 11:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 11:35 [PATCH 00/10] ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450 Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 01/10] ASoC: dt-bindings: qcom,apr: Add GLINK channel name " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 02/10] ASoC: dt-bindings: qcom,apr: Split services to shared schema Krzysztof Kozlowski
2022-11-11 13:30   ` Rob Herring
2022-11-11 14:21     ` Krzysztof Kozlowski
2022-11-11 16:35   ` Srinivas Kandagatla
2022-11-14  7:45     ` Krzysztof Kozlowski
2022-11-15 10:22   ` Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 03/10] ASoC: dt-bindings: qcom,q6afe: Split to separate schema Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 04/10] ASoC: dt-bindings: qcom,q6apm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 05/10] ASoC: dt-bindings: qcom,q6adm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 06/10] ASoC: dt-bindings: qcom,q6asm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 07/10] ASoC: dt-bindings: qcom,q6prm: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 08/10] ASoC: dt-bindings: qcom,q6core: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 09/10] ASoC: dt-bindings: qcom,q6apm-lpass-dais: " Krzysztof Kozlowski
2022-11-11 11:35 ` [PATCH 10/10] ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node Krzysztof Kozlowski
2022-11-14 11:40   ` Srinivas Kandagatla [this message]
2022-11-14 12:08     ` Krzysztof Kozlowski
2022-11-11 12:10 ` [PATCH 00/10] ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450 Krzysztof Kozlowski
2022-11-11 16:15 ` Srinivas Kandagatla
2022-11-14  7:48   ` Krzysztof Kozlowski
2022-11-14 11:50     ` Srinivas Kandagatla
2022-11-14 12:09       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf66aa8f-4bf7-d9c0-e2ae-b6fced7e4948@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=bgoswami@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plai@qti.qualcomm.com \
    --cc=robh+dt@kernel.org \
    --cc=srivasam@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).