From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0903CC433FE for ; Mon, 14 Nov 2022 11:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236215AbiKNLlF (ORCPT ); Mon, 14 Nov 2022 06:41:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236337AbiKNLky (ORCPT ); Mon, 14 Nov 2022 06:40:54 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 912281A3AA for ; Mon, 14 Nov 2022 03:40:53 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id bs21so17686496wrb.4 for ; Mon, 14 Nov 2022 03:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HD1FJFbm4qiZjnfWZv0nv02BdZLPwZIxvvXLBcQxcA0=; b=QmW79Pi/kv1ijN/1fegsnzJHDHy3kLhMK5xERnfBLW2M0pZRGeAj1t27J/Oitxj/7g SG4XgfHWHcYusKaWxzs8mbsyMyfKVyFe0rim95+XX5d9lj4SBjwRUG4vspeAn/Vw96bY /5oy1I22lKS0ag4QNAyM6CfxxyYrOAG2JgyF4f1uepWaW5gL1lw1V/46Zziglr4Iv4LT gn4UPpVWv5WeJXmDfwWgOJ8KQTBmhnOBjwc88b8/YvtKuy4cnImwecsto9d9Haovdvrq 1WCMRLaGdNwVNcWxjeSGjndiK2bcshHuqv+WzxrzMLB4j6c1/1a3oqB4eiSDGjpJ050x IPtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HD1FJFbm4qiZjnfWZv0nv02BdZLPwZIxvvXLBcQxcA0=; b=C57OJMnsKRoi8wNRPc4Su+snQrM9c3EdOwDYyImhy5Z4GCubYW/byqxsCzqVqa+u4U V10TDUsWBQE2gppfDPms5AOyhZfziNDI8DDUIySg68DJts4t37gK+3SNNrkvr3LJqJ+w kFb3H+/IZ4WOOLD+eTez7q/JGmq1FkftSZI0I4MYEjCUo5pZLEbppCX+fQdeR714Tkop GANXCUnNXCcgknqMe88mffFajJWxGUAZrYJjd+W3HMD1TSmfvVR1swmiXzPfWnSvOo3s CM8yvY6sFSG2y5rL3IZUIxAGCHwAI0PlIrh0IeKJk8xcaU8Wp/loUprBo9sXe7AG3SR+ VunA== X-Gm-Message-State: ANoB5plbt4x+Z8HSple/YIvd6GwIfR+RCbzHMSqTssc5nsYc7mRHbegc EFqCGneUFb4sZK3sveWVEq4rN5dVv8ZgMQ== X-Google-Smtp-Source: AA0mqf7w6FsqMHPLvaGe1VAW4QNqBhCJzebNX55AWaprvEM0JnmljxZjn1eeQRgPy1WX1yhoGrB/fQ== X-Received: by 2002:adf:cd91:0:b0:241:695c:4eec with SMTP id q17-20020adfcd91000000b00241695c4eecmr7437995wrj.174.1668426052149; Mon, 14 Nov 2022 03:40:52 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id z15-20020a056000110f00b0022a3a887ceasm9327509wrw.49.2022.11.14.03.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 03:40:51 -0800 (PST) Message-ID: Date: Mon, 14 Nov 2022 11:40:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 10/10] ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node Content-Language: en-US To: Krzysztof Kozlowski , Banajit Goswami , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Lai , Srinivasa Rao Mandadapu References: <20221111113547.100442-1-krzysztof.kozlowski@linaro.org> <20221111113547.100442-11-krzysztof.kozlowski@linaro.org> From: Srinivas Kandagatla In-Reply-To: <20221111113547.100442-11-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/11/2022 11:35, Krzysztof Kozlowski wrote: > On SM8450 and SC8280XP, the Q6APM is a bit different: This is not specific to SM8450 or SC8280XP its part of AudioReach apm which deals with both backends and pcm. In old Elite architecture we had a dedicated service AFE to deal with Backend dais, now APM does all. Thanks, Srini > 1. It is used as a platform DAI link, so it needs #sound-dai-cells. > 2. It has two DAI children, so add new "bedais" node. > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/sound/qcom,q6apm.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > index 7acb832aa557..cd434e8268ce 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > @@ -18,14 +18,24 @@ properties: > enum: > - qcom,q6apm > > + bedais: > + type: object > + $ref: /schemas/sound/qcom,q6apm-lpass-dais.yaml# > + unevaluatedProperties: false > + description: Qualcomm DSP audio ports > + > dais: > type: object > $ref: /schemas/sound/qcom,q6apm-dai.yaml# > unevaluatedProperties: false > description: Qualcomm DSP audio ports > > + '#sound-dai-cells': > + const: 0 > + > required: > - compatible > + - bedais > - dais > > unevaluatedProperties: false > @@ -41,11 +51,17 @@ examples: > service@1 { > reg = ; > compatible = "qcom,q6apm"; > + #sound-dai-cells = <0>; > qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > > dais { > compatible = "qcom,q6apm-dais"; > iommus = <&apps_smmu 0x1801 0x0>; > }; > + > + bedais { > + compatible = "qcom,q6apm-lpass-dais"; > + #sound-dai-cells = <1>; > + }; > }; > };