From: Caleb Connolly <caleb.connolly@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, sumit.semwal@linaro.org,
amit.pundir@linaro.org, john.stultz@linaro.org
Subject: Re: [PATCH v4 1/8] mfd: qcom-spmi-pmic: expose the PMIC revid information to clients
Date: Mon, 14 Feb 2022 18:40:19 +0000 [thread overview]
Message-ID: <cf69e1b7-28cb-eaf1-1eaf-c4a7fc7e4ddf@linaro.org> (raw)
In-Reply-To: <20220213165550.13051272@jic23-huawei>
Hi,
I've found some pretty bad bugs with this patch (specifically qcom_pmic_get()),
please do not merge, they'll be fixed in the next revision.
On 13/02/2022 16:55, Jonathan Cameron wrote:
> On Fri, 11 Feb 2022 21:19:52 +0000
> Caleb Connolly <caleb.connolly@linaro.org> wrote:
>
>> Some PMIC functions such as the RRADC need to be aware of the PMIC
>> chip revision information to implement errata or otherwise adjust
>> behaviour, export the PMIC information to enable this.
>>
>> This is specifically required to enable the RRADC to adjust
>> coefficients based on which chip fab the PMIC was produced in,
>> this can vary per unique device and therefore has to be read at
>> runtime.
>>
>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> Hi Caleb,
>
> Looks fine to me, though obviously needs a tag from Lee as MFD maintainer.
> I'm assuming I'll take this series through IIO once everyone is happy
> with the changes and hence it'll pick up my SoB, so I'm not giving
> RBs or similar in the meantime.
>
> Thanks,
>
> Jonathan
--
Kind Regards,
Caleb (they/them)
next prev parent reply other threads:[~2022-02-14 18:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 21:19 [PATCH v4 0/8] iio: adc: introduce Qualcomm SPMI Round Robin ADC Caleb Connolly
2022-02-11 21:19 ` [PATCH v4 1/8] mfd: qcom-spmi-pmic: expose the PMIC revid information to clients Caleb Connolly
2022-02-13 16:55 ` Jonathan Cameron
2022-02-14 18:40 ` Caleb Connolly [this message]
2022-02-11 21:19 ` [PATCH v4 2/8] mfd: qcom-spmi-pmic: read fab id on supported PMICs Caleb Connolly
2022-02-11 21:19 ` [PATCH v4 3/8] dt-bindings: iio: adc: document qcom-spmi-rradc Caleb Connolly
2022-02-11 21:19 ` [PATCH v4 4/8] iio: adc: qcom-spmi-rradc: introduce round robin adc Caleb Connolly
2022-02-13 17:49 ` Jonathan Cameron
2022-02-11 21:19 ` [PATCH v4 5/8] arm64: dts: qcom: pmi8998: add rradc node Caleb Connolly
2022-02-11 21:19 ` [PATCH v4 6/8] arm64: dts: qcom: sdm845-oneplus: enable rradc Caleb Connolly
2022-02-11 21:19 ` [PATCH v4 7/8] arm64: dts: qcom: sdm845-db845c: " Caleb Connolly
2022-02-11 21:19 ` [PATCH v4 8/8] arm64: dts: qcom: sdm845-xiaomi-beryllium: " Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf69e1b7-28cb-eaf1-1eaf-c4a7fc7e4ddf@linaro.org \
--to=caleb.connolly@linaro.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=john.stultz@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).