From: Krzysztof Kozlowski <krzk@kernel.org>
To: Elaine Zhang <zhangqing@rock-chips.com>,
mkl@pengutronix.de, kernel@pengutronix.de,
mailhol.vincent@wanadoo.fr, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, heiko@sntech.de, cl@rock-chips.com,
kever.yang@rock-chips.com
Cc: linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: can: rockchip_canfd: add rk3576 CAN-FD controller
Date: Fri, 23 May 2025 10:05:44 +0200 [thread overview]
Message-ID: <cf6d6088-dacf-42d9-b8dc-92b6b17282a9@kernel.org> (raw)
In-Reply-To: <20250523075422.4010083-2-zhangqing@rock-chips.com>
On 23/05/2025 09:54, Elaine Zhang wrote:
> - items:
> - const: rockchip,rk3568v3-canfd
> - const: rockchip,rk3568v2-canfd
> @@ -43,6 +44,13 @@ properties:
> - const: core
> - const: apb
>
> + dmas:
> + maxItems: 1
> +
> + dma-names:
> + items:
> + - const: rx
All devices support DMA? If so, explain this in commit msg. If not, this
needs constraints per variant. See example-schema and other bindings.
> +
> required:
> - compatible
> - reg
> @@ -72,3 +80,19 @@ examples:
> reset-names = "core", "apb";
> };
> };
> +
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + can@2ac00000 {
> + compatible = "rockchip,rk3576-canfd";
That's the same example. Drop.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-23 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 7:54 [PATCH v5 0/4] rockchip: add can for RK3576 Soc Elaine Zhang
2025-05-23 7:54 ` [PATCH v5 1/4] dt-bindings: can: rockchip_canfd: add rk3576 CAN-FD controller Elaine Zhang
2025-05-23 7:57 ` Marc Kleine-Budde
2025-05-23 8:05 ` Krzysztof Kozlowski [this message]
2025-05-23 7:54 ` [PATCH v5 2/4] net: can: rockchip: Refactor the rkcanfd_devtype_data structure Elaine Zhang
2025-05-24 10:59 ` kernel test robot
2025-05-23 7:54 ` [PATCH v5 3/4] net: can: rockchip: add can for RK3576 Soc Elaine Zhang
2025-05-23 8:15 ` Marc Kleine-Budde
2025-05-24 13:55 ` kernel test robot
2025-05-23 7:54 ` [PATCH v5 4/4] net: can: rockchip: support dma for rk3576 rx Elaine Zhang
2025-05-23 9:10 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf6d6088-dacf-42d9-b8dc-92b6b17282a9@kernel.org \
--to=krzk@kernel.org \
--cc=cl@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox