Re: [PATCH 0/5] AXP803 regulator support for Pine64 and SoPine

[icenowy-h8G6r0blFSE@public.gmane.org]

在 2017-07-20 12:11，Chen-Yu Tsai 写道：
> On Thu, Jul 20, 2017 at 12:10 AM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> 
> wrote:
>> The Pine64 and SoPine w/ baseboard boards have an AXP803 PMIC, and the
>> regulators of the PMIC are used.
>> 
>> This patchset adds the regulators to the device tree of these two 
>> boards.
>> 
>> The first patch introduces proper AXP803 regulators to Pine64 DT, and 
>> the
>> second patch removed dummy regulators in the Pine64 DT.
>> 
>> The third patch enables AXP803 PMIC for SoPine.
>> 
>> The fourth patch and fifth patch are like the first and the second, 
>> but
>> they're for SoPine w/ baseboard.
>> 
>> Icenowy Zheng (5):
>>   arm64: allwinner: a64: enable AXP803 regulators for Pine64
>>   arm: allwinner: a64: drop the dummy vcc3v3 regulator in Pine64 DT
>>   arm64: allwinner: a64: add AXP803 PMIC to SoPine DTSI
>>   arm64: allwinner: a64: add AXP803 regulators support for SoPine
>>   arm: allwinner: a64: drop vcc3v3 and vcc1v8 dummy regulators for
>>     SoPine
> 
> The related drivers are all merged. There's really no reason to split
> these into separate patches. Patch 1 & 2 can be squashed together.
> Patch 3, 4 & 5 can be squashed together.
> 
> The patches themselves look good, though I have not checked them
> against the schematics.

In fact I prefer to split out the patch that removes the dummy
regulators, but if you think squashing them is better, I will
do it.

Squash 3 into 4 is of course okay.

> 
> ChenYu
> 
>> 
>>  .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 105 
>> +++++++++++++++++++--
>>  .../dts/allwinner/sun50i-a64-sopine-baseboard.dts  |  34 +++++--
>>  .../boot/dts/allwinner/sun50i-a64-sopine.dtsi      |  91 
>> ++++++++++++++++--
>>  3 files changed, 203 insertions(+), 27 deletions(-)
>> 
>> --
>> 2.13.0
>> 
>> --
>> You received this message because you are subscribed to the Google 
>> Groups "linux-sunxi" group.
>> To unsubscribe from this group and stop receiving emails from it, send 
>> an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
>> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.