From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C6FC6FD1F for ; Wed, 22 Mar 2023 21:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbjCVV7n (ORCPT ); Wed, 22 Mar 2023 17:59:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229673AbjCVV7m (ORCPT ); Wed, 22 Mar 2023 17:59:42 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4F4FEC53 for ; Wed, 22 Mar 2023 14:59:40 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id eh3so78829222edb.11 for ; Wed, 22 Mar 2023 14:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679522379; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EvQSRIdRv5c+y5ikJcDqBTw6V/+X5LVUwyAPQo8flXU=; b=TViol1opIBVYgiZzibv+QeuWJpS7XEsNAEeA6AthKKfjIW6QQt1lv7Pma1f4QXsdXF 5TyN88oQA+Mt6kX0tFUGAPxoaZuKYqkuvrbV2o1/LuFhm674nnXJDvq9777FcmeJbGvf lSdm9nYRMJZMN6q937AJcdGUiA366TsKqw7cinTjm82VqX0vh56Ci0TE2DzJB3QScdsl QVcwzaGhQjZHGhac7qLwdySCdH1J3bTwBe36sD4rVMEfFEeh7DkYpTeaGZ6ANkD9eCiK /B8X88eIw08Ot67aTYDqZltTvv8zEHEBIUlY/D8w+lsx6AoYztFyrZWdB88PGj64fb3u q6rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679522379; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EvQSRIdRv5c+y5ikJcDqBTw6V/+X5LVUwyAPQo8flXU=; b=1cyGn4kEtI60bFr/fI/SDE1mjK60D31tf3IoaT7XQC5DOzr2rRXMRyAmYjo0N1N7nR AscwbJwQR9e6CyxqKP7NaDehfzFXabh5C3VRHfJtgDpmtgDyom0jcADzAKomHuwqG+dV 4xkVT9gDIIO0k/wFPfM7lqJT6WaZX5xLiLDkjYvFeABy21mjGuOUZ38fliWW/U8l4BiV h8aP/Lq8wV0rSuWaSSUCon/SouAFjhM7eJ5FQzJMC/OYQ3etjCEwnniAxEjw3Gl6L+FH bXRjLMrF4NHG6b/GxSUf0A6D4hQOQQrGxg1LE8k2G+88W8oA9CfXwz9slyhR7NGht2Lg jjSg== X-Gm-Message-State: AO0yUKWvFSDx5QHMD6TBLOX3xz43GeNUkrEt0tnLGZEkfA8VlBmhHEtN XgXxvYIWhDBj6aNo54xb0q/O+A== X-Google-Smtp-Source: AK7set88TbcnM/063JVFqc2VabiL6S//jkxBLWUWhSQKY5G4J0puIdYR1qJXou2K7kAYiGwtL5cXBQ== X-Received: by 2002:a17:906:e97:b0:8af:2a97:91d4 with SMTP id p23-20020a1709060e9700b008af2a9791d4mr8279561ejf.14.1679522379374; Wed, 22 Mar 2023 14:59:39 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:626d:5729:6e71:4c22? ([2a02:810d:15c0:828:626d:5729:6e71:4c22]) by smtp.gmail.com with ESMTPSA id y12-20020a17090668cc00b008d044ede804sm5703652ejr.163.2023.03.22.14.59.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 14:59:39 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 22:59:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 4/6] dt-bindings: sound: Add support for the Lantiq PEF2256 codec Content-Language: en-US To: Herve Codina , Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni References: <20230322134654.219957-1-herve.codina@bootlin.com> <20230322134654.219957-5-herve.codina@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20230322134654.219957-5-herve.codina@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/03/2023 14:46, Herve Codina wrote: > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required interfacing between an analog E1/T1/J1 line and the > digital PCM system highway/H.100 bus. > > The codec support allows to use some of the PCM system highway > time-slots as audio channels to transport audio data over the E1/T1/J1 > lines. > > Signed-off-by: Herve Codina > --- > .../bindings/sound/lantiq,pef2256-codec.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml > > diff --git a/Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml b/Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml > new file mode 100644 > index 000000000000..da35b70cda99 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/lantiq,pef2256-codec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lantiq PEF2256 codec > + > +maintainers: > + - Herve Codina > + > +description: | > + Codec support for PEF2256. > + > + The Lantiq PEF2256, also known as Infineon PEF2256 or FALC56, is a framer and > + line interface component designed to fulfill all required interfacing between > + an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus. > + > + The codec support allows to use some of the PCM system highway time-slots as > + audio channels to transport audio data over the E1/T1/J1 lines. > + > + The time-slots used by the codec must be set and so, the properties > + 'dai-tdm-slot-num', 'dai-tdm-slot-width', 'dai-tdm-slot-tx-mask' and > + 'dai-tdm-slot-rx-mask' must be present in the ALSA sound card node for > + sub-nodes that involve the codec. The codec uses 8bit time-slots. > + 'dai-tdm-tdm-slot-with' must be set to 8. > + The tx and rx masks define the PEF2256 time-slots assigned to the codec. > + > + The PEF2256 codec node should be a child of a PEF2256 node. > + Refer to the bindings described in > + Documentation/devicetree/bindings/mfd/lantiq,pef2256.yaml > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + const: lantiq,pef2256-codec > + > + '#sound-dai-cells': > + const: 0 You do not have here any resources, so the entire binding can be dropped and merged into the parent. Best regards, Krzysztof