Re: Re: [PATCH v8 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes

[Macpaul Lin <macpaul.lin@mediatek.com>]

On 1/26/22 3:28 PM, Macpaul Lin wrote:
> On 1/25/22 4:32 PM, Macpaul Lin wrote:
>>
>> On 6/16/21 10:07 PM, Hsin-hsiung Wang wrote:
>>> Hi,
>>>
>>> On Fri, 2021-06-11 at 16:09 +0200, Matthias Brugger wrote:
>>>>
>>>> On 26/05/2021 08:52, Hsin-Hsiung Wang wrote:
>>>>> From: Wen Su <wen.su@mediatek.com>
>>>>>
>>>>> add PMIC MT6359 related nodes which is for MT6779 platform
>>>>>
>>>>> Signed-off-by: Wen Su <wen.su@mediatek.com>
>>>>> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
>>>>> ---
>>>>> changes since v7:
>>>>> - no change.
>>>>> ---
>>>>>   arch/arm64/boot/dts/mediatek/mt6359.dtsi    | 298 
>>>>> ++++++++++++++++++++++++++++
>>>>>   arch/arm64/boot/dts/mediatek/mt8192-evb.dts |   1 +
>>>>>   2 files changed, 299 insertions(+)
>>>>>   create mode 100644 arch/arm64/boot/dts/mediatek/mt6359.dtsi
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi 
>>>>> b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
>>>>> new file mode 100644
>>>>> index 0000000..18c0d53
>>>>> --- /dev/null
>>>>> +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
>>>>> @@ -0,0 +1,298 @@
>>>>> +// SPDX-License-Identifier: GPL-2.0
>>>>
>>>> Any specific reason for not setting it "SPDX-License-Identifier: 
>>>> (GPL-2.0+ OR
>>>> MIT)" ?
>>>>
>>>> Other then that, looks good.
>>>>
>>>> Matthias
>>>>
>>>
>>> Thanks for the review, there is no special reason for the writing.
>>> I will update it in the next patch.
>>>
>> [The content of the patch has been deleted...]
>>
>> According to the reviewing note of PMIC wrap, URL:
>> https://patchwork.kernel.org/project/linux-mediatek/cover/1615563286-22126-1-git-send-email-hsin-hsiung.wang@mediatek.com 
>>
>>
>> Dear Hui and Sen,
>> could you help update and upstream the mt6359.dtsi and mt8192-evb.dts 
>> with the necessary fixes?
>>
>> Thanks!
>> Macpaul Lin
> 
> Dear Hui,
> 
> I've found patch v8 will cause build fail because pwrap node hasn't been 
> merged according to [1] and [2] (mt8192). However, the pwrap node for 
> mt8195 is already in [3] mt8195.dtsi. The mt8195 boards using mt6359 
> will need mt6359.dtsi for enabling more peripherals.
> 
> I think to split the mt8192 part into the other patch in next version 
> could reduce the dependencies between mt6359.dtsi and mt8192.dtsi at 
> this stage. Hence we don't need to wait pwrap node be merged in 
> mt8192.dtsi.
> 
> [1] 
> https://lore.kernel.org/all/1615563286-22126-6-git-send-email-hsin-hsiung.wang@mediatek.com/ 
> 
> [2] 
> https://lore.kernel.org/all/e33053cf-f337-d7f6-fbf6-93d385f7e683@gmail.com/
> [3] 
> https://lore.kernel.org/all/20220112114724.1953-4-tinghan.shen@mediatek.com/ 
> 
> 
> After that, you can have my Reviewed-by tag in next version.
> 
> Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
> 
> Thanks :)
> Macpaul Lin

Just a remind:
The updated version of this patch [4] "arm64: dts: mt6359: add PMIC 
MT6359 related nodes" has been update and resend as a new patchset [5].

The new patchset [5] passed built test with the v9 and v10's dependent 
patch [6].
Where the previous updated note of build test result is here [7].

[4] 
https://lore.kernel.org/lkml/1622011927-359-9-git-send-email-hsin-hsiung.wang@mediatek.com/
[5] https://www.spinics.net/lists/devicetree/msg472119.html
[6] 
https://lore.kernel.org/all/20220130023209.16275-1-tinghan.shen@mediatek.com/
[7] https://www.spinics.net/lists/devicetree/msg472149.html

Thanks
Macpaul Lin