From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Yinbo Zhu <zhuyinbo@loongson.cn>, Arnd Bergmann <arnd@arndb.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn, soc@kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev
Subject: Re: [PATCH v2 4/5] dt-bindings: soc: loongson,ls2k-pmc: Allow syscon-reboot/syscon-poweroff as child
Date: Fri, 1 Sep 2023 11:06:51 +0200 [thread overview]
Message-ID: <cfa55813-946e-7aad-b7a4-54450a1ea5d5@linaro.org> (raw)
In-Reply-To: <38e811816c37a2d52374fa04864654ff1e9b4dc8.1693474728.git.zhoubinbin@loongson.cn>
On 31/08/2023 13:43, Binbin Zhou wrote:
> required:
> - compatible
> - reg
> @@ -54,4 +66,18 @@ examples:
> interrupt-parent = <&liointc1>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> loongson,suspend-address = <0x0 0x1c000500>;
> +
> + syscon-reboot {
> + compatible = "syscon-reboot";
> + offset = <0x30>;
> + mask = <0x1>;
> + };
> +
> + syscon-poweroff {
> + compatible = "syscon-poweroff";
> + regmap = <&pmc>;
???
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-01 9:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 11:43 [PATCH v2 0/5] soc: loongson: Fix some issues about loongson_pm2 Binbin Zhou
2023-08-31 11:43 ` [PATCH v2 1/5] soc: loongson: loongson_pm2: Add dependency for INPUT Binbin Zhou
2023-08-31 11:43 ` [PATCH v2 2/5] dt-bindings: soc: loongson,ls2k-pmc: Use fallbacks for ls2k-pmc compatible Binbin Zhou
2023-08-31 11:43 ` [PATCH v2 3/5] soc: loongson: loongson_pm2: Drop useless of_device_id compatible Binbin Zhou
[not found] ` <20230831-ambition-refusing-08e63b345573@spud>
2023-09-01 3:05 ` Binbin Zhou
2023-09-01 6:32 ` Conor Dooley
2023-08-31 11:43 ` [PATCH v2 4/5] dt-bindings: soc: loongson,ls2k-pmc: Allow syscon-reboot/syscon-poweroff as child Binbin Zhou
2023-09-01 9:06 ` Krzysztof Kozlowski [this message]
2023-09-01 9:27 ` Binbin Zhou
2023-09-01 11:44 ` Krzysztof Kozlowski
2023-08-31 11:43 ` [PATCH v2 5/5] soc: loongson: loongson_pm2: Populate children syscon nodes Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfa55813-946e-7aad-b7a4-54450a1ea5d5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).