From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5690CA0FE1 for ; Fri, 1 Sep 2023 09:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236960AbjIAJG6 (ORCPT ); Fri, 1 Sep 2023 05:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232335AbjIAJG5 (ORCPT ); Fri, 1 Sep 2023 05:06:57 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E984A10D2 for ; Fri, 1 Sep 2023 02:06:54 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-99c1c66876aso207627366b.2 for ; Fri, 01 Sep 2023 02:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693559213; x=1694164013; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CL2wZFAQ9DQMYKYYGQQIGah4zjC0ig67LMgG+Wt4f1Y=; b=d3G7fIe8UBMa7gt6/G7qj29NWsPBatVgzGJzXHP5l++Wu7/0gRZ6rlj+4bu1BjP1Gy 2fsbLHcMS4FApmD3M+FlTyxu8yaT2tGgMeBkNB7Y6qWeu3JBxO+gdkU6f4IlJnRhsNkn MKGFthxQR6deD59S+crpEVayayBlLW6yhYnGDGn/kQytn2MAG4HsApgD7T/l5929dpRf 9qYs/CHgS/2XPzcQ1oePIOvFNb359qW0DgA41wvFLUtjD23WPC/1WpYd8Aahvu3m1TNZ dcxp83oal8lV67e9uf0WHHYDNqYoOQ/NeaO7hq49ODb6XdquByGEXvQN7FypXLeOSnID t1Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693559213; x=1694164013; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CL2wZFAQ9DQMYKYYGQQIGah4zjC0ig67LMgG+Wt4f1Y=; b=P3G8TK+7wYcL4JbSSqwj4D3Fz/2hqEyZNVFBCmSGpWWh9pS81HZqptzH7C5o8MKQhR BI8Y36aCyVR/jJPiNKgUINlVbCmZ4k1S0MCCkCdXrPdjTFcgDBf0sfhLvQ8lUKOgBf4C u80STigeNh9t1AAnt8WT/jLY7UZzsLg/sYPtzPu3N9jEVlnCEBZzASQ3PXmRkx0Tn5rV zq3fP6Fy4PUUVMr3vMSg9gRi+lSK3fLytQ44WqTKY8ZH9jjaE4LJCk1hJFJ6TXab7yRf rnEPdgu4XB5xnn5Vov8LPEsvbiA0TZW1t78O3JFVd+ZE7LZ1Og24Kpjsk5H+ZPX5EP2W sMpw== X-Gm-Message-State: AOJu0Yz/ntTls0JwTjALqe0mLZy/Kwqv9+E3PxaizgoWVZ9XCvy0Gd2A 8LrGDZ94sgB3gMS2CkAvel7L7g== X-Google-Smtp-Source: AGHT+IFgycuMFi2b9nbCWqWNuNSEcE07Zi45QXIvtjzYup3K8uPK4QvdgSYexfoBzJlc6i5xrD3o3g== X-Received: by 2002:a17:907:75fa:b0:9a5:7ade:b5e8 with SMTP id jz26-20020a17090775fa00b009a57adeb5e8mr1170613ejc.10.1693559213457; Fri, 01 Sep 2023 02:06:53 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id e7-20020a170906248700b009920a690cd9sm1727779ejb.59.2023.09.01.02.06.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Sep 2023 02:06:52 -0700 (PDT) Message-ID: Date: Fri, 1 Sep 2023 11:06:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 4/5] dt-bindings: soc: loongson,ls2k-pmc: Allow syscon-reboot/syscon-poweroff as child To: Binbin Zhou , Binbin Zhou , Huacai Chen , Yinbo Zhu , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Huacai Chen , loongson-kernel@lists.loongnix.cn, soc@kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Xuerui Wang , loongarch@lists.linux.dev References: <38e811816c37a2d52374fa04864654ff1e9b4dc8.1693474728.git.zhoubinbin@loongson.cn> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <38e811816c37a2d52374fa04864654ff1e9b4dc8.1693474728.git.zhoubinbin@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/08/2023 13:43, Binbin Zhou wrote: > required: > - compatible > - reg > @@ -54,4 +66,18 @@ examples: > interrupt-parent = <&liointc1>; > interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > loongson,suspend-address = <0x0 0x1c000500>; > + > + syscon-reboot { > + compatible = "syscon-reboot"; > + offset = <0x30>; > + mask = <0x1>; > + }; > + > + syscon-poweroff { > + compatible = "syscon-poweroff"; > + regmap = <&pmc>; ??? This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof