From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, amitk@kernel.org,
thara.gopinath@gmail.com, rafael@kernel.org,
daniel.lezcano@linaro.org, rui.zhang@intel.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Praveenkumar I <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH v3 2/4] dt-bindings: thermal: tsens: Add ipq9574 compatible
Date: Wed, 17 May 2023 09:00:49 +0200 [thread overview]
Message-ID: <cfba78d7-e563-4544-00f3-0991b91eb1f3@linaro.org> (raw)
In-Reply-To: <20230517055726.GA3165@varda-linux.qualcomm.com>
On 17/05/2023 07:57, Varadarajan Narayanan wrote:
> Part-1 is adding the 'const' entries at the beginning i.e.
>
> + - const: qcom,tsens-v0_1
> + - const: qcom,tsens-v1
> + - const: qcom,tsens-v2
> + - const: qcom,ipq8074-tsens
>
> Part-2 is changing from one valid syntax to another i.e.
>
> + items:
> + - enum:
> + - qcom,ipq9574-tsens
> + - const: qcom,ipq8074-tsens
>
> Without both of the above changes, either or both of dtbs_check
> & dt_binding_check fails. So, it is not possible to just add the
> "valid hunk" (part-2) alone.
Of course it is. All schema files work like that...
>
> If having both part-1 and part-2 in the same patch is not
> acceptable, shall I split them into two patches? Please let me know.
No, hunk one is not justified.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-17 7:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 10:13 [PATCH v3 0/4] Enable IPQ9574 TSENS support Varadarajan Narayanan
2023-05-15 10:13 ` [PATCH v3 1/4] dt-bindings: thermal: tsens: Fix "make dtbs_check" error Varadarajan Narayanan
2023-05-15 16:09 ` Krzysztof Kozlowski
2023-05-16 1:07 ` Konrad Dybcio
2023-05-15 10:13 ` [PATCH v3 2/4] dt-bindings: thermal: tsens: Add ipq9574 compatible Varadarajan Narayanan
2023-05-15 16:10 ` Krzysztof Kozlowski
2023-05-16 12:04 ` Varadarajan Narayanan
2023-05-16 13:06 ` Krzysztof Kozlowski
2023-05-17 5:57 ` Varadarajan Narayanan
2023-05-17 7:00 ` Krzysztof Kozlowski [this message]
2023-05-18 5:40 ` Varadarajan Narayanan
2023-05-18 7:09 ` Krzysztof Kozlowski
2023-05-18 9:05 ` Varadarajan Narayanan
2023-05-18 11:06 ` Krzysztof Kozlowski
2023-05-23 10:19 ` Varadarajan Narayanan
2023-05-23 16:44 ` Conor Dooley
2023-05-24 6:43 ` Varadarajan Narayanan
2023-05-30 11:25 ` Krzysztof Kozlowski
2023-05-15 10:13 ` [PATCH v3 3/4] arm64: dts: qcom: ipq9574: add tsens node Varadarajan Narayanan
2023-05-15 10:13 ` [PATCH v3 4/4] arm64: dts: qcom: ipq9574: add thermal zone nodes Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfba78d7-e563-4544-00f3-0991b91eb1f3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).