From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43870C433EF for ; Mon, 4 Jul 2022 09:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233253AbiGDJCc (ORCPT ); Mon, 4 Jul 2022 05:02:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233480AbiGDJC1 (ORCPT ); Mon, 4 Jul 2022 05:02:27 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1828262A for ; Mon, 4 Jul 2022 02:02:26 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id e12so14645196lfr.6 for ; Mon, 04 Jul 2022 02:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=TE+ycpZatBFbweoIjNfWEpsJggku8ipnnIiNJ3if1YA=; b=pXrsn6yXNU3xlSXyfD47CblSCEmnCsNJ/CZhN64v/dLBD9Q03ZnJ23dUskMPrPuVNQ ZSNa3DD5JbnSbAUOiyaOKYsbvOF7v5Vbo9nuYjBnb5846ZLeHJ9WKaycq9YSMYBoNemH 5bEbTl21fqVuCwMsPjbJAgrXmTl53SUiutMpFubRZhuQKYo8zzOPnh6aeBAHNJESfZY2 JcB1Zi6BNgLrrrlsZJxgmS/hELT5HNpeTirCjUSxYpspBzE7CE3mY/YR189B/3dN6V7C GRuUdf444MGa41t/HP3GZqzBQ7JE/J2JJ5MHo4B7JdFkSyvHfqqjEgSOf0YUVO6G7B/k dlUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TE+ycpZatBFbweoIjNfWEpsJggku8ipnnIiNJ3if1YA=; b=ktHbjNzNWI9ZRB0ICuoUYKjiedZpOO08ito7wLPevt6AGinjR/F3cl0wK9pu++ZXQx DFyhKUgMf1GPFIpF+bX2untjLtpxY9w5B18bl6ze7nEFBDob+VlNp56jeK4NSYIti7b0 7snX0IGZXye4KrZFgPP517y1x/pxW9ux2NpyUP0u56Y+U2PG66yhctBbm6K7hGZeItVi OaEbqIlPyO+RBemze1bxaclVsr7jhy3YgUS6TTT2TSO45KJwXBJ5PO885o8sNHevm8kT Qcf1NxgdcPElXi3opN+0/bd41niRoX+G12yNj1uy+8vbaZEEVIoKX/z0QNspqnrOREnK NLVg== X-Gm-Message-State: AJIora8kOgmVXE98y39OrBztfIXEmE7cxBlcl8s1c7W5d5QCHBKxFPm3 dyFS8Djl9G8HhOn9SWqVwg5Iog== X-Google-Smtp-Source: AGRyM1vMeTX1VnBB4A1NJl15aVHHrYdt5/PbK+w+fNs8BCHMkMOspdzIOUNOpcDj09zzGRKjzy8xrw== X-Received: by 2002:a05:6512:7b:b0:47f:6568:a143 with SMTP id i27-20020a056512007b00b0047f6568a143mr18809321lfo.485.1656925344932; Mon, 04 Jul 2022 02:02:24 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id u22-20020a197916000000b0047f86b503absm5044142lfc.16.2022.07.04.02.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 02:02:24 -0700 (PDT) Message-ID: Date: Mon, 4 Jul 2022 11:02:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] [V1,1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family Content-Language: en-US To: Jimmy Chen , LKML , Andy Gross Cc: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Alan Huang , Rob Herring , Douglas Anderson , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/07/2022 09:09, Jimmy Chen wrote: > This adds yaml file for new a LTE skus for villager device. > > Signed-off-by: Jimmy Chen > --- > > Documentation/devicetree/bindings/arm/qcom.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 4dd18fbf20b68..a136b1389c2ac 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -529,11 +529,26 @@ properties: > - const: google,herobrine > - const: qcom,sc7280 > > + - description: Google Villager (rev0) > + items: > + - const: google,villager-rev0 > + - const: qcom,sc7280 > + > - description: Google Villager (newest rev) > items: > - const: google,villager > - const: qcom,sc7280 > > + - description: Google Villager with LTE (rev0) > + items: > + - const: google,villager-rev0-sku0 > + - const: qcom,sc7280 > + > + - description: Google Villager with LTE (newest rev) > + items: > + - const: google,villager-sku0 > + - const: qcom,sc7280 > + All these should be one entry - one enum. If you really need some descriptive text, add a comment. Best regards, Krzysztof