From: Krzysztof Kozlowski <krzk@kernel.org>
To: George Stark <gnstark@salutedevices.com>,
ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, hkallweit1@gmail.com
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@salutedevices.com,
Dmitry Rokosov <ddrokosov@salutedevices.com>
Subject: Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm
Date: Mon, 1 Jul 2024 15:25:06 +0200 [thread overview]
Message-ID: <cfcebb37-0518-4dac-bd89-d845bb7fcd37@kernel.org> (raw)
In-Reply-To: <20240701130113.433169-2-gnstark@salutedevices.com>
On 01/07/2024 15:01, George Stark wrote:
> The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF.
>
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> index 1d71d4f8f328..63c6018b6b7c 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> @@ -37,6 +37,7 @@ properties:
> - enum:
> - amlogic,meson8-pwm-v2
> - amlogic,meson-s4-pwm
> + - amlogic,meson-a1-pwm, amlogic,meson-s4-pwm
This is not valid, you cannot have such syntax (and there is no single
DT schema file like this).
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-01 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 13:01 [PATCH 0/2] add support for meson a1 PWM in dts and bindings George Stark
2024-07-01 13:01 ` [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm George Stark
2024-07-01 13:25 ` Krzysztof Kozlowski [this message]
2024-07-01 13:01 ` [PATCH 2/2] arm64: dts: meson: a1: add definitions for meson pwm George Stark
-- strict thread matches above, loose matches on Subject: below --
2024-04-23 16:10 [PATCH 0/2] pwm: meson: add pwm support for A1 George Stark
2024-04-23 16:10 ` [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm George Stark
2024-04-23 16:56 ` Conor Dooley
2024-04-23 17:44 ` Jerome Brunet
2024-04-24 6:02 ` Kelvin Zhang
2024-04-24 12:08 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfcebb37-0518-4dac-bd89-d845bb7fcd37@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=ddrokosov@salutedevices.com \
--cc=devicetree@vger.kernel.org \
--cc=gnstark@salutedevices.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).