From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: x1e78100-t14s: Add LCD variant with backlight support
Date: Mon, 10 Mar 2025 15:35:08 +0100 [thread overview]
Message-ID: <cfd2c51a-cf2a-45f1-a926-65388d2c3ed6@kernel.org> (raw)
In-Reply-To: <20250310141504.3008517-3-abel.vesa@linaro.org>
On 10/03/2025 15:15, Abel Vesa wrote:
> Due to the fact that Lenovo Thinkpad T14s Gen6 is available with both
> OLED and LCD, the backlight control differs HW-wise. For the LCD variant,
> the panel's backlight is controlled via one of the PWMs provided by the
> PMK8550 PMIC. For the OLED variant, the backlight is internal to the
> panel and therefore it is not described in devicetree.
>
> For this reason, create a generic dtsi for the T14s by renaming the
> existing dts. While at it, add a node name to panel and drop the enable
> gpio and pinctrl properties from the panel node. Then add the LCD variant
> dts file with the old name and describe all backlight related nodes.
>
> So the existing dts will now be used for LCD variant while for OLED new
> dts will be added.
>
> Tested-by: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-10 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 14:15 [PATCH v2 0/3] arm64: dts: qcom: x1e78100-t14s: Rework devicetree for LCD and OLED SKUs Abel Vesa
2025-03-10 14:15 ` [PATCH v2 1/3] dt-bindings: arm: qcom: Document Lenovo ThinkPad T14s Gen 6 LCD and OLED Abel Vesa
2025-03-10 14:34 ` Krzysztof Kozlowski
2025-03-10 14:15 ` [PATCH v2 2/3] arm64: dts: qcom: x1e78100-t14s: Add LCD variant with backlight support Abel Vesa
2025-03-10 14:35 ` Krzysztof Kozlowski [this message]
2025-03-10 14:15 ` [PATCH v2 3/3] arm64: dts: qcom: x1e78100-t14s: Add OLED variant Abel Vesa
2025-03-10 14:35 ` Krzysztof Kozlowski
2025-03-13 23:06 ` [PATCH v2 0/3] arm64: dts: qcom: x1e78100-t14s: Rework devicetree for LCD and OLED SKUs Bjorn Andersson
2025-03-14 20:00 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd2c51a-cf2a-45f1-a926-65388d2c3ed6@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).