From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Marek Vasut <marek.vasut@mailbox.org>,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: soc: renesas: Document MFIS IP core
Date: Tue, 31 Mar 2026 09:50:10 +0200 [thread overview]
Message-ID: <cfee8254-8573-4106-b71f-293073b64c89@kernel.org> (raw)
In-Reply-To: <dd3587eb-f91e-4a9a-8a0b-b55bfba2c23a@kernel.org>
On 31/03/2026 09:15, Krzysztof Kozlowski wrote:
> On 27/03/2026 12:42, Wolfram Sang wrote:
>>>> +#define MFIS_CHANNEL_TX (0 << 0)
>>>> +#define MFIS_CHANNEL_RX (1 << 0)
>>>
>>> No improvements and no answers to comments. Same review, drop, not a
>>> binding. If disagree, respond to v1 comments.
>>
>> I think I did. I explained above in "changes since v1" that I decided to
>> keep it because of the existing users in upstream that Geert mentioned.
>
> Same review as in v1. Not a binding. I asked what Linux ABI are you here
> binding. Point me to Linux code using these. This is the ABI.
>
> You replied something about device, so how does it matter? It is not the
> answer to the question.
You made the posting unnecessarily complicated - this patch went to my
DT address, but the rest to non-DT. Why not using b4 which gets it
correct without effort? Plus it gives you much more like changelog with
lore links and trailers handling?
So now I found the driver (in different place...) and indeed you use
some of the constants, so this is an ABI. It was so easy in v1 to just
point me to usage of the ABI when I asked how do you use this in Linux...
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-31 7:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 11:07 [PATCH v2 0/3] soc: renesas: add MFIS driver Wolfram Sang
2026-03-25 11:07 ` [PATCH v2 1/3] dt-bindings: soc: renesas: Document MFIS IP core Wolfram Sang
2026-03-26 9:03 ` Krzysztof Kozlowski
2026-03-27 11:42 ` Wolfram Sang
2026-03-31 7:15 ` Krzysztof Kozlowski
2026-03-31 7:50 ` Krzysztof Kozlowski [this message]
2026-03-31 8:08 ` Wolfram Sang
2026-03-31 8:11 ` Krzysztof Kozlowski
2026-03-25 11:07 ` [PATCH v2 2/3] soc: renesas: Add Renesas R-Car MFIS driver Wolfram Sang
2026-03-28 0:16 ` Marek Vasut
2026-03-25 11:07 ` [PATCH v2 3/3] soc: renesas: add X5H PRR support Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfee8254-8573-4106-b71f-293073b64c89@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut@mailbox.org \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox