Re: [PATCHv0 1/2] arm: mvebu: fix LED color in NETGEAR ReadyNAS 102 .dts file

Re: [PATCHv0 1/2] arm: mvebu: fix LED color in NETGEAR ReadyNAS 102 .dts file

[Andrew Lunn]

On Fri, Oct 24, 2014 at 11:22:01PM +0200, Arnaud Ebalard wrote:
> 
> When writing initial .dts file for NETGEAR ReadyNAS 102, I put the wrong color
> for backup and SATA leds (green instead of blue for all three).
> 
> Reported-by: Johan Kristell <johan.kristell-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>

Acked-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>

	  Andrew

> ---
>  arch/arm/boot/dts/armada-370-netgear-rn102.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn102.dts b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> index 3aebd93cc33c..f79579bdf8fe 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> @@ -204,20 +204,20 @@
>  			default-state = "keep";
>  		};
>  
> -		green-sata1-led {
> -			label = "rn102:green:sata1";
> +		blue-sata1-led {
> +			label = "rn102:blue:sata1";
>  			gpios = <&gpio0 15 GPIO_ACTIVE_LOW>;
>  			default-state = "on";
>  		};
>  
> -		green-sata2-led {
> -			label = "rn102:green:sata2";
> +		blue-sata2-led {
> +			label = "rn102:blue:sata2";
>  			gpios = <&gpio0 14 GPIO_ACTIVE_LOW>;
>  			default-state = "on";
>  		};
>  
> -		green-backup-led {
> -			label = "rn102:green:backup";
> +		blue-backup-led {
> +			label = "rn102:blue:backup";
>  			gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
>  			default-state = "on";
>  		};
> -- 
> 2.1.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv0 0/2] arm: mvebu: non-critical fixes for NETGEAR ReadyNAS 102

[Arnaud Ebalard]

Hi,

This two patches are non-critical and respectively fix the following
in RN102 .dts file:
 - the color for LEDs labels (they are blue, and not green)
 - eSATA/SATA ports info

Arnaud Ebalard (2):
  arm: mvebu: fix LED color in NETGEAR ReadyNAS 102 .dts file
  arm: mvebu: clarify (e)SATA ports info in NETGEAR ReadyNAS 102 .dts file

 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

-- 
2.1.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv0 1/2] arm: mvebu: fix LED color in NETGEAR ReadyNAS 102 .dts file

[Arnaud Ebalard]

When writing initial .dts file for NETGEAR ReadyNAS 102, I put the wrong color
for backup and SATA leds (green instead of blue for all three).

Reported-by: Johan Kristell <johan.kristell-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
---
 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/armada-370-netgear-rn102.dts b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
index 3aebd93cc33c..f79579bdf8fe 100644
--- a/arch/arm/boot/dts/armada-370-netgear-rn102.dts
+++ b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
@@ -204,20 +204,20 @@
 			default-state = "keep";
 		};
 
-		green-sata1-led {
-			label = "rn102:green:sata1";
+		blue-sata1-led {
+			label = "rn102:blue:sata1";
 			gpios = <&gpio0 15 GPIO_ACTIVE_LOW>;
 			default-state = "on";
 		};
 
-		green-sata2-led {
-			label = "rn102:green:sata2";
+		blue-sata2-led {
+			label = "rn102:blue:sata2";
 			gpios = <&gpio0 14 GPIO_ACTIVE_LOW>;
 			default-state = "on";
 		};
 
-		green-backup-led {
-			label = "rn102:green:backup";
+		blue-backup-led {
+			label = "rn102:blue:backup";
 			gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
 			default-state = "on";
 		};
-- 
2.1.1


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv0 2/2] arm: mvebu: clarify (e)SATA ports info in NETGEAR ReadyNAS 102 .dts file

[Andrew Lunn]

On Fri, Oct 24, 2014 at 11:22:16PM +0200, Arnaud Ebalard wrote:
> 
> On NETGEAR ReadyNAS 102, the two disks are connected to the external
> Marvell 88SE9170 SATA Controller connected to the PCIe bus. The rear
> eSATA port is connected to the native Armada 370 SATA controller.
> 
> This patch updates the comments in .dts file wrt SATA interfaces and
> reduces the number of ports for native Armada 370 interface from 1
> to 2.

Typ0. 

Jason, can you swap the 1 and 2 around when you commit?
Save having a v2.

Otherwise

Acked-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>

	  Andrew


> 
> Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
> ---
>  arch/arm/boot/dts/armada-370-netgear-rn102.dts | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn102.dts b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> index f79579bdf8fe..1e38628f4060 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> @@ -35,7 +35,7 @@
>  		pcie-controller {
>  			status = "okay";
>  
> -			/* Connected to Marvell SATA controller */
> +			/* Connected to Marvell 88SE9170 SATA controller */
>  			pcie@1,0 {
>  				/* Port 0, Lane 0 */
>  				status = "okay";
> @@ -53,8 +53,9 @@
>  				status = "okay";
>  			};
>  
> +			/* eSATA interface */
>  			sata@a0000 {
> -				nr-ports = <2>;
> +				nr-ports = <1>;
>  				status = "okay";
>  			};
>  
> -- 
> 2.1.1
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv0 2/2] arm: mvebu: clarify (e)SATA ports info in NETGEAR ReadyNAS 102 .dts file

[Arnaud Ebalard]

On NETGEAR ReadyNAS 102, the two disks are connected to the external
Marvell 88SE9170 SATA Controller connected to the PCIe bus. The rear
eSATA port is connected to the native Armada 370 SATA controller.

This patch updates the comments in .dts file wrt SATA interfaces and
reduces the number of ports for native Armada 370 interface from 1
to 2.

Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
---
 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/armada-370-netgear-rn102.dts b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
index f79579bdf8fe..1e38628f4060 100644
--- a/arch/arm/boot/dts/armada-370-netgear-rn102.dts
+++ b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
@@ -35,7 +35,7 @@
 		pcie-controller {
 			status = "okay";
 
-			/* Connected to Marvell SATA controller */
+			/* Connected to Marvell 88SE9170 SATA controller */
 			pcie@1,0 {
 				/* Port 0, Lane 0 */
 				status = "okay";
@@ -53,8 +53,9 @@
 				status = "okay";
 			};
 
+			/* eSATA interface */
 			sata@a0000 {
-				nr-ports = <2>;
+				nr-ports = <1>;
 				status = "okay";
 			};
 
-- 
2.1.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv0 2/2] arm: mvebu: clarify (e)SATA ports info in NETGEAR ReadyNAS 102 .dts file

[Arnaud Ebalard]

Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> writes:

> On Fri, Oct 24, 2014 at 11:22:16PM +0200, Arnaud Ebalard wrote:
>> 
>> On NETGEAR ReadyNAS 102, the two disks are connected to the external
>> Marvell 88SE9170 SATA Controller connected to the PCIe bus. The rear
>> eSATA port is connected to the native Armada 370 SATA controller.
>> 
>> This patch updates the comments in .dts file wrt SATA interfaces and
>> reduces the number of ports for native Armada 370 interface from 1
>> to 2.
>
> Typ0. 
>
> Jason, can you swap the 1 and 2 around when you commit?
> Save having a v2.
>
> Otherwise
>
> Acked-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>

Good catch. Thanks, Andrew.

Cheers,

a+
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv0 0/2] arm: mvebu: non-critical fixes for NETGEAR ReadyNAS 102

[Gregory CLEMENT]

Hi Arnaud,

On 24/10/2014 23:21, Arnaud Ebalard wrote:
> Hi,
> 
> This two patches are non-critical and respectively fix the following
> in RN102 .dts file:
>  - the color for LEDs labels (they are blue, and not green)
>  - eSATA/SATA ports info
> 
> Arnaud Ebalard (2):
>   arm: mvebu: fix LED color in NETGEAR ReadyNAS 102 .dts file
>   arm: mvebu: clarify (e)SATA ports info in NETGEAR ReadyNAS 102 .dts file
> 
>  arch/arm/boot/dts/armada-370-netgear-rn102.dts | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 

For both patches:

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>


Thanks,

Gregory

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv0 0/2] arm: mvebu: non-critical fixes for NETGEAR ReadyNAS 102

[Jason Cooper]

On Fri, Oct 24, 2014 at 11:21:52PM +0200, Arnaud Ebalard wrote:
> Hi,
> 
> This two patches are non-critical and respectively fix the following
> in RN102 .dts file:
>  - the color for LEDs labels (they are blue, and not green)
>  - eSATA/SATA ports info
> 
> Arnaud Ebalard (2):
>   arm: mvebu: fix LED color in NETGEAR ReadyNAS 102 .dts file
>   arm: mvebu: clarify (e)SATA ports info in NETGEAR ReadyNAS 102 .dts file
> 
>  arch/arm/boot/dts/armada-370-netgear-rn102.dts | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)

Both applied to mvebu/dt with Gregory and Andrew's Acks.  Also fixed the
commit typo in the second patch.

thx,

Jason.