* [PATCHv2 0/8] from now on, use 'isil' as prefix for Intersil @ 2014-12-16 21:18 Arnaud Ebalard [not found] ` <cover.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Arnaud Ebalard @ 2014-12-16 21:18 UTC (permalink / raw) To: Alessandro Zummo, Alexandre Courbot, Andrew Lunn, Antony Pavlov, Arnd Bergmann, Darshana Padmadas, devel, devicetree, Florian Vaussard, Greg Kroah-Hartman, Hartmut Knaack, Hayato Suzuki, Heiko Stuebner, Ian Campbell, Jason Cooper, Jonathan Cameron, Kumar Gala, Lars-Peter Clausen, Liam Girdwood, linux-arm-kernel, linux-i2c, linux-iio, linux-tegra, Mark Brown As suggested by Jason on a v0, I made a specific series for that work, which intend to remove all remaining 'isl' prefix for Intersil to only have 'isil'. More details below. When Intersil ISL12057 driver was introduced by commit 70e123373c05 ("rtc: Add support for Intersil ISL12057 I2C RTC chip"), the vendor prefix 'isl' was used instead of the expected 'isil' (Intersil NASDAQ symbol) and documented in vendor-prefixes.txt. Recently, a patch from Philip Zabel (7a6540ca856a, "ARM: mvebu: Change vendor prefix for Intersil Corporation to isil") fixed that prefix in ReadyNAS devices .dts files (AFAICT, the only users of the driver). Then, commits 7c75c1d5e72b ("dt-bindings: Document deprecated device vendor name to fix related warning") and b2ea3f82e798 (dt-bindings: Document correct and deprecated vendor-prefix with device isl29028) decided to go the other way and deprecate isil in vendor-prefixes.txt and in isl29028.c staging driver. While trying and merge a fix I wrote for ISL12057 drivers to finish Philip's work, it conflicted with the two recently introduced commits, and revealed the issue: at the moment, there are various compatible strings in drivers and .dts files for Intersil products which use either isl or isil: $ grep -R "isil," . ./Documentation/devicetree/bindings/i2c/trivial-devices.txt:isil,isl29028 (deprecated, use isl) ./drivers/staging/iio/light/isl29028.c: { .compatible = "isil,isl29028", },/* deprecated, don't use */ ./drivers/staging/iio/light/isl29018.c: { .compatible = "isil,isl29018", }, ./drivers/staging/iio/light/isl29018.c: { .compatible = "isil,isl29023", }, ./drivers/staging/iio/light/isl29018.c: { .compatible = "isil,isl29035", }, ./arch/powerpc/boot/dts/p1022rdk.dts: compatible = "isil,zl6100"; ./arch/powerpc/boot/dts/p1022rdk.dts: compatible = "isil,zl6100"; ./arch/powerpc/boot/dts/p1022rdk.dts: compatible = "isil,zl6100"; ./arch/powerpc/boot/dts/p1022rdk.dts: compatible = "isil,zl6100"; ./arch/arm/boot/dts/exynos5800-peach-pi.dts: compatible = "isil,isl29018"; ./arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi: compatible = "isil,isl1208"; ./arch/arm/boot/dts/tegra20-ventana.dts: compatible = "isil,isl29018"; ./arch/arm/boot/dts/tegra20-seaboard.dts: compatible = "isil,isl29018"; ./arch/arm/boot/dts/armada-xp-netgear-rn2120.dts: compatible = "isil,isl12057"; ./arch/arm/boot/dts/armada-370-netgear-rn104.dts: compatible = "isil,isl12057"; ./arch/arm/boot/dts/exynos5420-peach-pit.dts: compatible = "isil,isl29018"; ./arch/arm/boot/dts/armada-370-netgear-rn102.dts: compatible = "isil,isl12057"; $ grep -R "isl," . ./Documentation/devicetree/bindings/regulator/isl9305.txt:- compatible: "isl,isl9305" or "isl,isl9305h" ./Documentation/devicetree/bindings/regulator/isl9305.txt: compatible = "isl,isl9305"; ./Documentation/devicetree/bindings/i2c/trivial-devices.txt:isl,isl12057 Intersil ISL12057 I2C RTC Chip ./Documentation/devicetree/bindings/i2c/trivial-devices.txt:isl,isl29028 Intersil ISL29028 Ambient Light .... ./drivers/regulator/isl9305.c: { .compatible = "isl,isl9305" }, ./drivers/regulator/isl9305.c: { .compatible = "isl,isl9305h" }, ./drivers/staging/iio/light/isl29028.c: { .compatible = "isl,isl29028", }, ./drivers/rtc/rtc-isl12057.c: { .compatible = "isl,isl12057" }, ./drivers/rtc/rtc-isl12022.c: { .compatible = "isl,isl12022" }, ./arch/arm/boot/dts/tegra30-cardhu.dtsi: compatible = "isl,isl29028"; ./arch/arm/boot/dts/zynq-parallella.dts: compatible = "isl,isl9305"; AFAICT, it seems it makes sense to *definitively* settle for isil as the vendor prefix for Intersil, as Philip did in 7a6540ca856a: it's the NASDAQ symbol and this choice requires less changes than opting for isl. So, this series changes compatible strings in .dts files to use isil where isl was found before, and modify drivers w/ compatible strings using isl to add one using isil. In those cases, a comment is made that the old compatible string is kept for backward compatibility (w/ out-fo-tree users of those drivers). Additionally, it leaves only isil as prefix in vendor-prefixes.txt. Those changes should prevent any new inclusion of isl compatible strings for Intersil devices due to copy-and-paste. Changes since v1: - split previous patch fixing trivial-devices.txt and vendor-prefixes.txt in two different patches, as suggested by Uwe - fixed a space/tab issue spotted by Uwe Arnaud Ebalard (8): dt-bindings: use isil prefix for Intersil in vendor-prefixes.txt dt-bindings: use isil prefix for Intersil in I2C trivial-devices.txt rtc: isl12022: deprecate use of isl in compatible string for isil rtc: isl12057: deprecate use of isl in compatible string for isil staging: iio: isl29028: deprecate use of isl in compatible string for isil regulator: isl9305: deprecate use of isl in compatible string for isil arm: dts: zynq: update isl9305 compatible string to use isil vendor prefix arm: dts: tegra: update isl29028 compatible string to use isil vendor prefix Documentation/devicetree/bindings/i2c/trivial-devices.txt | 5 ++--- Documentation/devicetree/bindings/regulator/isl9305.txt | 4 ++-- Documentation/devicetree/bindings/vendor-prefixes.txt | 3 +-- arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +- arch/arm/boot/dts/zynq-parallella.dts | 2 +- drivers/regulator/isl9305.c | 6 ++++-- drivers/rtc/rtc-isl12022.c | 3 ++- drivers/rtc/rtc-isl12057.c | 3 ++- drivers/staging/iio/light/isl29028.c | 4 ++-- 9 files changed, 17 insertions(+), 15 deletions(-) -- 2.1.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <cover.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>]
* [PATCHv2 1/8] dt-bindings: use isil prefix for Intersil in vendor-prefixes.txt [not found] ` <cover.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> @ 2014-12-16 21:18 ` Arnaud Ebalard [not found] ` <e32fe98a511e3ab8aeed9849bcac33ba14fd8986.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2014-12-16 21:19 ` [PATCHv2 2/8] dt-bindings: use isil prefix for Intersil in I2C trivial-devices.txt Arnaud Ebalard ` (3 subsequent siblings) 4 siblings, 1 reply; 15+ messages in thread From: Arnaud Ebalard @ 2014-12-16 21:18 UTC (permalink / raw) To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Mark Brown, Heiko Stuebner, Jason Cooper, Shawn Guo, Florian Vaussard, Andrew Lunn, Hayato Suzuki, Antony Pavlov, devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew Morton, Uwe Kleine-König This patch fixes DT vendor-prefixes.txt documentation to reference isil (NASDAQ symbol and the most used prefix inside the kernel) for Intersil. It reverts 7c75c1d5e72b ("dt-bindings: Document deprecated device vendor name to fix related warning"). Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 423d47418e72..585e5b5dca27 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -81,8 +81,7 @@ innolux Innolux Corporation intel Intel Corporation intercontrol Inter Control Group isee ISEE 2007 S.L. -isil Intersil (deprecated, use isl) -isl Intersil +isil Intersil karo Ka-Ro electronics GmbH keymile Keymile GmbH lacie LaCie -- 2.1.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <e32fe98a511e3ab8aeed9849bcac33ba14fd8986.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>]
* Re: [PATCHv2 1/8] dt-bindings: use isil prefix for Intersil in vendor-prefixes.txt [not found] ` <e32fe98a511e3ab8aeed9849bcac33ba14fd8986.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> @ 2015-01-13 20:02 ` Rob Herring [not found] ` <CAL_JsqLt7BuG9eccqR4CELPsOO+o3NGP6c4aqKDXbJfT0O0=5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Rob Herring @ 2015-01-13 20:02 UTC (permalink / raw) To: Arnaud Ebalard Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Mark Brown, Heiko Stuebner, Jason Cooper, Shawn Guo, Florian Vaussard, Andrew Lunn, Hayato Suzuki, Antony Pavlov, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton, Uwe Kleine-König On Tue, Dec 16, 2014 at 3:18 PM, Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> wrote: > > This patch fixes DT vendor-prefixes.txt documentation to reference > isil (NASDAQ symbol and the most used prefix inside the kernel) for > Intersil. > > It reverts 7c75c1d5e72b ("dt-bindings: Document deprecated device > vendor name to fix related warning"). > > Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> Applied for 3.20. Thanks. While there are not interdepencies here, it probably would have been better to keep this series all together. Other patches have already been picked up, so I'm just taking this one. Rob > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 423d47418e72..585e5b5dca27 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -81,8 +81,7 @@ innolux Innolux Corporation > intel Intel Corporation > intercontrol Inter Control Group > isee ISEE 2007 S.L. > -isil Intersil (deprecated, use isl) > -isl Intersil > +isil Intersil > karo Ka-Ro electronics GmbH > keymile Keymile GmbH > lacie LaCie > -- > 2.1.1 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <CAL_JsqLt7BuG9eccqR4CELPsOO+o3NGP6c4aqKDXbJfT0O0=5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCHv2 1/8] dt-bindings: use isil prefix for Intersil in vendor-prefixes.txt [not found] ` <CAL_JsqLt7BuG9eccqR4CELPsOO+o3NGP6c4aqKDXbJfT0O0=5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-01-13 23:21 ` Arnaud Ebalard [not found] ` <87ppaib72j.fsf-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Arnaud Ebalard @ 2015-01-13 23:21 UTC (permalink / raw) To: Rob Herring Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Mark Brown, Heiko Stuebner, Jason Cooper, Shawn Guo, Florian Vaussard, Andrew Lunn, Hayato Suzuki, Antony Pavlov, devicetree@vger.kernel.org, Andrew Morton, Uwe Kleine-König Hi Rob, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes: > On Tue, Dec 16, 2014 at 3:18 PM, Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> wrote: >> >> This patch fixes DT vendor-prefixes.txt documentation to reference >> isil (NASDAQ symbol and the most used prefix inside the kernel) for >> Intersil. >> >> It reverts 7c75c1d5e72b ("dt-bindings: Document deprecated device >> vendor name to fix related warning"). >> >> Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> > > Applied for 3.20. Thanks. > > While there are not interdepencies here, it probably would have been > better to keep this series all together. This was the main reason my v0 was in a single patch. I think I then got some comment to split things in different patches so that the various maintainers have their words to say. But I'll try and follow your approach next time. > Other patches have already been picked up, so I'm just taking this > one. Thanks. Cheers, a+ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <87ppaib72j.fsf-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>]
* Re: [PATCHv2 1/8] dt-bindings: use isil prefix for Intersil in vendor-prefixes.txt [not found] ` <87ppaib72j.fsf-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> @ 2015-01-13 23:31 ` Rob Herring [not found] ` <CAL_JsqJMQ=8_sQhCRR+f-6v0Ac3hme3Tsom0x1GuA=FaZkgdnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Rob Herring @ 2015-01-13 23:31 UTC (permalink / raw) To: Arnaud Ebalard Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Mark Brown, Heiko Stuebner, Jason Cooper, Shawn Guo, Florian Vaussard, Andrew Lunn, Hayato Suzuki, Antony Pavlov, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton, Uwe Kleine-König On Tue, Jan 13, 2015 at 5:21 PM, Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> wrote: > Hi Rob, > > Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes: > >> On Tue, Dec 16, 2014 at 3:18 PM, Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> wrote: >>> >>> This patch fixes DT vendor-prefixes.txt documentation to reference >>> isil (NASDAQ symbol and the most used prefix inside the kernel) for >>> Intersil. >>> >>> It reverts 7c75c1d5e72b ("dt-bindings: Document deprecated device >>> vendor name to fix related warning"). >>> >>> Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> >> >> Applied for 3.20. Thanks. >> >> While there are not interdepencies here, it probably would have been >> better to keep this series all together. > > This was the main reason my v0 was in a single patch. I think I then got > some comment to split things in different patches so that the various > maintainers have their words to say. But I'll try and follow your > approach next time. I didn't say a single patch, but merge the series together. A separate commit per maintainer is generally preferred. You just have to be clear whether you are looking for just acks or to take individual patches. I should have chimed in earlier as well, but I missed this initially. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <CAL_JsqJMQ=8_sQhCRR+f-6v0Ac3hme3Tsom0x1GuA=FaZkgdnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCHv2 1/8] dt-bindings: use isil prefix for Intersil in vendor-prefixes.txt [not found] ` <CAL_JsqJMQ=8_sQhCRR+f-6v0Ac3hme3Tsom0x1GuA=FaZkgdnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-01-14 9:25 ` Arnaud Ebalard 0 siblings, 0 replies; 15+ messages in thread From: Arnaud Ebalard @ 2015-01-14 9:25 UTC (permalink / raw) To: Rob Herring Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Mark Brown, Heiko Stuebner, Jason Cooper, Shawn Guo, Florian Vaussard, Andrew Lunn, Hayato Suzuki, Antony Pavlov, devicetree@vger.kernel.org, Andrew Morton, Uwe Kleine-König Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes: >>> While there are not interdepencies here, it probably would have been >>> better to keep this series all together. >> >> This was the main reason my v0 was in a single patch. I think I then got >> some comment to split things in different patches so that the various >> maintainers have their words to say. But I'll try and follow your >> approach next time. > > I didn't say a single patch, but merge the series together. A separate > commit per maintainer is generally preferred. You just have to be > clear whether you are looking for just acks or to take individual > patches. Noted. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCHv2 2/8] dt-bindings: use isil prefix for Intersil in I2C trivial-devices.txt [not found] ` <cover.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2014-12-16 21:18 ` [PATCHv2 1/8] dt-bindings: use isil prefix for Intersil in vendor-prefixes.txt Arnaud Ebalard @ 2014-12-16 21:19 ` Arnaud Ebalard [not found] ` <86079cdf7325f6d83e0270d32ff66bcc3e6a34bb.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2014-12-16 21:20 ` [PATCHv2 6/8] regulator: isl9305: deprecate use of isl in compatible string for isil Arnaud Ebalard ` (2 subsequent siblings) 4 siblings, 1 reply; 15+ messages in thread From: Arnaud Ebalard @ 2014-12-16 21:19 UTC (permalink / raw) To: Wolfram Sang, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, linux-i2c-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew Morton, Uwe Kleine-König, Arnd Bergmann, Darshana Padmadas This patch fixes I2C trivial-devices.txt DT documentation file to reference isil (NASDAQ symbol and the most used prefix inside the kernel) for Intersil. It reverts 7c75c1d5e72b ("dt-bindings: Document deprecated device vendor name to fix related warning"). Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt index 9f4e3824e71e..55b8cd396d43 100644 --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt @@ -58,9 +58,8 @@ fsl,sgtl5000 SGTL5000: Ultra Low-Power Audio Codec gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz) -isl,isl12057 Intersil ISL12057 I2C RTC Chip -isil,isl29028 (deprecated, use isl) -isl,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor +isil,isl12057 Intersil ISL12057 I2C RTC Chip +isil,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs maxim,max6625 9-Bit/12-Bit Temperature Sensors with I²C-Compatible Serial Interface -- 2.1.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <86079cdf7325f6d83e0270d32ff66bcc3e6a34bb.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>]
* Re: [PATCHv2 2/8] dt-bindings: use isil prefix for Intersil in I2C trivial-devices.txt [not found] ` <86079cdf7325f6d83e0270d32ff66bcc3e6a34bb.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> @ 2014-12-17 6:46 ` Wolfram Sang 2014-12-17 21:59 ` Arnaud Ebalard 2015-01-13 15:45 ` Wolfram Sang 1 sibling, 1 reply; 15+ messages in thread From: Wolfram Sang @ 2014-12-17 6:46 UTC (permalink / raw) To: Arnaud Ebalard Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, linux-i2c-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew Morton, Uwe Kleine-König, Arnd Bergmann, Darshana Padmadas [-- Attachment #1: Type: text/plain, Size: 556 bytes --] On Tue, Dec 16, 2014 at 10:19:53PM +0100, Arnaud Ebalard wrote: > > This patch fixes I2C trivial-devices.txt DT documentation file to > reference isil (NASDAQ symbol and the most used prefix inside the > kernel) for Intersil. > > It reverts 7c75c1d5e72b ("dt-bindings: Document deprecated device > vendor name to fix related warning"). > > Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> Should I take it or does it go via another tree? [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCHv2 2/8] dt-bindings: use isil prefix for Intersil in I2C trivial-devices.txt 2014-12-17 6:46 ` Wolfram Sang @ 2014-12-17 21:59 ` Arnaud Ebalard 0 siblings, 0 replies; 15+ messages in thread From: Arnaud Ebalard @ 2014-12-17 21:59 UTC (permalink / raw) To: Wolfram Sang Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, linux-i2c-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew Morton, Uwe Kleine-König, Arnd Bergmann, Darshana Padmadas Hi Wolfram, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> writes: > On Tue, Dec 16, 2014 at 10:19:53PM +0100, Arnaud Ebalard wrote: >> >> This patch fixes I2C trivial-devices.txt DT documentation file to >> reference isil (NASDAQ symbol and the most used prefix inside the >> kernel) for Intersil. >> >> It reverts 7c75c1d5e72b ("dt-bindings: Document deprecated device >> vendor name to fix related warning"). >> >> Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> > > Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> > > Should I take it or does it go via another tree? No one has objected yet and MAINTAINERS file tells its under your jurisdiction, so I guess you can take ;-) Cheers, a+ ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCHv2 2/8] dt-bindings: use isil prefix for Intersil in I2C trivial-devices.txt [not found] ` <86079cdf7325f6d83e0270d32ff66bcc3e6a34bb.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2014-12-17 6:46 ` Wolfram Sang @ 2015-01-13 15:45 ` Wolfram Sang 1 sibling, 0 replies; 15+ messages in thread From: Wolfram Sang @ 2015-01-13 15:45 UTC (permalink / raw) To: Arnaud Ebalard Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, linux-i2c-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew Morton, Uwe Kleine-König, Arnd Bergmann, Darshana Padmadas [-- Attachment #1: Type: text/plain, Size: 464 bytes --] On Tue, Dec 16, 2014 at 10:19:53PM +0100, Arnaud Ebalard wrote: > > This patch fixes I2C trivial-devices.txt DT documentation file to > reference isil (NASDAQ symbol and the most used prefix inside the > kernel) for Intersil. > > It reverts 7c75c1d5e72b ("dt-bindings: Document deprecated device > vendor name to fix related warning"). > > Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> Applied to for-next, thanks! [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCHv2 6/8] regulator: isl9305: deprecate use of isl in compatible string for isil [not found] ` <cover.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2014-12-16 21:18 ` [PATCHv2 1/8] dt-bindings: use isil prefix for Intersil in vendor-prefixes.txt Arnaud Ebalard 2014-12-16 21:19 ` [PATCHv2 2/8] dt-bindings: use isil prefix for Intersil in I2C trivial-devices.txt Arnaud Ebalard @ 2014-12-16 21:20 ` Arnaud Ebalard [not found] ` <50335b337738057806dbe5f3171dedd6f84b9eda.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2014-12-16 21:21 ` [PATCHv2 7/8] arm: dts: zynq: update isl9305 compatible string to use isil vendor prefix Arnaud Ebalard 2014-12-16 21:21 ` [PATCHv2 8/8] arm: dts: tegra: update isl29028 " Arnaud Ebalard 4 siblings, 1 reply; 15+ messages in thread From: Arnaud Ebalard @ 2014-12-16 21:20 UTC (permalink / raw) To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Liam Girdwood, Mark Brown, devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew Morton, Uwe Kleine-König, Arnd Bergmann, Darshana Padmadas "isil" and "isl" prefixes are used at various locations inside the kernel to reference Intersil corporation. This patch is part of a series fixing those locations were "isl" is used in compatible strings to use the now expected "isil" prefix instead (NASDAQ symbol for Intersil and most used version). The old compatible string is kept for backward compatibility. Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> --- Documentation/devicetree/bindings/regulator/isl9305.txt | 4 ++-- drivers/regulator/isl9305.c | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator/isl9305.txt b/Documentation/devicetree/bindings/regulator/isl9305.txt index a626fc1bbf0d..d6e7c9ec9413 100644 --- a/Documentation/devicetree/bindings/regulator/isl9305.txt +++ b/Documentation/devicetree/bindings/regulator/isl9305.txt @@ -2,7 +2,7 @@ Intersil ISL9305/ISL9305H voltage regulator Required properties: -- compatible: "isl,isl9305" or "isl,isl9305h" +- compatible: "isil,isl9305" or "isil,isl9305h" - reg: I2C slave address, usually 0x68. - regulators: A node that houses a sub-node for each regulator within the device. Each sub-node is identified using the node's name, with valid @@ -19,7 +19,7 @@ Optional properties: Example pmic: isl9305@68 { - compatible = "isl,isl9305"; + compatible = "isil,isl9305"; reg = <0x68>; VINDCD1-supply = <&system_power>; diff --git a/drivers/regulator/isl9305.c b/drivers/regulator/isl9305.c index 92fefd98da58..6e3a15fe00f1 100644 --- a/drivers/regulator/isl9305.c +++ b/drivers/regulator/isl9305.c @@ -177,8 +177,10 @@ static int isl9305_i2c_probe(struct i2c_client *i2c, #ifdef CONFIG_OF static const struct of_device_id isl9305_dt_ids[] = { - { .compatible = "isl,isl9305" }, - { .compatible = "isl,isl9305h" }, + { .compatible = "isl,isl9305" }, /* for backward compat., don't use */ + { .compatible = "isil,isl9305" }, + { .compatible = "isl,isl9305h" }, /* for backward compat., don't use */ + { .compatible = "isil,isl9305h" }, {}, }; #endif -- 2.1.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <50335b337738057806dbe5f3171dedd6f84b9eda.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>]
* Re: [PATCHv2 6/8] regulator: isl9305: deprecate use of isl in compatible string for isil [not found] ` <50335b337738057806dbe5f3171dedd6f84b9eda.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> @ 2014-12-22 17:51 ` Mark Brown 0 siblings, 0 replies; 15+ messages in thread From: Mark Brown @ 2014-12-22 17:51 UTC (permalink / raw) To: Arnaud Ebalard Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Liam Girdwood, devicetree-u79uwXL29TY76Z2rM5mHXA, Andrew Morton, Uwe Kleine-König, Arnd Bergmann, Darshana Padmadas [-- Attachment #1: Type: text/plain, Size: 468 bytes --] On Tue, Dec 16, 2014 at 10:20:50PM +0100, Arnaud Ebalard wrote: > > "isil" and "isl" prefixes are used at various locations inside the kernel > to reference Intersil corporation. This patch is part of a series fixing > those locations were "isl" is used in compatible strings to use the now > expected "isil" prefix instead (NASDAQ symbol for Intersil and most used > version). The old compatible string is kept for backward compatibility. Applied, thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCHv2 7/8] arm: dts: zynq: update isl9305 compatible string to use isil vendor prefix [not found] ` <cover.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> ` (2 preceding siblings ...) 2014-12-16 21:20 ` [PATCHv2 6/8] regulator: isl9305: deprecate use of isl in compatible string for isil Arnaud Ebalard @ 2014-12-16 21:21 ` Arnaud Ebalard 2014-12-16 21:21 ` [PATCHv2 8/8] arm: dts: tegra: update isl29028 " Arnaud Ebalard 4 siblings, 0 replies; 15+ messages in thread From: Arnaud Ebalard @ 2014-12-16 21:21 UTC (permalink / raw) To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Michal Simek, Sören Brinkmann, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Andrew Morton, Uwe Kleine-König, Arnd Bergmann, Darshana Padmadas "isil" and "isl" prefixes are used at various locations inside the kernel to reference Intersil corporation. This patch is part of a series fixing those locations were "isl" is used in compatible strings to use the now expected "isil" prefix instead (NASDAQ symbol for Intersil and most used version). Note: isl9305 is an I2C device so the patch does not in fact currently depend on the introduction of "isil"-based compatible string in isl9305 driver (provided by another patch) because I2C core does not check the prefix yet. Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> --- arch/arm/boot/dts/zynq-parallella.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts index ab1dc0a56cdd..174571232ea5 100644 --- a/arch/arm/boot/dts/zynq-parallella.dts +++ b/arch/arm/boot/dts/zynq-parallella.dts @@ -58,7 +58,7 @@ status = "okay"; isl9305: isl9305@68 { - compatible = "isl,isl9305"; + compatible = "isil,isl9305"; reg = <0x68>; regulators { -- 2.1.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCHv2 8/8] arm: dts: tegra: update isl29028 compatible string to use isil vendor prefix [not found] ` <cover.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> ` (3 preceding siblings ...) 2014-12-16 21:21 ` [PATCHv2 7/8] arm: dts: zynq: update isl9305 compatible string to use isil vendor prefix Arnaud Ebalard @ 2014-12-16 21:21 ` Arnaud Ebalard [not found] ` <8cfd0ac11713262036dca415e59e56508fb07c3c.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 4 siblings, 1 reply; 15+ messages in thread From: Arnaud Ebalard @ 2014-12-16 21:21 UTC (permalink / raw) To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Stephen Warren, Thierry Reding, Alexandre Courbot, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-tegra-u79uwXL29TY76Z2rM5mHXA, Andrew Morton, Uwe Kleine-König, Arnd Bergmann, Darshana Padmadas "isil" and "isl" prefixes are used at various locations inside the kernel to reference Intersil corporation. This patch is part of a series fixing those locations were "isl" is used in compatible strings to use the now expected "isil" prefix instead (NASDAQ symbol for Intersil and most used version). Note: isl29028 is an I2C device so the patch does not in fact currently depend on the introduction of "isil"-based compatible string in isl29028 driver because I2C core does not check the prefix yet. Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> --- arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi index cbf5a1ae0ca7..a1b682ea01bd 100644 --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi @@ -189,7 +189,7 @@ /* ALS and Proximity sensor */ isl29028@44 { - compatible = "isl,isl29028"; + compatible = "isil,isl29028"; reg = <0x44>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>; -- 2.1.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <8cfd0ac11713262036dca415e59e56508fb07c3c.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>]
* Re: [PATCHv2 8/8] arm: dts: tegra: update isl29028 compatible string to use isil vendor prefix [not found] ` <8cfd0ac11713262036dca415e59e56508fb07c3c.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> @ 2015-01-09 11:06 ` Thierry Reding 0 siblings, 0 replies; 15+ messages in thread From: Thierry Reding @ 2015-01-09 11:06 UTC (permalink / raw) To: Arnaud Ebalard Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Stephen Warren, Alexandre Courbot, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-tegra-u79uwXL29TY76Z2rM5mHXA, Andrew Morton, Uwe Kleine-König, Arnd Bergmann, Darshana Padmadas [-- Attachment #1: Type: text/plain, Size: 846 bytes --] On Tue, Dec 16, 2014 at 10:21:16PM +0100, Arnaud Ebalard wrote: > > "isil" and "isl" prefixes are used at various locations inside the kernel > to reference Intersil corporation. This patch is part of a series fixing > those locations were "isl" is used in compatible strings to use the now > expected "isil" prefix instead (NASDAQ symbol for Intersil and most used > version). > > Note: isl29028 is an I2C device so the patch does not in fact currently > depend on the introduction of "isil"-based compatible string in isl29028 > driver because I2C core does not check the prefix yet. > > Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> > --- > arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to the for-3.20/dt branch, thanks. Thierry [-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-01-14 9:25 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-12-16 21:18 [PATCHv2 0/8] from now on, use 'isil' as prefix for Intersil Arnaud Ebalard [not found] ` <cover.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2014-12-16 21:18 ` [PATCHv2 1/8] dt-bindings: use isil prefix for Intersil in vendor-prefixes.txt Arnaud Ebalard [not found] ` <e32fe98a511e3ab8aeed9849bcac33ba14fd8986.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2015-01-13 20:02 ` Rob Herring [not found] ` <CAL_JsqLt7BuG9eccqR4CELPsOO+o3NGP6c4aqKDXbJfT0O0=5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-01-13 23:21 ` Arnaud Ebalard [not found] ` <87ppaib72j.fsf-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2015-01-13 23:31 ` Rob Herring [not found] ` <CAL_JsqJMQ=8_sQhCRR+f-6v0Ac3hme3Tsom0x1GuA=FaZkgdnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-01-14 9:25 ` Arnaud Ebalard 2014-12-16 21:19 ` [PATCHv2 2/8] dt-bindings: use isil prefix for Intersil in I2C trivial-devices.txt Arnaud Ebalard [not found] ` <86079cdf7325f6d83e0270d32ff66bcc3e6a34bb.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2014-12-17 6:46 ` Wolfram Sang 2014-12-17 21:59 ` Arnaud Ebalard 2015-01-13 15:45 ` Wolfram Sang 2014-12-16 21:20 ` [PATCHv2 6/8] regulator: isl9305: deprecate use of isl in compatible string for isil Arnaud Ebalard [not found] ` <50335b337738057806dbe5f3171dedd6f84b9eda.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2014-12-22 17:51 ` Mark Brown 2014-12-16 21:21 ` [PATCHv2 7/8] arm: dts: zynq: update isl9305 compatible string to use isil vendor prefix Arnaud Ebalard 2014-12-16 21:21 ` [PATCHv2 8/8] arm: dts: tegra: update isl29028 " Arnaud Ebalard [not found] ` <8cfd0ac11713262036dca415e59e56508fb07c3c.1418763328.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> 2015-01-09 11:06 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).