devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
To: ludovic.desroches@atmel.com, nicolas.ferre@atmel.com,
	linux-i2c@vger.kernel.org, wsa@the-dreams.de
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	robh+dt@kernel.org, Cyrille Pitchen <cyrille.pitchen@atmel.com>
Subject: [PATCH v5 0/6] i2c: at91: add support to FIFOs and alternative command
Date: Wed, 3 Jun 2015 18:25:16 +0200	[thread overview]
Message-ID: <cover.1433348016.git.cyrille.pitchen@atmel.com> (raw)

ChangeLog

v5:
- print I2C controller version in an already existing dev_info() instead of
  adding a new one.

v4:
- replace 0x%x by %#x when printing I2C controller version
- change the order of patches: the race condition bug fix becomes the first
  patch so it be can more easily applied to older kernels.

v3:
- fix braces {} coding style issue
- split the alternative command patch into 2 patches: the first one fixes
  a race condition whereas the second one is the actual alternative command
  patch

v2:
- fix typo in comment for AT91_TWI_SVEN.
- document new device tree bindings like "atmel,fifo-size".
- explicitly set the has_alt_cmd boolean to false to already existing chip
  configs.
- use the BIT() macro to define the register bits and do a little cleanup in a
  dedicated patch.
- reword some comments to better explain why the TXCOMP interrupt is no longer
  enabled in at91_do_twi_transfer() but later in
  at91_twi_write_data_dma_callback() to avoid a race condition when DMA is used.
- remove useless TXCOMP interrupt enable line in at91_twi_write_next_byte()
  since this interrupt is also enabled by at91_do_twi_transfer() for PIO
  transfers.

v1:
This series of patches adds support of two new features which will be
introduced with Atmel sama5d2x SoC.

First, the alternative command mode eases the sending of STOP conditions.
Before starting an I2C transaction, the size data to be transfered is
written into the new Alternative Command Register. For each byte transferred,
the I2C controller decreases this counter and automatically sends a STOP
condition when the counter value reaches 0, that is to say when the last byte
of the transaction has been sent/received. So there is no longer need to set
the STOP bit into the Control Register.

Then the use of FIFOs allows to reduce number I/O accesses: for instance,
the TX FIFO allows to write up to 4 data in a single access to the Transmit
Holding Register. Also the RX FIFO allows to read up to 4 data in a single
access to the Receive Holding Register. Currently only DMA transfers take
advantage of FIFOs.

Cyrille Pitchen (6):
  i2c: at91: fix a race condition when using the DMA controller
  i2c: at91: use BIT() macro to define register bits
  i2c: at91: update documentation for DT bindings
  i2c: at91: add support for new alternative command mode
  i2c: at91: print hardware version
  i2c: at91: add support to FIFOs

 Documentation/devicetree/bindings/i2c/i2c-at91.txt |  29 +-
 drivers/i2c/busses/i2c-at91.c                      | 356 +++++++++++++++++----
 2 files changed, 322 insertions(+), 63 deletions(-)

-- 
1.8.2.2

             reply	other threads:[~2015-06-03 16:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 16:25 Cyrille Pitchen [this message]
2015-06-03 16:25 ` [PATCH v5 6/6] i2c: at91: add support to FIFOs Cyrille Pitchen
     [not found] ` <cover.1433348016.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-03 16:25   ` [PATCH v5 1/6] i2c: at91: fix a race condition when using the DMA controller Cyrille Pitchen
2015-06-03 16:25   ` [PATCH v5 2/6] i2c: at91: use BIT() macro to define register bits Cyrille Pitchen
2015-06-03 16:25   ` [PATCH v5 3/6] i2c: at91: update documentation for DT bindings Cyrille Pitchen
2015-06-09 16:04     ` Nicolas Ferre
2015-06-03 16:25   ` [PATCH v5 4/6] i2c: at91: add support for new alternative command mode Cyrille Pitchen
2015-06-09 16:07     ` Nicolas Ferre
     [not found]       ` <55770F43.7050707-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-09 22:19         ` Wolfram Sang
2015-06-03 16:25   ` [PATCH v5 5/6] i2c: at91: print hardware version Cyrille Pitchen
2015-06-04  6:02   ` [PATCH v5 0/6] i2c: at91: add support to FIFOs and alternative command Ludovic Desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1433348016.git.cyrille.pitchen@atmel.com \
    --to=cyrille.pitchen@atmel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).