From: Jyri Sarha <jsarha@ti.com>
To: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
bcousson@baylibre.com, tony@atomide.com
Cc: Jyri Sarha <jsarha@ti.com>,
peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
kbeldan@baylibre.com, laurent.pinchart@ideasonboard.com
Subject: [PATCH v2 0/7] drm/tilcdc: Address LCDC rev 2 color errata
Date: Thu, 25 Aug 2016 15:03:35 +0300 [thread overview]
Message-ID: <cover.1472126231.git.jsarha@ti.com> (raw)
Changes since v1:
- Change the blue-and-red-wiring property to boolean blue-and-red-crossed
- This breaks to little backward compatibility the earlier series had, but
makes the binding more straight forward
- This changes requires changes to am335x-evm and am335x-evmsk dts-files
- The old beaglebone-black dts files remain compatible, but the patch
suggests in commenst on how to support 24-bit RGB mode with BBB
The first patch ("drm/tilcdc: Remove drm_helper_disable_unused_functions()
call") is completely independent fix.
The red and blue components are reversed between 24 and 16 bit modes
on am335x LCDC output pins. To get 24 RGB format the wires red and
blue wires has to be crossed and this in turn causes 16 colors output
to be in BGR format. With straight wiring the 16 color is RGB and 24
bit is BGR. These patches try to deal with the issue in reasonable
manner.
For more details see section 3.1.1 in AM335x Silicon Errata:
http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360
Jyri Sarha (7):
drm/tilcdc: Remove drm_helper_disable_unused_functions() call
drm/tilcdc: Add blue-and-red-crossed devicetree property
drm/tilcdc: Choose console BPP that supports RGB
ARM: dts: am335x-boneblack: Add comments on how to support 24 bit RGB
mode
ARM: dts: am335x-evm: Add blue-and-red-crossed -property to lcdc node
ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodes
ARM: dts: am335x-evmsk: Add blue-and-red-crossed -property to lcdc
node
.../devicetree/bindings/display/tilcdc/tilcdc.txt | 12 +++++++
arch/arm/boot/dts/am335x-boneblack.dts | 12 +++++++
arch/arm/boot/dts/am335x-evm.dts | 2 ++
arch/arm/boot/dts/am335x-evmsk.dts | 42 +++++++++++-----------
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 39 ++++++++++++++------
drivers/gpu/drm/tilcdc/tilcdc_drv.h | 5 ++-
drivers/gpu/drm/tilcdc/tilcdc_external.c | 7 ++--
drivers/gpu/drm/tilcdc/tilcdc_external.h | 2 +-
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 --
drivers/gpu/drm/tilcdc/tilcdc_plane.c | 9 ++---
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 2 --
11 files changed, 87 insertions(+), 47 deletions(-)
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2016-08-25 12:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 12:03 Jyri Sarha [this message]
2016-08-25 12:03 ` [PATCH v2 1/7] drm/tilcdc: Remove drm_helper_disable_unused_functions() call Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 2/7] drm/tilcdc: Add blue-and-red-crossed devicetree property Jyri Sarha
2016-08-26 12:51 ` Rob Herring
2016-08-26 17:44 ` Jyri Sarha
[not found] ` <f4f9d53e-bc9a-6b88-7fe4-3f3015abfdb5-l0cyMroinI0@public.gmane.org>
2016-08-30 12:46 ` Tomi Valkeinen
2016-08-30 12:54 ` Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 3/7] drm/tilcdc: Choose console BPP that supports RGB Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 4/7] ARM: dts: am335x-boneblack: Add comments on how to support 24 bit RGB mode Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 5/7] ARM: dts: am335x-evm: Add blue-and-red-crossed -property to lcdc node Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 6/7] ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodes Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 7/7] ARM: dts: am335x-evmsk: Add blue-and-red-crossed -property to lcdc node Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1472126231.git.jsarha@ti.com \
--to=jsarha@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbeldan@baylibre.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).