devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	bcousson@baylibre.com, tony@atomide.com,
	linux-arm-kernel@lists.infradead.org
Cc: Jyri Sarha <jsarha@ti.com>,
	peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	kbeldan@baylibre.com, laurent.pinchart@ideasonboard.com
Subject: [PATCH v3 0/8] drm/tilcdc: Address LCDC rev 2 color errata + other fixes
Date: Wed, 31 Aug 2016 16:14:05 +0300	[thread overview]
Message-ID: <cover.1472634657.git.jsarha@ti.com> (raw)

Changes since v2:
- Fiddle with color wiring propety once more, now it follows this Tomi's
  comment:
  - No property set: driver advertises RG16 and RG24. This is
    wrong, but that's what the current status is, right?
  - Property set to "default" or "straight" or whatever: driver
    says RG16 and BG24
  - Property set to "crossed": driver says BG16 and RG24
- Add v2 version of "drm/tilcdc: Write DMA base and ceiling address with..."
  - The first version was sent individually, this second version has
    __iowmb(); and __cpu_to_le64(); added to tilcdc_write64()

Changes since v1:
- Change the blue-and-red-wiring property to boolean blue-and-red-crossed
  - This breaks to little backward compatibility the earlier series had, but
    makes the binding more straight forward
  - This changes requires changes to am335x-evm and am335x-evmsk dts-files
  - The old beaglebone-black dts files remain compatible, but the patch
    suggests in commenst on how to support 24-bit RGB mode with BBB

The first patch ("drm/tilcdc: Remove drm_helper_disable_unused_functions()
call") is completely independent fix.

The red and blue components are reversed between 24 and 16 bit modes
on am335x LCDC output pins. To get 24 RGB format the wires red and
blue wires has to be crossed and this in turn causes 16 colors output
to be in BGR format. With straight wiring the 16 color is RGB and 24
bit is BGR. These patches try to deal with the issue in reasonable
manner.

For more details see section 3.1.1 in AM335x Silicon Errata:
http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360

Jyri Sarha (8):
  drm/tilcdc: Remove drm_helper_disable_unused_functions() call
  drm/tilcdc: Write DMA base and ceiling address with single instruction
  drm/tilcdc: Add blue-and-red-crossed devicetree property
  drm/tilcdc: Choose console BPP that supports RGB
  ARM: dts: am335x-boneblack: Add blue-and-red-wiring -property to LCDC
    node
  ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc node
  ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodes
  ARM: dts: am335x-evmsk: Add blue-and-red-wiring -property to lcdc node

 .../devicetree/bindings/display/tilcdc/tilcdc.txt  | 22 ++++++++
 arch/arm/boot/dts/am335x-boneblack.dts             | 11 ++++
 arch/arm/boot/dts/am335x-evm.dts                   |  2 +
 arch/arm/boot/dts/am335x-evmsk.dts                 | 42 ++++++++--------
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c               |  9 +++-
 drivers/gpu/drm/tilcdc/tilcdc_drv.c                | 58 ++++++++++++++++++----
 drivers/gpu/drm/tilcdc/tilcdc_drv.h                |  5 +-
 drivers/gpu/drm/tilcdc/tilcdc_external.c           |  7 ++-
 drivers/gpu/drm/tilcdc/tilcdc_external.h           |  2 +-
 drivers/gpu/drm/tilcdc/tilcdc_panel.c              |  2 -
 drivers/gpu/drm/tilcdc/tilcdc_plane.c              |  9 ++--
 drivers/gpu/drm/tilcdc/tilcdc_regs.h               | 14 ++++++
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c             |  2 -
 13 files changed, 136 insertions(+), 49 deletions(-)

-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2016-08-31 13:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 13:14 Jyri Sarha [this message]
2016-08-31 13:14 ` [PATCH v3 1/8] drm/tilcdc: Remove drm_helper_disable_unused_functions() call Jyri Sarha
2016-08-31 13:14 ` [PATCH v3 2/8] drm/tilcdc: Write DMA base and ceiling address with single instruction Jyri Sarha
2016-09-01  7:13   ` Tomi Valkeinen
2016-09-01  7:18     ` Jyri Sarha
2016-08-31 13:14 ` [PATCH v3 3/8] drm/tilcdc: Add blue-and-red-crossed devicetree property Jyri Sarha
2016-09-01  7:19   ` Tomi Valkeinen
2016-08-31 13:14 ` [PATCH v3 4/8] drm/tilcdc: Choose console BPP that supports RGB Jyri Sarha
2016-08-31 13:14 ` [PATCH v3 5/8] ARM: dts: am335x-boneblack: Add blue-and-red-wiring -property to LCDC node Jyri Sarha
2016-08-31 13:14 ` [PATCH v3 6/8] ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc node Jyri Sarha
2016-08-31 13:14 ` [PATCH v3 7/8] ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodes Jyri Sarha
2016-08-31 13:14 ` [PATCH v3 8/8] ARM: dts: am335x-evmsk: Add blue-and-red-wiring -property to lcdc node Jyri Sarha
     [not found] ` <cover.1472634657.git.jsarha-l0cyMroinI0@public.gmane.org>
2016-08-31 18:04   ` [PATCH v3 0/8] drm/tilcdc: Address LCDC rev 2 color errata + other fixes Tony Lindgren
2016-08-31 18:48     ` Jyri Sarha
     [not found]       ` <c049825a-0802-0637-3b1e-5290032e6d10-l0cyMroinI0@public.gmane.org>
2016-08-31 19:44         ` Tony Lindgren
2016-09-01  7:24 ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1472634657.git.jsarha@ti.com \
    --to=jsarha@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kbeldan@baylibre.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).