[PATCH 0/3] ARM: dts: omap5 uevm: add LEDs, USR1 button and EEPROM

[PATCH 0/3] ARM: dts: omap5 uevm: add LEDs, USR1 button and EEPROM

[H. Nikolaus Schaller]

These patches configure
* the EEPROM
* the LEDs (with some default triggers)
* the USR1 gpio button
for the OMAP5 UEVM board.

H. Nikolaus Schaller (3):
  DT: EVM: add EEPROM
  DT: EVM: add LEDs
  DT: EVM: add USR1 button

 arch/arm/boot/dts/omap5-uevm.dts | 92 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)

-- 
2.7.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] DT: EVM: add EEPROM

[H. Nikolaus Schaller]

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap5-uevm.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 36ff7c3..be659e8 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -23,6 +23,13 @@
 	vdda-supply = <&ldo4_reg>;
 };
 
+&i2c1 {
+	eeprom@50 {
+		compatible = "atmel,24c02";
+		reg = <0x50>;
+	};
+};
+
 &i2c5 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c5_pins>;
-- 
2.7.3

[PATCH 2/3] DT: EVM: add LEDs

[H. Nikolaus Schaller]

Signed-off-by: H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
---
 arch/arm/boot/dts/omap5-uevm.dts | 60 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index be659e8..19f5f0a 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -17,6 +17,66 @@
 		device_type = "memory";
 		reg = <0x80000000 0x7F000000>; /* 2032 MB */
 	};
+
+	evm_leds {
+		compatible = "gpio-leds";
+
+		led@1 {
+			label = "omap5:red:led";
+			gpios = <&gpio9 17 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "mmc0";
+			default-state = "off";
+		};
+
+		led@2 {
+			label = "omap5:green:led";
+			gpios = <&gpio9 18 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "mmc1";
+			default-state = "off";
+		};
+
+		led@3 {
+			label = "omap5:blue:led";
+			gpios = <&gpio9 19 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "mmc2";
+			default-state = "off";
+		};
+
+		led@4 {
+			label = "omap5:green:led1";
+			gpios = <&gpio9 2 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-on";
+			default-state = "off";
+		};
+
+		led@5 {
+			label = "omap5:green:led2";
+			gpios = <&gpio9 3 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-on";
+			default-state = "off";
+		};
+
+		led@6 {
+			label = "omap5:green:led3";
+			gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+			default-state = "off";
+		};
+
+		led@7 {
+			label = "omap5:green:led4";
+			gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+			default-state = "off";
+		};
+
+		led@8 {
+			label = "omap5:green:led5";
+			gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+			default-state = "off";
+		};
+	};
 };
 
 &hdmi {
-- 
2.7.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] DT: EVM: add LEDs

[Tony Lindgren]

* H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> [160926 22:27]:
> +		led@6 {
> +			label = "omap5:green:led3";
> +			gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +			default-state = "off";
> +		};
> +
> +		led@7 {
> +			label = "omap5:green:led4";
> +			gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +			default-state = "off";
> +		};
> +
> +		led@8 {
> +			label = "omap5:green:led5";
> +			gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +			default-state = "off";
> +		};

How about this for defaults:

- heartbeat for led3
- cpu0 for led4
- cpu1 for led5

Or something along those lines that by default shows the
active CPUs. Don't have a omap5-uevm near by right now so
not sure about the ordering of the LEDs for displaying
cpu0 and cpu1.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] DT: EVM: add LEDs

[H. Nikolaus Schaller]

Hi Tony,

> Am 27.09.2016 um 21:49 schrieb Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>:
> 
> * H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> [160926 22:27]:
>> +		led@6 {
>> +			label = "omap5:green:led3";
>> +			gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "heartbeat";
>> +			default-state = "off";
>> +		};
>> +
>> +		led@7 {
>> +			label = "omap5:green:led4";
>> +			gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "heartbeat";
>> +			default-state = "off";
>> +		};
>> +
>> +		led@8 {
>> +			label = "omap5:green:led5";
>> +			gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "heartbeat";
>> +			default-state = "off";
>> +		};
> 
> How about this for defaults:
> 
> - heartbeat for led3
> - cpu0 for led4
> - cpu1 for led5

Good idea. Will try.

What I don't exactly know is if these gpios based on an I2C-expander
can handle cpu activity triggers or if they are locked up if this i2c
processing triggers another cpu activity...

> 
> Or something along those lines that by default shows the
> active CPUs. Don't have a omap5-uevm near by right now so
> not sure about the ordering of the LEDs for displaying
> cpu0 and cpu1.

Will test tomorrow and if it works I can submit a v2.

BR and thanks,
Nikolaus
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] DT: EVM: add LEDs

[Tony Lindgren]

* H. Nikolaus Schaller <hns@goldelico.com> [160927 13:11]:
> > Am 27.09.2016 um 21:49 schrieb Tony Lindgren <tony@atomide.com>:
> > How about this for defaults:
> > 
> > - heartbeat for led3
> > - cpu0 for led4
> > - cpu1 for led5
> 
> Good idea. Will try.
> 
> What I don't exactly know is if these gpios based on an I2C-expander
> can handle cpu activity triggers or if they are locked up if this i2c
> processing triggers another cpu activity...

Oh right, if the GPIOs are on the i2c bus it's probably not a good
idea :) Or at least will be inaccurate if the bus can sleep.

Regards,

Tony

Re: [PATCH 2/3] DT: EVM: add LEDs

[H. Nikolaus Schaller]

Hi,

> Am 28.09.2016 um 05:37 schrieb Tony Lindgren <tony@atomide.com>:
> 
> * H. Nikolaus Schaller <hns@goldelico.com> [160927 13:11]:
>>> Am 27.09.2016 um 21:49 schrieb Tony Lindgren <tony@atomide.com>:
>>> How about this for defaults:
>>> 
>>> - heartbeat for led3
>>> - cpu0 for led4
>>> - cpu1 for led5
>> 
>> Good idea. Will try.
>> 
>> What I don't exactly know is if these gpios based on an I2C-expander
>> can handle cpu activity triggers or if they are locked up if this i2c
>> processing triggers another cpu activity...
> 
> Oh right, if the GPIOs are on the i2c bus

yes, they are all gpio9 which is the tca6424 on i2c5.

> it's probably not a good
> idea :) Or at least will be inaccurate if the bus can sleep.

I have tested a little by writing to /sys/class/leds/.../trigger.

If I make one LED trigger by "cpu0" it is always on and if I make
a second one triggered by "cpu1" the heartbeat becomes irregular.

So indeed this does not work.

BR,
Nikolaus

Re: [PATCH 2/3] DT: EVM: add LEDs

[Tony Lindgren]

* H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> [160927 23:50]:
> Hi,
> 
> > Am 28.09.2016 um 05:37 schrieb Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>:
> > 
> > * H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> [160927 13:11]:
> >>> Am 27.09.2016 um 21:49 schrieb Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>:
> >>> How about this for defaults:
> >>> 
> >>> - heartbeat for led3
> >>> - cpu0 for led4
> >>> - cpu1 for led5
> >> 
> >> Good idea. Will try.
> >> 
> >> What I don't exactly know is if these gpios based on an I2C-expander
> >> can handle cpu activity triggers or if they are locked up if this i2c
> >> processing triggers another cpu activity...
> > 
> > Oh right, if the GPIOs are on the i2c bus
> 
> yes, they are all gpio9 which is the tca6424 on i2c5.
> 
> > it's probably not a good
> > idea :) Or at least will be inaccurate if the bus can sleep.
> 
> I have tested a little by writing to /sys/class/leds/.../trigger.
> 
> If I make one LED trigger by "cpu0" it is always on and if I make
> a second one triggered by "cpu1" the heartbeat becomes irregular.
> 
> So indeed this does not work.

So should we just leave the default trigger unpopulated then?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] DT: EVM: add LEDs

[H. Nikolaus Schaller]

> Am 28.09.2016 um 17:12 schrieb Tony Lindgren <tony@atomide.com>:
> 
> * H. Nikolaus Schaller <hns@goldelico.com> [160927 23:50]:
>> Hi,
>> 
>>> Am 28.09.2016 um 05:37 schrieb Tony Lindgren <tony@atomide.com>:
>>> 
>>> * H. Nikolaus Schaller <hns@goldelico.com> [160927 13:11]:
>>>>> Am 27.09.2016 um 21:49 schrieb Tony Lindgren <tony@atomide.com>:
>>>>> How about this for defaults:
>>>>> 
>>>>> - heartbeat for led3
>>>>> - cpu0 for led4
>>>>> - cpu1 for led5
>>>> 
>>>> Good idea. Will try.
>>>> 
>>>> What I don't exactly know is if these gpios based on an I2C-expander
>>>> can handle cpu activity triggers or if they are locked up if this i2c
>>>> processing triggers another cpu activity...
>>> 
>>> Oh right, if the GPIOs are on the i2c bus
>> 
>> yes, they are all gpio9 which is the tca6424 on i2c5.
>> 
>>> it's probably not a good
>>> idea :) Or at least will be inaccurate if the bus can sleep.
>> 
>> I have tested a little by writing to /sys/class/leds/.../trigger.
>> 
>> If I make one LED trigger by "cpu0" it is always on and if I make
>> a second one triggered by "cpu1" the heartbeat becomes irregular.
>> 
>> So indeed this does not work.
> 
> So should we just leave the default trigger unpopulated then?

It is a matter of taste and something not easy to decide...

And everything can be changed from user-space by some script
running during the boot process to a more meaningful setting.

So the initial setting doesn't matter really much.

Having some of the LEDs as heartbeat gives an (additional)
feedback that the kernel has booted.

We could even take led1, led3 and led5 as heartbeat and the other
two as default-on. Would give a nice pattern showing that the LEDs
are not broken...

So let me know how you would like to have it and I add it to a PATCH v2.

BR and thanks,
Nikolaus

Re: [PATCH 2/3] DT: EVM: add LEDs

[Tony Lindgren]

* H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> [160928 08:29]:
> 
> > Am 28.09.2016 um 17:12 schrieb Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>:
> > 
> > * H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> [160927 23:50]:
> >> Hi,
> >> 
> >>> Am 28.09.2016 um 05:37 schrieb Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>:
> >>> 
> >>> * H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> [160927 13:11]:
> >>>>> Am 27.09.2016 um 21:49 schrieb Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>:
> >>>>> How about this for defaults:
> >>>>> 
> >>>>> - heartbeat for led3
> >>>>> - cpu0 for led4
> >>>>> - cpu1 for led5
> >>>> 
> >>>> Good idea. Will try.
> >>>> 
> >>>> What I don't exactly know is if these gpios based on an I2C-expander
> >>>> can handle cpu activity triggers or if they are locked up if this i2c
> >>>> processing triggers another cpu activity...
> >>> 
> >>> Oh right, if the GPIOs are on the i2c bus
> >> 
> >> yes, they are all gpio9 which is the tca6424 on i2c5.
> >> 
> >>> it's probably not a good
> >>> idea :) Or at least will be inaccurate if the bus can sleep.
> >> 
> >> I have tested a little by writing to /sys/class/leds/.../trigger.
> >> 
> >> If I make one LED trigger by "cpu0" it is always on and if I make
> >> a second one triggered by "cpu1" the heartbeat becomes irregular.
> >> 
> >> So indeed this does not work.
> > 
> > So should we just leave the default trigger unpopulated then?
> 
> It is a matter of taste and something not easy to decide...
> 
> And everything can be changed from user-space by some script
> running during the boot process to a more meaningful setting.
> 
> So the initial setting doesn't matter really much.
> 
> Having some of the LEDs as heartbeat gives an (additional)
> feedback that the kernel has booted.
> 
> We could even take led1, led3 and led5 as heartbeat and the other
> two as default-on. Would give a nice pattern showing that the LEDs
> are not broken...
> 
> So let me know how you would like to have it and I add it to a PATCH v2.

Up to you for the blinking, I'm fine with the original version
too unless you feel like changing it.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] DT: EVM: add LEDs

[Rob Herring]

On Tue, Sep 27, 2016 at 12:26 AM, H. Nikolaus Schaller
<hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> wrote:

The subject gives no indication this is for OMAP. Please follow
standard patterns.

> Signed-off-by: H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
> ---
>  arch/arm/boot/dts/omap5-uevm.dts | 60 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index be659e8..19f5f0a 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -17,6 +17,66 @@
>                 device_type = "memory";
>                 reg = <0x80000000 0x7F000000>; /* 2032 MB */
>         };
> +
> +       evm_leds {
> +               compatible = "gpio-leds";
> +
> +               led@1 {

Drop the unit address. There's no reg property.

> +                       label = "omap5:red:led";
> +                       gpios = <&gpio9 17 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "mmc0";
> +                       default-state = "off";
> +               };
> +
> +               led@2 {
> +                       label = "omap5:green:led";
> +                       gpios = <&gpio9 18 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "mmc1";
> +                       default-state = "off";
> +               };
> +
> +               led@3 {
> +                       label = "omap5:blue:led";
> +                       gpios = <&gpio9 19 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "mmc2";
> +                       default-state = "off";
> +               };
> +
> +               led@4 {
> +                       label = "omap5:green:led1";
> +                       gpios = <&gpio9 2 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "default-on";
> +                       default-state = "off";
> +               };
> +
> +               led@5 {
> +                       label = "omap5:green:led2";
> +                       gpios = <&gpio9 3 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "default-on";
> +                       default-state = "off";
> +               };
> +
> +               led@6 {
> +                       label = "omap5:green:led3";
> +                       gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "heartbeat";
> +                       default-state = "off";
> +               };
> +
> +               led@7 {
> +                       label = "omap5:green:led4";
> +                       gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "heartbeat";
> +                       default-state = "off";
> +               };
> +
> +               led@8 {
> +                       label = "omap5:green:led5";
> +                       gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
> +                       linux,default-trigger = "heartbeat";
> +                       default-state = "off";
> +               };
> +       };
>  };
>
>  &hdmi {
> --
> 2.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] DT: EVM: add LEDs

[H. Nikolaus Schaller]

> Am 29.09.2016 um 07:14 schrieb Rob Herring <robh+dt@kernel.org>:
> 
> On Tue, Sep 27, 2016 at 12:26 AM, H. Nikolaus Schaller
> <hns@goldelico.com> wrote:
> 
> The subject gives no indication this is for OMAP. Please follow
> standard patterns.

Already fixed. Please see v2.

> 
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> arch/arm/boot/dts/omap5-uevm.dts | 60 ++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 60 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
>> index be659e8..19f5f0a 100644
>> --- a/arch/arm/boot/dts/omap5-uevm.dts
>> +++ b/arch/arm/boot/dts/omap5-uevm.dts
>> @@ -17,6 +17,66 @@
>>                device_type = "memory";
>>                reg = <0x80000000 0x7F000000>; /* 2032 MB */
>>        };
>> +
>> +       evm_leds {
>> +               compatible = "gpio-leds";
>> +
>> +               led@1 {
> 
> Drop the unit address. There's no reg property.
> 
>> +                       label = "omap5:red:led";
>> +                       gpios = <&gpio9 17 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "mmc0";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@2 {
>> +                       label = "omap5:green:led";
>> +                       gpios = <&gpio9 18 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "mmc1";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@3 {
>> +                       label = "omap5:blue:led";
>> +                       gpios = <&gpio9 19 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "mmc2";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@4 {
>> +                       label = "omap5:green:led1";
>> +                       gpios = <&gpio9 2 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "default-on";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@5 {
>> +                       label = "omap5:green:led2";
>> +                       gpios = <&gpio9 3 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "default-on";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@6 {
>> +                       label = "omap5:green:led3";
>> +                       gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "heartbeat";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@7 {
>> +                       label = "omap5:green:led4";
>> +                       gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "heartbeat";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@8 {
>> +                       label = "omap5:green:led5";
>> +                       gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "heartbeat";
>> +                       default-state = "off";
>> +               };
>> +       };
>> };
>> 
>> &hdmi {
>> --
>> 2.7.3
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] DT: EVM: add LEDs

[H. Nikolaus Schaller]

> Am 29.09.2016 um 07:14 schrieb Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
> 
> On Tue, Sep 27, 2016 at 12:26 AM, H. Nikolaus Schaller
> <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> wrote:
> 
> The subject gives no indication this is for OMAP. Please follow
> standard patterns.
> 
>> Signed-off-by: H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
>> ---
>> arch/arm/boot/dts/omap5-uevm.dts | 60 ++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 60 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
>> index be659e8..19f5f0a 100644
>> --- a/arch/arm/boot/dts/omap5-uevm.dts
>> +++ b/arch/arm/boot/dts/omap5-uevm.dts
>> @@ -17,6 +17,66 @@
>>                device_type = "memory";
>>                reg = <0x80000000 0x7F000000>; /* 2032 MB */
>>        };
>> +
>> +       evm_leds {
>> +               compatible = "gpio-leds";
>> +
>> +               led@1 {
> 
> Drop the unit address. There's no reg property.

This needs to be fixed. Goes to v3.

BR and thanks,
Nikolaus

> 
>> +                       label = "omap5:red:led";
>> +                       gpios = <&gpio9 17 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "mmc0";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@2 {
>> +                       label = "omap5:green:led";
>> +                       gpios = <&gpio9 18 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "mmc1";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@3 {
>> +                       label = "omap5:blue:led";
>> +                       gpios = <&gpio9 19 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "mmc2";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@4 {
>> +                       label = "omap5:green:led1";
>> +                       gpios = <&gpio9 2 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "default-on";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@5 {
>> +                       label = "omap5:green:led2";
>> +                       gpios = <&gpio9 3 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "default-on";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@6 {
>> +                       label = "omap5:green:led3";
>> +                       gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "heartbeat";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@7 {
>> +                       label = "omap5:green:led4";
>> +                       gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "heartbeat";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@8 {
>> +                       label = "omap5:green:led5";
>> +                       gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "heartbeat";
>> +                       default-state = "off";
>> +               };
>> +       };
>> };
>> 
>> &hdmi {
>> --
>> 2.7.3
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] DT: EVM: add USR1 button

[H. Nikolaus Schaller]

Signed-off-by: H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
---
 arch/arm/boot/dts/omap5-uevm.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 19f5f0a..1b919f5 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -18,6 +18,25 @@
 		reg = <0x80000000 0x7F000000>; /* 2032 MB */
 	};
 
+	evm_keys {
+		compatible = "gpio-keys";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&evm_keys_pins>;
+
+		#address-cells = <7>;
+		#size-cells = <0>;
+
+		btn1 {
+			label = "BTN1";
+			linux,code = <169>;
+			gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;	/* gpio3_83 */
+			gpio-key,wakeup;
+			autorepeat;
+			debounce_interval = <50>;
+		};
+	};
+
 	evm_leds {
 		compatible = "gpio-leds";
 
@@ -105,6 +124,12 @@
 };
 
 &omap5_pmx_core {
+	evm_keys_pins: pinmux_evm_keys_gpio_pins {
+		pinctrl-single,pins = <
+			OMAP5_IOPAD(0x0b6, PIN_INPUT | MUX_MODE6)	/* gpio3_83 */
+		>;
+	};
+
 	i2c5_pins: pinmux_i2c5_pins {
 		pinctrl-single,pins = <
 			OMAP5_IOPAD(0x1c6, PIN_INPUT | MUX_MODE0)		/* i2c5_scl */
-- 
2.7.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html