From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Jonathan Cameron <jic23@kernel.org>,
sre@kernel.org
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org
Subject: [PATCH 0/3] Fix tsc2007 to report ABS_PRESSURE correctly
Date: Mon, 20 Feb 2017 17:56:33 +0100 [thread overview]
Message-ID: <cover.1487609795.git.hns@goldelico.com> (raw)
tsc2007 reports the touch resistance as ABS_PRESSURE, which jumps
to its maximum for light touch and goes down for increasing pressure.
This is not consistent with other touch drivers and not what one would
expect.
Additionally the name of the function tsc2007_calculate_pressure()
is misleading since the formula calculates an estimate for the touch
screen resistance. So it is renamed without changing the function.
While this patch changes the values reported to userspace,
ABS_PRESSURE is used rarely by userspace. Most software only
relies on BTN_TOUCH (boolean), which is not affected by this
patch. Some graphics software makes use of the interface and
does not work correctly with the currently used inverted
behaviour.
Note: this patch series assumes to be merged after
"Input: tsc2007 - add iio interface to read external ADC input and temperature"
because that one renames tsc2007.c to tsc2007_core.c
H. Nikolaus Schaller (3):
Input: tsc2007 - rename function tsc2007_calculate_pressure to
tsc2007_calculate_resistance because that is what it does
Input: tsc2007 - correctly report pressure and not resistance to user
space
Input: tsc2007 - add a property "ti,report-resistance" to restore the
old pressure reporting state if needed.
.../devicetree/bindings/input/touchscreen/tsc2007.txt | 2 ++
drivers/input/touchscreen/tsc2007.h | 1 +
drivers/input/touchscreen/tsc2007_core.c | 14 ++++++++++----
3 files changed, 13 insertions(+), 4 deletions(-)
--
2.7.3
next reply other threads:[~2017-02-20 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 16:56 H. Nikolaus Schaller [this message]
2017-02-20 16:56 ` [PATCH 1/3] Input: tsc2007 - rename function tsc2007_calculate_pressure to tsc2007_calculate_resistance because that is what it does H. Nikolaus Schaller
2017-02-23 8:45 ` Dmitry Torokhov
[not found] ` <cover.1487609795.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-20 16:56 ` [PATCH 2/3] Input: tsc2007 - correctly report pressure and not resistance to user space H. Nikolaus Schaller
[not found] ` <9e249276be9e20aab1a74617373bf6587f1acd4b.1487609795.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-21 17:13 ` Sebastian Reichel
2017-02-23 8:45 ` Dmitry Torokhov
2017-02-20 16:56 ` [PATCH 3/3] Input: tsc2007 - add a property "ti,report-resistance" to restore the old pressure reporting state if needed H. Nikolaus Schaller
2017-02-21 11:07 ` Pavel Machek
2017-02-21 11:43 ` H. Nikolaus Schaller
2017-02-21 17:19 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1487609795.git.hns@goldelico.com \
--to=hns@goldelico.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).