[PATCH 0/9] Ata ceva patches

[PATCH 0/9] Ata ceva patches

[Michal Simek]

Hi,

this patchset contains the latest changes which are available in Xilinx tree.

Thanks,
Michal


Anurag Kumar Vulisha (9):
  devicetree: bindings: Add sata port phy config parameters in ahci-ceva
  ata: ceva: Move sata port phy oob settings to device-tree
  ata: ceva: Add gen 3 mode support in driver
  ata: ceva: Disable Device Sleep capability
  ata: ceva: Make RxWaterMark value as module parameter
  ata: ceva: Add CCI support for SATA if CCI is enabled
  ata: ceva: Correct the AXI bus configuration for SATA ports
  ata: ceva: Correct the suspend and resume logic for SATA
  ata: ceva: Add SMMU support for SATA IP

 .../devicetree/bindings/ata/ahci-ceva.txt          |  39 ++++
 drivers/ata/ahci_ceva.c                            | 197 +++++++++++++++++----
 2 files changed, 198 insertions(+), 38 deletions(-)

-- 
1.9.1

[PATCH 1/9] devicetree: bindings: Add sata port phy config parameters in ahci-ceva

[Michal Simek]

From: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>

This patch adds device tree bindings for sata port phy parameters
in the ahci-ceva.txt file.

Signed-off-by: Anurag Kumar Vulisha <anuragku@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 .../devicetree/bindings/ata/ahci-ceva.txt          | 39 ++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
index 7ca8b976c13a..f97546f61444 100644
--- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
+++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
@@ -5,6 +5,36 @@ Required properties:
   - compatible: Compatibility string. Must be 'ceva,ahci-1v84'.
   - clocks: Input clock specifier. Refer to common clock bindings.
   - interrupts: Interrupt specifier. Refer to interrupt binding.
+  - ceva,p0-cominit-params: OOB timing value for COMINIT parameter for port 0.
+  - ceva,p1-cominit-params: OOB timing value for COMINIT parameter for port 1.
+			The fields for the above parameter must be as shown below:
+			ceva,phy-cominit-params = /bits/ 8 <CIBGMN CIBGMX CIBGN CINMP>;
+			CINMP : COMINIT Negate Minimum Period.
+			CIBGN : COMINIT Burst Gap Nominal.
+			CIBGMX: COMINIT Burst Gap Maximum.
+			CIBGMN: COMINIT Burst Gap Minimum.
+  - ceva,p0-comwake-params: OOB timing value for COMWAKE parameter for port 0.
+  - ceva,p1-comwake-params: OOB timing value for COMWAKE parameter for port 1.
+			The fields for the above parameter must be as shown below:
+			ceva,phy-comwake-params = /bits/ 8 <CWBGMN CWBGMX CWBGN CWNMP>;
+			CWBGMN: COMWAKE Burst Gap Minimum.
+			CWBGMX: COMWAKE Burst Gap Maximum.
+			CWBGN: COMWAKE Burst Gap Nominal.
+			CWNMP: COMWAKE Negate Minimum Period.
+  - ceva,p0-burst-params: Burst timing value for COM parameter for port 0.
+  - ceva,p1-burst-params: Burst timing value for COM parameter for port 1.
+			The fields for the above parameter must be as shown below:
+			ceva,phy-burst-params = /bits/ 8 <BMX BNM SFD PTST>;
+			BMX: COM Burst Maximum.
+			BNM: COM Burst Nominal.
+			SFD: Signal Failure Detection value.
+			PTST: Partial to Slumber timer value.
+  - ceva,p0-retry-params: Retry interval timing value for port 0.
+  - ceva,p1-retry-params: Retry interval timing value for port 1.
+			The fields for the above parameter must be as shown below:
+			ceva,phy-retry-params = /bits/ 16 <RIT RCT>;
+			RIT:  Retry Interval Timer.
+			RCT:  Rate Change Timer.
 
 Optional properties:
   - ceva,broken-gen2: limit to gen1 speed instead of gen2.
@@ -16,5 +46,14 @@ Examples:
 		interrupt-parent = <&gic>;
 		interrupts = <0 133 4>;
 		clocks = <&clkc SATA_CLK_ID>;
+		ceva,p0-cominit-params = /bits/ 8 <0x0F 0x25 0x18 0x29>;
+		ceva,p0-comwake-params = /bits/ 8 <0x04 0x0B 0x08 0x0F>;
+		ceva,p0-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>;
+		ceva,p0-retry-params = /bits/ 16 <0x0216 0x7F06>;
+
+		ceva,p1-cominit-params = /bits/ 8 <0x0F 0x25 0x18 0x29>;
+		ceva,p1-comwake-params = /bits/ 8 <0x04 0x0B 0x08 0x0F>;
+		ceva,p1-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>;
+		ceva,p1-retry-params = /bits/ 16 <0x0216 0x7F06>;
 		ceva,broken-gen2;
 	};
-- 
1.9.1

Re: [PATCH 1/9] devicetree: bindings: Add sata port phy config parameters in ahci-ceva

[Rob Herring]

On Fri, Aug 04, 2017 at 03:18:10PM +0200, Michal Simek wrote:
> From: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
> 
> This patch adds device tree bindings for sata port phy parameters
> in the ahci-ceva.txt file.
> 
> Signed-off-by: Anurag Kumar Vulisha <anuragku@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  .../devicetree/bindings/ata/ahci-ceva.txt          | 39 ++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> index 7ca8b976c13a..f97546f61444 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> @@ -5,6 +5,36 @@ Required properties:
>    - compatible: Compatibility string. Must be 'ceva,ahci-1v84'.
>    - clocks: Input clock specifier. Refer to common clock bindings.
>    - interrupts: Interrupt specifier. Refer to interrupt binding.
> +  - ceva,p0-cominit-params: OOB timing value for COMINIT parameter for port 0.
> +  - ceva,p1-cominit-params: OOB timing value for COMINIT parameter for port 1.
> +			The fields for the above parameter must be as shown below:
> +			ceva,phy-cominit-params = /bits/ 8 <CIBGMN CIBGMX CIBGN CINMP>;

phy? Should be pN?

> +			CINMP : COMINIT Negate Minimum Period.
> +			CIBGN : COMINIT Burst Gap Nominal.
> +			CIBGMX: COMINIT Burst Gap Maximum.
> +			CIBGMN: COMINIT Burst Gap Minimum.
> +  - ceva,p0-comwake-params: OOB timing value for COMWAKE parameter for port 0.
> +  - ceva,p1-comwake-params: OOB timing value for COMWAKE parameter for port 1.
> +			The fields for the above parameter must be as shown below:
> +			ceva,phy-comwake-params = /bits/ 8 <CWBGMN CWBGMX CWBGN CWNMP>;
> +			CWBGMN: COMWAKE Burst Gap Minimum.
> +			CWBGMX: COMWAKE Burst Gap Maximum.
> +			CWBGN: COMWAKE Burst Gap Nominal.
> +			CWNMP: COMWAKE Negate Minimum Period.
> +  - ceva,p0-burst-params: Burst timing value for COM parameter for port 0.
> +  - ceva,p1-burst-params: Burst timing value for COM parameter for port 1.
> +			The fields for the above parameter must be as shown below:
> +			ceva,phy-burst-params = /bits/ 8 <BMX BNM SFD PTST>;
> +			BMX: COM Burst Maximum.
> +			BNM: COM Burst Nominal.
> +			SFD: Signal Failure Detection value.
> +			PTST: Partial to Slumber timer value.
> +  - ceva,p0-retry-params: Retry interval timing value for port 0.
> +  - ceva,p1-retry-params: Retry interval timing value for port 1.
> +			The fields for the above parameter must be as shown below:
> +			ceva,phy-retry-params = /bits/ 16 <RIT RCT>;
> +			RIT:  Retry Interval Timer.
> +			RCT:  Rate Change Timer.
>  
>  Optional properties:
>    - ceva,broken-gen2: limit to gen1 speed instead of gen2.
> @@ -16,5 +46,14 @@ Examples:
>  		interrupt-parent = <&gic>;
>  		interrupts = <0 133 4>;
>  		clocks = <&clkc SATA_CLK_ID>;
> +		ceva,p0-cominit-params = /bits/ 8 <0x0F 0x25 0x18 0x29>;
> +		ceva,p0-comwake-params = /bits/ 8 <0x04 0x0B 0x08 0x0F>;
> +		ceva,p0-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>;
> +		ceva,p0-retry-params = /bits/ 16 <0x0216 0x7F06>;
> +
> +		ceva,p1-cominit-params = /bits/ 8 <0x0F 0x25 0x18 0x29>;
> +		ceva,p1-comwake-params = /bits/ 8 <0x04 0x0B 0x08 0x0F>;
> +		ceva,p1-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>;
> +		ceva,p1-retry-params = /bits/ 16 <0x0216 0x7F06>;
>  		ceva,broken-gen2;
>  	};
> -- 
> 1.9.1
> 

Re: [PATCH 1/9] devicetree: bindings: Add sata port phy config parameters in ahci-ceva

[Michal Simek]

On 10.8.2017 21:07, Rob Herring wrote:
> On Fri, Aug 04, 2017 at 03:18:10PM +0200, Michal Simek wrote:
>> From: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
>>
>> This patch adds device tree bindings for sata port phy parameters
>> in the ahci-ceva.txt file.
>>
>> Signed-off-by: Anurag Kumar Vulisha <anuragku@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  .../devicetree/bindings/ata/ahci-ceva.txt          | 39 ++++++++++++++++++++++
>>  1 file changed, 39 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
>> index 7ca8b976c13a..f97546f61444 100644
>> --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
>> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
>> @@ -5,6 +5,36 @@ Required properties:
>>    - compatible: Compatibility string. Must be 'ceva,ahci-1v84'.
>>    - clocks: Input clock specifier. Refer to common clock bindings.
>>    - interrupts: Interrupt specifier. Refer to interrupt binding.
>> +  - ceva,p0-cominit-params: OOB timing value for COMINIT parameter for port 0.
>> +  - ceva,p1-cominit-params: OOB timing value for COMINIT parameter for port 1.
>> +			The fields for the above parameter must be as shown below:
>> +			ceva,phy-cominit-params = /bits/ 8 <CIBGMN CIBGMX CIBGN CINMP>;
> 
> phy? Should be pN?

pN will be in v2.

Thanks,
Michal