[PATCH v2 0/4] arm64: defconfig: enable additional led triggers

[PATCH v2 0/4] arm64: defconfig: enable additional led triggers

[Amit Kucheria]

This patchset enables the kernel panic and disk-activity trigger for LEDs
and then enables the panic trigger for three 96Boards - DB410c, Hikey and
Hikey960.

DB410c and Hikey panic behaviour has been tested by triggering a panic
through /proc/sysrq-trigger, while Hikey960 is only compile-tested.


Amit Kucheria (4):
  arm64: defconfig: enable new trigger modes for leds
  arm64: dts: qcom: apq8016-sbc: Allow USR4 LED to notify kernel panic
  arm64: dts: hisilicon: hi6220-hikey: Allow USR1 LED to notify kernel
    panic
  arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify
    kernel panic

 arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 +
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts    | 1 +
 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi         | 1 +
 arch/arm64/configs/defconfig                      | 2 ++
 4 files changed, 5 insertions(+)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/4] arm64: defconfig: enable new trigger modes for leds

[Amit Kucheria]

Most development boards and devices have one or more LEDs. It is useful
during debugging if they can be wired to show different behaviours such as
disk or cpu activity or a load-average dependent heartbeat. Enable panic
and disk activity triggers so they can be tied to LED activity during
debugging as well.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 34480e9..4ed357f 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -460,6 +460,8 @@ CONFIG_LEDS_SYSCON=y
 CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_LEDS_TRIGGER_CPU=y
 CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
+CONFIG_LEDS_TRIGGER_PANIC=y
+CONFIG_LEDS_TRIGGER_DISK=y
 CONFIG_EDAC=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
-- 
2.7.4

[PATCH v2 2/4] arm64: dts: qcom: apq8016-sbc: Allow USR4 LED to notify kernel panic

[Amit Kucheria]

Blink the LED on a kernel panic.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 1d63e6b..e4a6850 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -174,6 +174,7 @@
 				label = "apq8016-sbc:green:user4";
 				gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
 				linux,default-trigger = "none";
+				panic-indicator;
 				default-state = "off";
 			};
 
-- 
2.7.4

[PATCH v2 3/4] arm64: dts: hisilicon: hi6220-hikey: Allow USR1 LED to notify kernel panic

[Amit Kucheria]

Blink the LED on a kernel panic.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Acked-by: Guodong Xu <guodong.xu@linaro.org>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index 3aee612..e94fa1a 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -359,6 +359,7 @@
 		user_led1 {
 			label = "user_led1";
 			gpios = <&gpio4 3 0>; /* <&gpio_user_led_4>; */
+			panic-indicator;
 			linux,default-trigger = "cpu0";
 		};
 
-- 
2.7.4

[PATCH v2 4/4] arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify kernel panic

[Amit Kucheria]

Blink the LED on a kernel panic.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Acked-by: Guodong Xu <guodong.xu@linaro.org>
Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index e9f87cb..1cf77ee 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -109,6 +109,7 @@
 			label = "user_led4";
 			/* gpio_190_user_led4 */
 			gpios = <&gpio23 6 0>;
+			panic-indicator;
 			linux,default-trigger = "cpu0";
 		};
 
-- 
2.7.4

Re: [PATCH v2 0/4] arm64: defconfig: enable additional led triggers

[Amit Kucheria]

(Adding Arnd)

Now that the merge window rush has abated, can you please apply this
trivial series?

On Mon, Nov 6, 2017 at 12:38 PM, Amit Kucheria <amit.kucheria@linaro.org> wrote:
> This patchset enables the kernel panic and disk-activity trigger for LEDs
> and then enables the panic trigger for three 96Boards - DB410c, Hikey and
> Hikey960.
>
> DB410c and Hikey panic behaviour has been tested by triggering a panic
> through /proc/sysrq-trigger, while Hikey960 is only compile-tested.
>
>
> Amit Kucheria (4):
>   arm64: defconfig: enable new trigger modes for leds
>   arm64: dts: qcom: apq8016-sbc: Allow USR4 LED to notify kernel panic
>   arm64: dts: hisilicon: hi6220-hikey: Allow USR1 LED to notify kernel
>     panic
>   arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify
>     kernel panic
>
>  arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 +
>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts    | 1 +
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi         | 1 +
>  arch/arm64/configs/defconfig                      | 2 ++
>  4 files changed, 5 insertions(+)
>
> --
> 2.7.4
>

Re: [PATCH v2 0/4] arm64: defconfig: enable additional led triggers

[Arnd Bergmann]

On Wed, Dec 6, 2017 at 9:57 AM, Amit Kucheria <amit.kucheria-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> (Adding Arnd)
>
> Now that the merge window rush has abated, can you please apply this
> trivial series?
>
> On Mon, Nov 6, 2017 at 12:38 PM, Amit Kucheria <amit.kucheria-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> This patchset enables the kernel panic and disk-activity trigger for LEDs
>> and then enables the panic trigger for three 96Boards - DB410c, Hikey and
>> Hikey960.
>>
>> DB410c and Hikey panic behaviour has been tested by triggering a panic
>> through /proc/sysrq-trigger, while Hikey960 is only compile-tested.

I applied all four now, but it would have been easier for me if you had either
sent them to the platform maintainers, or to arm-DgEjT+Ai2yi4UlQgPVntAg@public.gmane.org

      Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/4] arm64: defconfig: enable additional led triggers

[Amit Kucheria]

On Thu, Dec 21, 2017 at 8:46 PM, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> On Wed, Dec 6, 2017 at 9:57 AM, Amit Kucheria <amit.kucheria-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> (Adding Arnd)
>>
>> Now that the merge window rush has abated, can you please apply this
>> trivial series?
>>
>> On Mon, Nov 6, 2017 at 12:38 PM, Amit Kucheria <amit.kucheria-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>>> This patchset enables the kernel panic and disk-activity trigger for LEDs
>>> and then enables the panic trigger for three 96Boards - DB410c, Hikey and
>>> Hikey960.
>>>
>>> DB410c and Hikey panic behaviour has been tested by triggering a panic
>>> through /proc/sysrq-trigger, while Hikey960 is only compile-tested.
>
> I applied all four now, but it would have been easier for me if you had either
> sent them to the platform maintainers, or to arm-DgEjT+Ai2yi4UlQgPVntAg@public.gmane.org

The platform maintainers are cc'ed but I guess nobody took them since
the patchset touched 3 different platforms and a common defconfig.

I'll remember to cc arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org in the future but is there any
reason why this email address isn't listed in MAINTAINERS?

Thanks for applying the patches.

Wish you a Happy New Year.

Regards,
Amit
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/4] arm64: defconfig: enable additional led triggers

[Arnd Bergmann]

On Tue, Jan 2, 2018 at 8:19 AM, Amit Kucheria <amit.kucheria-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On Thu, Dec 21, 2017 at 8:46 PM, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
>> On Wed, Dec 6, 2017 at 9:57 AM, Amit Kucheria <amit.kucheria-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>>> (Adding Arnd)
>>>
>>> Now that the merge window rush has abated, can you please apply this
>>> trivial series?
>>>
>>> On Mon, Nov 6, 2017 at 12:38 PM, Amit Kucheria <amit.kucheria-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>>>> This patchset enables the kernel panic and disk-activity trigger for LEDs
>>>> and then enables the panic trigger for three 96Boards - DB410c, Hikey and
>>>> Hikey960.
>>>>
>>>> DB410c and Hikey panic behaviour has been tested by triggering a panic
>>>> through /proc/sysrq-trigger, while Hikey960 is only compile-tested.
>>
>> I applied all four now, but it would have been easier for me if you had either
>> sent them to the platform maintainers, or to arm-DgEjT+Ai2yi4UlQgPVntAg@public.gmane.org
>
> The platform maintainers are cc'ed but I guess nobody took them since
> the patchset touched 3 different platforms and a common defconfig.
>
> I'll remember to cc arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org in the future but is there any
> reason why this email address isn't listed in MAINTAINERS?

We normally want to have all patches merged through the platform
maintainers, and have no ambiguity regarding who picks things up.
More importantly, being listed in the MAINTAINERS file would result
in us getting thousands of patches each merge window mixed in with
the stuff that we actually do need to see, so that would likely be more
lossy and more work for us.

      Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html