* [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support
@ 2019-08-27 12:13 Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
` (8 more replies)
0 siblings, 9 replies; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:13 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: devicetree, linux-pm
Changes since v1:
- Collected reviews and acks
- Addressed Stephen's review comments (hopefully I got them all).
- Completely removed critical interrupt infrastructure from this series.
Will post that separately.
- Fixed a bug in sign-extension of temperature.
- Fixed DT bindings to use the name of the interrupt e.g. "uplow" and use
platform_get_irq_byname().
Add interrupt support to TSENS. The first 6 patches are general fixes and
cleanups to the driver before interrupt support is introduced.
This series has been developed against qcs404 and sdm845 and then tested on
msm8916 and msm8974 (Thanks Brian). Testing on msm8998 would be appreciated since I don't
have hardware handy.
Amit Kucheria (15):
drivers: thermal: tsens: Get rid of id field in tsens_sensor
drivers: thermal: tsens: Simplify code flow in tsens_probe
drivers: thermal: tsens: Add __func__ identifier to debug statements
drivers: thermal: tsens: Add debugfs support
arm: dts: msm8974: thermal: Add thermal zones for each sensor
arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors
dt: thermal: tsens: Document interrupt support in tsens driver
arm64: dts: sdm845: thermal: Add interrupt support
arm64: dts: msm8996: thermal: Add interrupt support
arm64: dts: msm8998: thermal: Add interrupt support
arm64: dts: qcs404: thermal: Add interrupt support
arm: dts: msm8974: thermal: Add interrupt support
arm64: dts: msm8916: thermal: Add interrupt support
drivers: thermal: tsens: Create function to return sign-extended
temperature
drivers: thermal: tsens: Add interrupt support
.../bindings/thermal/qcom-tsens.txt | 8 +
arch/arm/boot/dts/qcom-msm8974.dtsi | 108 +++-
arch/arm64/boot/dts/qcom/msm8916.dtsi | 26 +-
arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 +-
arch/arm64/boot/dts/qcom/msm8998.dtsi | 82 +--
arch/arm64/boot/dts/qcom/qcs404.dtsi | 42 +-
arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 +--
drivers/thermal/qcom/tsens-8960.c | 4 +-
drivers/thermal/qcom/tsens-common.c | 528 ++++++++++++++++--
drivers/thermal/qcom/tsens-v0_1.c | 11 +
drivers/thermal/qcom/tsens-v1.c | 29 +
drivers/thermal/qcom/tsens-v2.c | 13 +
drivers/thermal/qcom/tsens.c | 59 +-
drivers/thermal/qcom/tsens.h | 288 ++++++++--
14 files changed, 1089 insertions(+), 257 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v2 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
@ 2019-08-27 12:14 ` Amit Kucheria
2019-08-28 0:32 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
` (7 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: devicetree
msm8974 has 11 sensors connected to a single TSENS IP. Define a thermal
zone for each of those sensors to expose the temperature of each zone.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Tested-by: Brian Masney <masneyb@onstation.org>
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 90 +++++++++++++++++++++++++++++
1 file changed, 90 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 369e58f64145d..d32f639505f1b 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -217,6 +217,96 @@
};
};
};
+
+ q6-dsp-thermal {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+
+ thermal-sensors = <&tsens 1>;
+
+ trips {
+ q6_dsp_alert0: trip-point0 {
+ temperature = <90000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+ };
+
+ modemtx-thermal {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+
+ thermal-sensors = <&tsens 2>;
+
+ trips {
+ modemtx_alert0: trip-point0 {
+ temperature = <90000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+ };
+
+ video-thermal {
+ polling-delay-passive = <0>;
+ polling-delay = <1000>;
+
+ thermal-sensors = <&tsens 3>;
+
+ trips {
+ video_alert0: trip-point0 {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+ };
+
+ wlan-thermal {
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
+
+ thermal-sensors = <&tsens 4>;
+
+ trips {
+ wlan_alert0: trip-point0 {
+ temperature = <105000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+ };
+
+ gpu-thermal-top {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+
+ thermal-sensors = <&tsens 9>;
+
+ trips {
+ gpu1_alert0: trip-point0 {
+ temperature = <90000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+ };
+
+ gpu-thermal-bottom {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+
+ thermal-sensors = <&tsens 10>;
+
+ trips {
+ gpu2_alert0: trip-point0 {
+ temperature = <90000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+ };
};
cpu-pmu {
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
@ 2019-08-27 12:14 ` Amit Kucheria
2019-08-28 0:32 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver Amit Kucheria
` (6 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: devicetree
msm8916 uses sensors 0, 1, 2, 4 and 5. Sensor 3 is NOT used. Fixup the
device tree so that the correct sensor ID is used and as a result we can
actually check the temperature for the cpu2_3 sensor.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 5ea9fb8f2f87d..8686e101905cc 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -179,7 +179,7 @@
polling-delay-passive = <250>;
polling-delay = <1000>;
- thermal-sensors = <&tsens 4>;
+ thermal-sensors = <&tsens 5>;
trips {
cpu0_1_alert0: trip-point@0 {
@@ -209,7 +209,7 @@
polling-delay-passive = <250>;
polling-delay = <1000>;
- thermal-sensors = <&tsens 3>;
+ thermal-sensors = <&tsens 4>;
trips {
cpu2_3_alert0: trip-point@0 {
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
@ 2019-08-27 12:14 ` Amit Kucheria
2019-08-28 0:33 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
` (5 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: linux-pm, devicetree
Define two new required properties to define interrupts and
interrupt-names for tsens.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
index 673cc1831ee9d..686bede72f846 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
@@ -22,6 +22,8 @@ Required properties:
- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
- #qcom,sensors: Number of sensors in tsens block
+- interrupts: Interrupts generated from Always-On subsystem (AOSS)
+- interrupt-names: Must be one of the following: "uplow", "critical"
- Refer to Documentation/devicetree/bindings/nvmem/nvmem.txt to know how to specify
nvmem cells
@@ -40,6 +42,9 @@ tsens0: thermal-sensor@c263000 {
reg = <0xc263000 0x1ff>, /* TM */
<0xc222000 0x1ff>; /* SROT */
#qcom,sensors = <13>;
+ interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
+
#thermal-sensor-cells = <1>;
};
@@ -51,5 +56,8 @@ tsens: thermal-sensor@4a9000 {
nvmem-cells = <&tsens_caldata>;
nvmem-cell-names = "calib";
#qcom,sensors = <10>;
+ interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
+
#thermal-sensor-cells = <1>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 08/15] arm64: dts: sdm845: thermal: Add interrupt support
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
` (2 preceding siblings ...)
2019-08-27 12:14 ` [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver Amit Kucheria
@ 2019-08-27 12:14 ` Amit Kucheria
2019-08-28 0:34 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 09/15] arm64: dts: msm8996: " Amit Kucheria
` (4 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: devicetree
Register upper-lower interrupts for each of the two tsens controllers.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 +++++++++++++++-------------
1 file changed, 46 insertions(+), 42 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 4babff5f19b5c..fdd74c39b744e 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2386,6 +2386,8 @@
reg = <0 0x0c263000 0 0x1ff>, /* TM */
<0 0x0c222000 0 0x1ff>; /* SROT */
#qcom,sensors = <13>;
+ interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
@@ -2394,6 +2396,8 @@
reg = <0 0x0c265000 0 0x1ff>, /* TM */
<0 0x0c223000 0 0x1ff>; /* SROT */
#qcom,sensors = <8>;
+ interrupts = <GIC_SPI 507 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
@@ -2712,8 +2716,8 @@
thermal-zones {
cpu0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 1>;
@@ -2756,8 +2760,8 @@
};
cpu1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 2>;
@@ -2800,8 +2804,8 @@
};
cpu2-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 3>;
@@ -2844,8 +2848,8 @@
};
cpu3-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 4>;
@@ -2888,8 +2892,8 @@
};
cpu4-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 7>;
@@ -2932,8 +2936,8 @@
};
cpu5-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 8>;
@@ -2976,8 +2980,8 @@
};
cpu6-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 9>;
@@ -3020,8 +3024,8 @@
};
cpu7-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 10>;
@@ -3064,8 +3068,8 @@
};
aoss0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 0>;
@@ -3079,8 +3083,8 @@
};
cluster0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 5>;
@@ -3099,8 +3103,8 @@
};
cluster1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 6>;
@@ -3119,8 +3123,8 @@
};
gpu-thermal-top {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 11>;
@@ -3134,8 +3138,8 @@
};
gpu-thermal-bottom {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 12>;
@@ -3149,8 +3153,8 @@
};
aoss1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 0>;
@@ -3164,8 +3168,8 @@
};
q6-modem-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 1>;
@@ -3179,8 +3183,8 @@
};
mem-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 2>;
@@ -3194,8 +3198,8 @@
};
wlan-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 3>;
@@ -3209,8 +3213,8 @@
};
q6-hvx-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 4>;
@@ -3224,8 +3228,8 @@
};
camera-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 5>;
@@ -3239,8 +3243,8 @@
};
video-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 6>;
@@ -3254,8 +3258,8 @@
};
modem-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 7>;
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 09/15] arm64: dts: msm8996: thermal: Add interrupt support
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
` (3 preceding siblings ...)
2019-08-27 12:14 ` [PATCH v2 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
@ 2019-08-27 12:14 ` Amit Kucheria
2019-08-28 0:35 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 10/15] arm64: dts: msm8998: " Amit Kucheria
` (3 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: devicetree
Register upper-lower interrupts for each of the two tsens controllers.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++-------------
1 file changed, 32 insertions(+), 28 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 96c0a481f454e..bb763b362c162 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -175,8 +175,8 @@
thermal-zones {
cpu0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 3>;
@@ -196,8 +196,8 @@
};
cpu1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 5>;
@@ -217,8 +217,8 @@
};
cpu2-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 8>;
@@ -238,8 +238,8 @@
};
cpu3-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 10>;
@@ -259,8 +259,8 @@
};
gpu-thermal-top {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 6>;
@@ -274,8 +274,8 @@
};
gpu-thermal-bottom {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 7>;
@@ -289,8 +289,8 @@
};
m4m-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 1>;
@@ -304,8 +304,8 @@
};
l3-or-venus-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 2>;
@@ -319,8 +319,8 @@
};
cluster0-l2-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 7>;
@@ -334,8 +334,8 @@
};
cluster1-l2-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 12>;
@@ -349,8 +349,8 @@
};
camera-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 1>;
@@ -364,8 +364,8 @@
};
q6-dsp-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 2>;
@@ -379,8 +379,8 @@
};
mem-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 3>;
@@ -394,8 +394,8 @@
};
modemtx-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 4>;
@@ -591,6 +591,8 @@
reg = <0x4a9000 0x1000>, /* TM */
<0x4a8000 0x1000>; /* SROT */
#qcom,sensors = <13>;
+ interrupts = <GIC_SPI 458 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
@@ -599,6 +601,8 @@
reg = <0x4ad000 0x1000>, /* TM */
<0x4ac000 0x1000>; /* SROT */
#qcom,sensors = <8>;
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 10/15] arm64: dts: msm8998: thermal: Add interrupt support
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
` (4 preceding siblings ...)
2019-08-27 12:14 ` [PATCH v2 09/15] arm64: dts: msm8996: " Amit Kucheria
@ 2019-08-27 12:14 ` Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 11/15] arm64: dts: qcs404: " Amit Kucheria
` (2 subsequent siblings)
8 siblings, 0 replies; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: devicetree
Register upper-lower interrupts for each of the two tsens controllers.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8998.dtsi | 82 ++++++++++++++-------------
1 file changed, 42 insertions(+), 40 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index c13ed7aeb1e0c..1e2f77b38f2c1 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -440,8 +440,8 @@
thermal-zones {
cpu0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 1>;
@@ -461,8 +461,8 @@
};
cpu1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 2>;
@@ -482,8 +482,8 @@
};
cpu2-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 3>;
@@ -503,8 +503,8 @@
};
cpu3-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 4>;
@@ -524,8 +524,8 @@
};
cpu4-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 7>;
@@ -545,8 +545,8 @@
};
cpu5-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 8>;
@@ -566,8 +566,8 @@
};
cpu6-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 9>;
@@ -587,8 +587,8 @@
};
cpu7-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 10>;
@@ -608,8 +608,8 @@
};
gpu-thermal-bottom {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 12>;
@@ -623,8 +623,8 @@
};
gpu-thermal-top {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 13>;
@@ -638,8 +638,8 @@
};
clust0-mhm-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 5>;
@@ -653,8 +653,8 @@
};
clust1-mhm-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 6>;
@@ -668,8 +668,8 @@
};
cluster1-l2-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 11>;
@@ -683,8 +683,8 @@
};
modem-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 1>;
@@ -698,8 +698,8 @@
};
mem-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 2>;
@@ -713,8 +713,8 @@
};
wlan-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 3>;
@@ -728,8 +728,8 @@
};
q6-dsp-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 4>;
@@ -743,8 +743,8 @@
};
camera-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 5>;
@@ -758,8 +758,8 @@
};
multimedia-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 6>;
@@ -845,8 +845,9 @@
compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
reg = <0x10ab000 0x1000>, /* TM */
<0x10aa000 0x1000>; /* SROT */
-
#qcom,sensors = <14>;
+ interrupts = <GIC_SPI 458 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
@@ -854,8 +855,9 @@
compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
reg = <0x10ae000 0x1000>, /* TM */
<0x10ad000 0x1000>; /* SROT */
-
#qcom,sensors = <8>;
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 11/15] arm64: dts: qcs404: thermal: Add interrupt support
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
` (5 preceding siblings ...)
2019-08-27 12:14 ` [PATCH v2 10/15] arm64: dts: msm8998: " Amit Kucheria
@ 2019-08-27 12:14 ` Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 12/15] arm: dts: msm8974: " Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 13/15] arm64: dts: msm8916: " Amit Kucheria
8 siblings, 0 replies; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: devicetree
Register upper-lower interrupt for the tsens controller.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 42 +++++++++++++++-------------
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index 3d0789775009c..065a60d50a07f 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -280,6 +280,8 @@
nvmem-cells = <&tsens_caldata>;
nvmem-cell-names = "calib";
#qcom,sensors = <10>;
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
@@ -1071,8 +1073,8 @@
thermal-zones {
aoss-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 0>;
@@ -1086,8 +1088,8 @@
};
q6-hvx-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 1>;
@@ -1101,8 +1103,8 @@
};
lpass-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 2>;
@@ -1116,8 +1118,8 @@
};
wlan-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 3>;
@@ -1131,8 +1133,8 @@
};
cluster-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 4>;
@@ -1165,8 +1167,8 @@
};
cpu0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 5>;
@@ -1199,8 +1201,8 @@
};
cpu1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 6>;
@@ -1233,8 +1235,8 @@
};
cpu2-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 7>;
@@ -1267,8 +1269,8 @@
};
cpu3-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 8>;
@@ -1301,8 +1303,8 @@
};
gpu-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 9>;
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 12/15] arm: dts: msm8974: thermal: Add interrupt support
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
` (6 preceding siblings ...)
2019-08-27 12:14 ` [PATCH v2 11/15] arm64: dts: qcs404: " Amit Kucheria
@ 2019-08-27 12:14 ` Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 13/15] arm64: dts: msm8916: " Amit Kucheria
8 siblings, 0 replies; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: devicetree
Register upper-lower interrupt for the tsens controller.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Tested-by: Brian Masney <masneyb@onstation.org>
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 36 +++++++++++++++--------------
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index d32f639505f1b..290f7c3827d45 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -139,8 +139,8 @@
thermal-zones {
cpu-thermal0 {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 5>;
@@ -159,8 +159,8 @@
};
cpu-thermal1 {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 6>;
@@ -179,8 +179,8 @@
};
cpu-thermal2 {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 7>;
@@ -199,8 +199,8 @@
};
cpu-thermal3 {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 8>;
@@ -219,8 +219,8 @@
};
q6-dsp-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 1>;
@@ -234,8 +234,8 @@
};
modemtx-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 2>;
@@ -250,7 +250,7 @@
video-thermal {
polling-delay-passive = <0>;
- polling-delay = <1000>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 3>;
@@ -279,8 +279,8 @@
};
gpu-thermal-top {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 9>;
@@ -294,8 +294,8 @@
};
gpu-thermal-bottom {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 10>;
@@ -531,6 +531,8 @@
nvmem-cells = <&tsens_calib>, <&tsens_backup>;
nvmem-cell-names = "calib", "calib_backup";
#qcom,sensors = <11>;
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 13/15] arm64: dts: msm8916: thermal: Add interrupt support
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
` (7 preceding siblings ...)
2019-08-27 12:14 ` [PATCH v2 12/15] arm: dts: msm8974: " Amit Kucheria
@ 2019-08-27 12:14 ` Amit Kucheria
8 siblings, 0 replies; 22+ messages in thread
From: Amit Kucheria @ 2019-08-27 12:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, bjorn.andersson, edubezval, agross,
sboyd, masneyb, marc.w.gonzalez, Daniel Lezcano, Mark Rutland,
Rob Herring, Zhang Rui
Cc: devicetree
Register upper-lower interrupt for the tsens controller.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 8686e101905cc..c0d0492d90ec0 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -176,8 +176,8 @@
thermal-zones {
cpu0_1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 5>;
@@ -206,8 +206,8 @@
};
cpu2_3-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 4>;
@@ -236,8 +236,8 @@
};
gpu-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 2>;
@@ -256,8 +256,8 @@
};
camera-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 1>;
@@ -271,8 +271,8 @@
};
modem-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens 0>;
@@ -816,6 +816,8 @@
nvmem-cells = <&tsens_caldata>, <&tsens_calsel>;
nvmem-cell-names = "calib", "calib_sel";
#qcom,sensors = <5>;
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v2 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor
2019-08-27 12:14 ` [PATCH v2 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
@ 2019-08-28 0:32 ` Stephen Boyd
0 siblings, 0 replies; 22+ messages in thread
From: Stephen Boyd @ 2019-08-28 0:32 UTC (permalink / raw)
To: Amit Kucheria, Daniel Lezcano, Mark Rutland, Rob Herring,
Zhang Rui, agross, bjorn.andersson, edubezval, linux-arm-msm,
linux-kernel, marc.w.gonzalez, masneyb
Cc: devicetree
Quoting Amit Kucheria (2019-08-27 05:14:01)
> msm8974 has 11 sensors connected to a single TSENS IP. Define a thermal
> zone for each of those sensors to expose the temperature of each zone.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> Tested-by: Brian Masney <masneyb@onstation.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors
2019-08-27 12:14 ` [PATCH v2 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
@ 2019-08-28 0:32 ` Stephen Boyd
0 siblings, 0 replies; 22+ messages in thread
From: Stephen Boyd @ 2019-08-28 0:32 UTC (permalink / raw)
To: Amit Kucheria, Daniel Lezcano, Mark Rutland, Rob Herring,
Zhang Rui, agross, bjorn.andersson, edubezval, linux-arm-msm,
linux-kernel, marc.w.gonzalez, masneyb
Cc: devicetree
Quoting Amit Kucheria (2019-08-27 05:14:02)
> msm8916 uses sensors 0, 1, 2, 4 and 5. Sensor 3 is NOT used. Fixup the
> device tree so that the correct sensor ID is used and as a result we can
> actually check the temperature for the cpu2_3 sensor.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver
2019-08-27 12:14 ` [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver Amit Kucheria
@ 2019-08-28 0:33 ` Stephen Boyd
2019-08-29 8:48 ` Amit Kucheria
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Boyd @ 2019-08-28 0:33 UTC (permalink / raw)
To: Amit Kucheria, Daniel Lezcano, Mark Rutland, Rob Herring,
Zhang Rui, agross, bjorn.andersson, edubezval, linux-arm-msm,
linux-kernel, marc.w.gonzalez, masneyb
Cc: linux-pm, devicetree
Quoting Amit Kucheria (2019-08-27 05:14:03)
> Define two new required properties to define interrupts and
> interrupt-names for tsens.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> index 673cc1831ee9d..686bede72f846 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> @@ -22,6 +22,8 @@ Required properties:
>
> - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
> - #qcom,sensors: Number of sensors in tsens block
> +- interrupts: Interrupts generated from Always-On subsystem (AOSS)
Is it always one? interrupt-names makes it sound like it.
> +- interrupt-names: Must be one of the following: "uplow", "critical"
> - Refer to Documentation/devicetree/bindings/nvmem/nvmem.txt to know how to specify
> nvmem cells
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 08/15] arm64: dts: sdm845: thermal: Add interrupt support
2019-08-27 12:14 ` [PATCH v2 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
@ 2019-08-28 0:34 ` Stephen Boyd
0 siblings, 0 replies; 22+ messages in thread
From: Stephen Boyd @ 2019-08-28 0:34 UTC (permalink / raw)
To: Amit Kucheria, Daniel Lezcano, Mark Rutland, Rob Herring,
Zhang Rui, agross, bjorn.andersson, edubezval, linux-arm-msm,
linux-kernel, marc.w.gonzalez, masneyb
Cc: devicetree
Quoting Amit Kucheria (2019-08-27 05:14:04)
> Register upper-lower interrupts for each of the two tsens controllers.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 09/15] arm64: dts: msm8996: thermal: Add interrupt support
2019-08-27 12:14 ` [PATCH v2 09/15] arm64: dts: msm8996: " Amit Kucheria
@ 2019-08-28 0:35 ` Stephen Boyd
2019-08-30 20:10 ` Amit Kucheria
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Boyd @ 2019-08-28 0:35 UTC (permalink / raw)
To: Amit Kucheria, Daniel Lezcano, Mark Rutland, Rob Herring,
Zhang Rui, agross, bjorn.andersson, edubezval, linux-arm-msm,
linux-kernel, marc.w.gonzalez, masneyb
Cc: devicetree
Quoting Amit Kucheria (2019-08-27 05:14:05)
> Register upper-lower interrupts for each of the two tsens controllers.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++-------------
> 1 file changed, 32 insertions(+), 28 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 96c0a481f454e..bb763b362c162 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -175,8 +175,8 @@
>
> thermal-zones {
> cpu0-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
Is it really necessary to change the configuration here to be 0 instead
of some number? Why can't we detect that there's an interrupt and then
ignore these properties?
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver
2019-08-28 0:33 ` Stephen Boyd
@ 2019-08-29 8:48 ` Amit Kucheria
2019-08-29 14:53 ` Stephen Boyd
0 siblings, 1 reply; 22+ messages in thread
From: Amit Kucheria @ 2019-08-29 8:48 UTC (permalink / raw)
To: Stephen Boyd
Cc: Daniel Lezcano, Mark Rutland, Rob Herring, Zhang Rui, Andy Gross,
Bjorn Andersson, Eduardo Valentin, linux-arm-msm,
Linux Kernel Mailing List, Marc Gonzalez, Brian Masney,
Linux PM list, DTML
On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Amit Kucheria (2019-08-27 05:14:03)
> > Define two new required properties to define interrupts and
> > interrupt-names for tsens.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > ---
> > Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > index 673cc1831ee9d..686bede72f846 100644
> > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > @@ -22,6 +22,8 @@ Required properties:
> >
> > - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
> > - #qcom,sensors: Number of sensors in tsens block
> > +- interrupts: Interrupts generated from Always-On subsystem (AOSS)
>
> Is it always one? interrupt-names makes it sound like it.
>
> > +- interrupt-names: Must be one of the following: "uplow", "critical"
Will fix to "one or more of the following"
> > - Refer to Documentation/devicetree/bindings/nvmem/nvmem.txt to know how to specify
> > nvmem cells
> >
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver
2019-08-29 8:48 ` Amit Kucheria
@ 2019-08-29 14:53 ` Stephen Boyd
2019-08-29 16:34 ` Amit Kucheria
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Boyd @ 2019-08-29 14:53 UTC (permalink / raw)
To: Amit Kucheria
Cc: Daniel Lezcano, Mark Rutland, Rob Herring, Zhang Rui, Andy Gross,
Bjorn Andersson, Eduardo Valentin, linux-arm-msm,
Linux Kernel Mailing List, Marc Gonzalez, Brian Masney,
Linux PM list, DTML
Quoting Amit Kucheria (2019-08-29 01:48:27)
> On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > Quoting Amit Kucheria (2019-08-27 05:14:03)
> > > Define two new required properties to define interrupts and
> > > interrupt-names for tsens.
> > >
> > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > > ---
> > > Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > index 673cc1831ee9d..686bede72f846 100644
> > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > @@ -22,6 +22,8 @@ Required properties:
> > >
> > > - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
> > > - #qcom,sensors: Number of sensors in tsens block
> > > +- interrupts: Interrupts generated from Always-On subsystem (AOSS)
> >
> > Is it always one? interrupt-names makes it sound like it.
> >
> > > +- interrupt-names: Must be one of the following: "uplow", "critical"
>
> Will fix to "one or more of the following"
>
Can we get a known quantity of interrupts for a particular compatible
string instead? Let's be as specific as possible. The index matters too,
so please list them in the order that is desired.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver
2019-08-29 14:53 ` Stephen Boyd
@ 2019-08-29 16:34 ` Amit Kucheria
2019-08-30 11:32 ` Amit Kucheria
0 siblings, 1 reply; 22+ messages in thread
From: Amit Kucheria @ 2019-08-29 16:34 UTC (permalink / raw)
To: Stephen Boyd
Cc: Daniel Lezcano, Mark Rutland, Rob Herring, Zhang Rui, Andy Gross,
Bjorn Andersson, Eduardo Valentin, linux-arm-msm,
Linux Kernel Mailing List, Marc Gonzalez, Brian Masney,
Linux PM list, DTML
On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Amit Kucheria (2019-08-29 01:48:27)
> > On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > Quoting Amit Kucheria (2019-08-27 05:14:03)
> > > > Define two new required properties to define interrupts and
> > > > interrupt-names for tsens.
> > > >
> > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > > > ---
> > > > Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > > index 673cc1831ee9d..686bede72f846 100644
> > > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > > @@ -22,6 +22,8 @@ Required properties:
> > > >
> > > > - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
> > > > - #qcom,sensors: Number of sensors in tsens block
> > > > +- interrupts: Interrupts generated from Always-On subsystem (AOSS)
> > >
> > > Is it always one? interrupt-names makes it sound like it.
> > >
> > > > +- interrupt-names: Must be one of the following: "uplow", "critical"
> >
> > Will fix to "one or more of the following"
> >
>
> Can we get a known quantity of interrupts for a particular compatible
> string instead? Let's be as specific as possible. The index matters too,
> so please list them in the order that is desired.
I *think* we can predict what platforms have uplow and critical
interrupts based on IP version currently[1]. For newer interrupt
types, we might need more fine-grained platform compatibles.
[1] Caveat: this is based only on the list of platforms I've currently
looked at, there might be something internally that breaks these
rules.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver
2019-08-29 16:34 ` Amit Kucheria
@ 2019-08-30 11:32 ` Amit Kucheria
2019-08-30 15:55 ` Stephen Boyd
0 siblings, 1 reply; 22+ messages in thread
From: Amit Kucheria @ 2019-08-30 11:32 UTC (permalink / raw)
To: Stephen Boyd
Cc: Daniel Lezcano, Mark Rutland, Rob Herring, Zhang Rui, Andy Gross,
Bjorn Andersson, Eduardo Valentin, linux-arm-msm,
Linux Kernel Mailing List, Marc Gonzalez, Brian Masney,
Linux PM list, DTML
On Thu, Aug 29, 2019 at 10:04 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
>
> On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > Quoting Amit Kucheria (2019-08-29 01:48:27)
> > > On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd <swboyd@chromium.org> wrote:
> > > >
> > > > Quoting Amit Kucheria (2019-08-27 05:14:03)
> > > > > Define two new required properties to define interrupts and
> > > > > interrupt-names for tsens.
> > > > >
> > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > > > > ---
> > > > > Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 ++++++++
> > > > > 1 file changed, 8 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > > > index 673cc1831ee9d..686bede72f846 100644
> > > > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > > > @@ -22,6 +22,8 @@ Required properties:
> > > > >
> > > > > - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
> > > > > - #qcom,sensors: Number of sensors in tsens block
> > > > > +- interrupts: Interrupts generated from Always-On subsystem (AOSS)
> > > >
> > > > Is it always one? interrupt-names makes it sound like it.
> > > >
> > > > > +- interrupt-names: Must be one of the following: "uplow", "critical"
> > >
> > > Will fix to "one or more of the following"
> > >
> >
> > Can we get a known quantity of interrupts for a particular compatible
> > string instead? Let's be as specific as possible. The index matters too,
> > so please list them in the order that is desired.
>
> I *think* we can predict what platforms have uplow and critical
> interrupts based on IP version currently[1]. For newer interrupt
> types, we might need more fine-grained platform compatibles.
>
> [1] Caveat: this is based only on the list of platforms I've currently
> looked at, there might be something internally that breaks these
> rules.
What do you think if we changed the wording to something like the following,
- interrupt-names: Must be one of the following depending on IP version:
For compatibles qcom,msm8916-tsens, qcom,msm8974-tsens,
qcom,qcs404-tsens, qcom,tsens-v1, use
interrupt-names = "uplow";
For compatibles qcom,msm8996-tsens, qcom,msm8998-tsens,
qcom,sdm845-tsens, qcom,tsens-v2, use
interrupt-names = "uplow", "critical";
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver
2019-08-30 11:32 ` Amit Kucheria
@ 2019-08-30 15:55 ` Stephen Boyd
2019-08-30 16:40 ` Amit Kucheria
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Boyd @ 2019-08-30 15:55 UTC (permalink / raw)
To: Amit Kucheria
Cc: Daniel Lezcano, Mark Rutland, Rob Herring, Zhang Rui, Andy Gross,
Bjorn Andersson, Eduardo Valentin, linux-arm-msm,
Linux Kernel Mailing List, Marc Gonzalez, Brian Masney,
Linux PM list, DTML
Quoting Amit Kucheria (2019-08-30 04:32:54)
> On Thu, Aug 29, 2019 at 10:04 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> >
> > On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > Can we get a known quantity of interrupts for a particular compatible
> > > string instead? Let's be as specific as possible. The index matters too,
> > > so please list them in the order that is desired.
> >
> > I *think* we can predict what platforms have uplow and critical
> > interrupts based on IP version currently[1]. For newer interrupt
> > types, we might need more fine-grained platform compatibles.
> >
> > [1] Caveat: this is based only on the list of platforms I've currently
> > looked at, there might be something internally that breaks these
> > rules.
>
> What do you think if we changed the wording to something like the following,
>
> - interrupt-names: Must be one of the following depending on IP version:
> For compatibles qcom,msm8916-tsens, qcom,msm8974-tsens,
> qcom,qcs404-tsens, qcom,tsens-v1, use
> interrupt-names = "uplow";
> For compatibles qcom,msm8996-tsens, qcom,msm8998-tsens,
> qcom,sdm845-tsens, qcom,tsens-v2, use
> interrupt-names = "uplow", "critical";
Ok. I would still prefer YAML/JSON schema for this binding so that it's
much more explicit about numbers and the order of interrupts, etc.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver
2019-08-30 15:55 ` Stephen Boyd
@ 2019-08-30 16:40 ` Amit Kucheria
0 siblings, 0 replies; 22+ messages in thread
From: Amit Kucheria @ 2019-08-30 16:40 UTC (permalink / raw)
To: Stephen Boyd
Cc: Daniel Lezcano, Mark Rutland, Rob Herring, Zhang Rui, Andy Gross,
Bjorn Andersson, Eduardo Valentin, linux-arm-msm,
Linux Kernel Mailing List, Marc Gonzalez, Brian Masney,
Linux PM list, DTML
On Fri, Aug 30, 2019 at 9:25 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Amit Kucheria (2019-08-30 04:32:54)
> > On Thu, Aug 29, 2019 at 10:04 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> > >
> > > On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > > >
> > > > Can we get a known quantity of interrupts for a particular compatible
> > > > string instead? Let's be as specific as possible. The index matters too,
> > > > so please list them in the order that is desired.
> > >
> > > I *think* we can predict what platforms have uplow and critical
> > > interrupts based on IP version currently[1]. For newer interrupt
> > > types, we might need more fine-grained platform compatibles.
> > >
> > > [1] Caveat: this is based only on the list of platforms I've currently
> > > looked at, there might be something internally that breaks these
> > > rules.
> >
> > What do you think if we changed the wording to something like the following,
> >
> > - interrupt-names: Must be one of the following depending on IP version:
> > For compatibles qcom,msm8916-tsens, qcom,msm8974-tsens,
> > qcom,qcs404-tsens, qcom,tsens-v1, use
> > interrupt-names = "uplow";
> > For compatibles qcom,msm8996-tsens, qcom,msm8998-tsens,
> > qcom,sdm845-tsens, qcom,tsens-v2, use
> > interrupt-names = "uplow", "critical";
>
> Ok. I would still prefer YAML/JSON schema for this binding so that it's
> much more explicit about numbers and the order of interrupts, etc.
OK, I'll look around for some examples.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 09/15] arm64: dts: msm8996: thermal: Add interrupt support
2019-08-28 0:35 ` Stephen Boyd
@ 2019-08-30 20:10 ` Amit Kucheria
0 siblings, 0 replies; 22+ messages in thread
From: Amit Kucheria @ 2019-08-30 20:10 UTC (permalink / raw)
To: Stephen Boyd
Cc: Daniel Lezcano, Mark Rutland, Rob Herring, Zhang Rui, Andy Gross,
Bjorn Andersson, Eduardo Valentin, linux-arm-msm,
Linux Kernel Mailing List, Marc Gonzalez, Brian Masney, DTML
On Wed, Aug 28, 2019 at 6:05 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Amit Kucheria (2019-08-27 05:14:05)
> > Register upper-lower interrupts for each of the two tsens controllers.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++++++++++++++-------------
> > 1 file changed, 32 insertions(+), 28 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > index 96c0a481f454e..bb763b362c162 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > @@ -175,8 +175,8 @@
> >
> > thermal-zones {
> > cpu0-thermal {
> > - polling-delay-passive = <250>;
> > - polling-delay = <1000>;
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
>
> Is it really necessary to change the configuration here to be 0 instead
> of some number? Why can't we detect that there's an interrupt and then
> ignore these properties?
AFAICT, the thermal core currently depends on the passive and
polling_delay being set to 0 to avoid setting dispatching polling work
to a workqueue. If we leave the values to set, we'll continue to poll
inspite of an interrupt. See
thermal_core.c:thermal_zone_device_set_polling()
But I agree, the core should detect the presence of an interrupt
property and ignore the polling intervals. I'll see if I can fix this
up later.
Regards,
Amit
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2019-08-30 20:10 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
2019-08-28 0:32 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
2019-08-28 0:32 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver Amit Kucheria
2019-08-28 0:33 ` Stephen Boyd
2019-08-29 8:48 ` Amit Kucheria
2019-08-29 14:53 ` Stephen Boyd
2019-08-29 16:34 ` Amit Kucheria
2019-08-30 11:32 ` Amit Kucheria
2019-08-30 15:55 ` Stephen Boyd
2019-08-30 16:40 ` Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
2019-08-28 0:34 ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 09/15] arm64: dts: msm8996: " Amit Kucheria
2019-08-28 0:35 ` Stephen Boyd
2019-08-30 20:10 ` Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 10/15] arm64: dts: msm8998: " Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 11/15] arm64: dts: qcs404: " Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 12/15] arm: dts: msm8974: " Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 13/15] arm64: dts: msm8916: " Amit Kucheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).