[PATCH 0/2] drm/panel: simple: Add support for Ampire AM-800480L1TMQW-T00H

[PATCH 0/2] drm/panel: simple: Add support for Ampire AM-800480L1TMQW-T00H

[Geert Uytterhoeven]

	Hi all,

This patch series adds support for the Ampire AM-800480L1TMQW-T00H 5"
WVGA TFT LCD panel, which can be found on e.g. the Atmark Techno
Armadillo-800-EVA development board.

It has been tested with a WIP DT-enhanced version of the shmob-drm
driver.

Thanks for your comments!

Geert Uytterhoeven (2):
  dt-bindings: display: panel-simple: Add Ampire AM-800480L1TMQW-T00H
  drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H

 .../bindings/display/panel/panel-simple.yaml  |  2 ++
 drivers/gpu/drm/panel/panel-simple.c          | 33 +++++++++++++++++++
 2 files changed, 35 insertions(+)

-- 
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/2] dt-bindings: display: panel-simple: Add Ampire AM-800480L1TMQW-T00H

[Geert Uytterhoeven]

Document support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD
panel.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 733e47da36e80896..f7c45e38d4b75b2e 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -33,6 +33,8 @@ properties:
       - ampire,am-1280800n3tzqw-t00h
         # Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
       - ampire,am-480272h3tmqw-t01h
+        # Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel
+      - ampire,am-800480l1tmqw-t00h
         # Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
       - ampire,am800480r3tmqwa1h
         # Ampire AM-800600P5TMQW-TB8H 8.0" SVGA TFT LCD panel
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: display: panel-simple: Add Ampire AM-800480L1TMQW-T00H

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

On Wed, May 24, 2023 at 02:32:10PM +0200, Geert Uytterhoeven wrote:
> Document support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD
> panel.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH 2/2] drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H

[Geert Uytterhoeven]

Add support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5778824dffd47a31..467117c0b2c9d463 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -778,6 +778,36 @@ static const struct drm_display_mode ampire_am800480r3tmqwa1h_mode = {
 	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
 };
 
+static const struct display_timing ampire_am_800480l1tmqw_t00h_timing = {
+	.pixelclock = { 29930000, 33260000, 36590000 },
+	.hactive = { 800, 800, 800 },
+	.hfront_porch = { 1, 40, 168 },
+	.hback_porch = { 88, 88, 88 },
+	.hsync_len = { 1, 128, 128 },
+	.vactive = { 480, 480, 480 },
+	.vfront_porch = { 1, 35, 37 },
+	.vback_porch = { 8, 8, 8 },
+	.vsync_len = { 1, 2, 2 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+		 DISPLAY_FLAGS_SYNC_POSEDGE,
+};
+
+static const struct panel_desc ampire_am_800480l1tmqw_t00h = {
+	.timings = &ampire_am_800480l1tmqw_t00h_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 111,
+		.height = 67,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
+		     DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
+		     DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
 static const struct panel_desc ampire_am800480r3tmqwa1h = {
 	.modes = &ampire_am800480r3tmqwa1h_mode,
 	.num_modes = 1,
@@ -3993,6 +4023,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "ampire,am-480272h3tmqw-t01h",
 		.data = &ampire_am_480272h3tmqw_t01h,
+	}, {
+		.compatible = "ampire,am-800480l1tmqw-t00h",
+		.data = &ampire_am_800480l1tmqw_t00h,
 	}, {
 		.compatible = "ampire,am800480r3tmqwa1h",
 		.data = &ampire_am800480r3tmqwa1h,
-- 
2.34.1

Re: [PATCH 2/2] drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H

[Neil Armstrong]

On 24/05/2023 14:32, Geert Uytterhoeven wrote:
> Add support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
>   1 file changed, 33 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 5778824dffd47a31..467117c0b2c9d463 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -778,6 +778,36 @@ static const struct drm_display_mode ampire_am800480r3tmqwa1h_mode = {
>   	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
>   };
>   
> +static const struct display_timing ampire_am_800480l1tmqw_t00h_timing = {
> +	.pixelclock = { 29930000, 33260000, 36590000 },
> +	.hactive = { 800, 800, 800 },
> +	.hfront_porch = { 1, 40, 168 },
> +	.hback_porch = { 88, 88, 88 },
> +	.hsync_len = { 1, 128, 128 },
> +	.vactive = { 480, 480, 480 },
> +	.vfront_porch = { 1, 35, 37 },
> +	.vback_porch = { 8, 8, 8 },
> +	.vsync_len = { 1, 2, 2 },
> +	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
> +		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
> +		 DISPLAY_FLAGS_SYNC_POSEDGE,
> +};
> +
> +static const struct panel_desc ampire_am_800480l1tmqw_t00h = {
> +	.timings = &ampire_am_800480l1tmqw_t00h_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 111,
> +		.height = 67,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
> +		     DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
> +		     DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
>   static const struct panel_desc ampire_am800480r3tmqwa1h = {
>   	.modes = &ampire_am800480r3tmqwa1h_mode,
>   	.num_modes = 1,
> @@ -3993,6 +4023,9 @@ static const struct of_device_id platform_of_match[] = {
>   	}, {
>   		.compatible = "ampire,am-480272h3tmqw-t01h",
>   		.data = &ampire_am_480272h3tmqw_t01h,
> +	}, {
> +		.compatible = "ampire,am-800480l1tmqw-t00h",
> +		.data = &ampire_am_800480l1tmqw_t00h,
>   	}, {
>   		.compatible = "ampire,am800480r3tmqwa1h",
>   		.data = &ampire_am800480r3tmqwa1h,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH 0/2] drm/panel: simple: Add support for Ampire AM-800480L1TMQW-T00H

[Neil Armstrong]

Hi,

On Wed, 24 May 2023 14:32:09 +0200, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> This patch series adds support for the Ampire AM-800480L1TMQW-T00H 5"
> WVGA TFT LCD panel, which can be found on e.g. the Atmark Techno
> Armadillo-800-EVA development board.
> 
> It has been tested with a WIP DT-enhanced version of the shmob-drm
> driver.
> 
> [...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/2] dt-bindings: display: panel-simple: Add Ampire AM-800480L1TMQW-T00H
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d3a6c2b60f07c64631b9437032d8f079341b7a16
[2/2] drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=410bb21319f69c2ec28aeafe530d00ed2f6a1c54

-- 
Neil