From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] Support ROHM BU27010 RGBC sensor
Date: Fri, 7 Jul 2023 14:22:14 +0300 [thread overview]
Message-ID: <cover.1688723839.git.mazziesaccount@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3008 bytes --]
Support ROHM BU27010 RGBC + flickering sensor.
Following description copied from commit log:
> The ROHM BU27010 is an RGBC sensor with a flickering detection FIFO. The
> RGBC+IR sensor functionality is largely similar to what the BU27008 has.
> There are some notable things though:
> - gain setting is once again new and exotic. Now, there is 6bit gain
> setting where 4 of the bits are common to all channels and 2 bits
> can be configured separately for each channel. The BU27010 has
> similar "1X on other channels vs 2X on IR when selector is 0x0"
> gain design as BU27008 had. So, we use same gain setting policy for
> BU27010 as we did for BU27008 - driver sets same gain selector for
> all channels but shows the gains separately for all channels so users
> can (at least in theory) detect this 1X vs 2X madness...
> - BU27010 has suffled all the control register bitfields to new
> addresses and bit positions while still keeping the register naming
> same.
> - Some more power/reset control is added.
> - FIFO for "flickering detection" is added.
>
> The control register suffling made this slightly nasty. Still, it is
> easier for maintenance perspective to add the BU27010 support in BU27008
> driver because - even though the bit positions/addresses were changed -
> most of the driver structure can be re-used. Writing own driver for
> BU27010 would mean plenty of duplicate code albeit a tad more clarity.
This series is done on top of the iio-for-6.5a + this fix-up series:
https://lore.kernel.org/all/cover.1686648422.git.mazziesaccount@gmail.com/
I didn't spot these fixups from iio git although I think I saw mail
stating they were applied.
Revision history:
v1 => v2:
- make vdd-supply required binding.
- Some re-ordering for struct member init.
- Some re-ordering for code to get rid of function declarations.
- Tidy up the mess from patch 2/3.
- Refactor parts from 3/3 to 2/3.
- Clean-up commented out code and tidy things in general.
Please note: I'll be mostly away from the computer during July. Please,
take your time reviewing and forgive me if sending follow-up revisions
is delayed.
---
Matti Vaittinen (3):
dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor
iio: light: bu27008: add chip info
iio: light: bd27008: Support BD27010 RGB
.../bindings/iio/light/rohm,bu27010.yaml | 49 ++
drivers/iio/light/rohm-bu27008.c | 622 ++++++++++++++----
2 files changed, 556 insertions(+), 115 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
--
2.40.1
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2023-07-07 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 11:22 Matti Vaittinen [this message]
2023-07-07 11:22 ` [PATCH v2 1/3] dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor Matti Vaittinen
2023-07-10 9:05 ` Krzysztof Kozlowski
2023-07-07 11:23 ` [PATCH v2 2/3] iio: light: bu27008: add chip info Matti Vaittinen
2023-07-08 16:16 ` Jonathan Cameron
2023-07-07 11:23 ` [PATCH v2 3/3] iio: light: bd27008: Support BD27010 RGB Matti Vaittinen
2023-07-08 16:21 ` Jonathan Cameron
2023-07-08 16:06 ` [PATCH v2 0/3] Support ROHM BU27010 RGBC sensor Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1688723839.git.mazziesaccount@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).