* [PATCH v2 0/4] arm64: dts: k3: Resolve remaining dtbs_check warnings
@ 2024-06-26 4:42 Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 1/4] arm64: dts: ti: k3-j72xx-mcu-wakeup: add dedicated wakeup controller compatible Jan Kiszka
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Jan Kiszka @ 2024-06-26 4:42 UTC (permalink / raw)
To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, linux-kernel, devicetree, Bao Cheng Su,
Diogo Ivo
Changes in v2:
- reference reg-mux.yaml in am654-system-controller child node
- base on top of dedicated am654-serdes-ctrl schema patch
This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/
and
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20240616-dt-bindings-mfd-syscon-split-v2-5-571b5850174a@linaro.org/
As we are working in this area, having a zero-warning baseline helps a
lot finding own issues quicker. Maybe not all of the suggested
resolutions are optimal, open for feedback, just want to have them all
fixed now soon.
Jan
Jan Kiszka (4):
arm64: dts: ti: k3-j72xx-mcu-wakeup: add dedicated wakeup controller
compatible
arm64: dts: ti: k3-am642-evm: Silence schema warning
dt-bindings: soc: ti: am645-system-controller: add child nodes used by
main domain
arm64: dts: ti: k3-am65-main: add system controller compatible
.../soc/ti/ti,am654-system-controller.yaml | 25 +++++++++++++++++++
arch/arm64/boot/dts/ti/k3-am642-evm.dts | 4 +++
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
.../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
.../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +-
.../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +-
6 files changed, 33 insertions(+), 4 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/4] arm64: dts: ti: k3-j72xx-mcu-wakeup: add dedicated wakeup controller compatible
2024-06-26 4:42 [PATCH v2 0/4] arm64: dts: k3: Resolve remaining dtbs_check warnings Jan Kiszka
@ 2024-06-26 4:42 ` Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 2/4] arm64: dts: ti: k3-am642-evm: Silence schema warning Jan Kiszka
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2024-06-26 4:42 UTC (permalink / raw)
To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, linux-kernel, devicetree, Bao Cheng Su,
Diogo Ivo
From: Jan Kiszka <jan.kiszka@siemens.com>
Each syscon node must come with a dedicated/specific compatible, which
is also reported by dtbs_check:
k3-j7200-common-proc-board.dtb: scm-conf@40f00000: compatible: ['syscon', 'simple-mfd'] is too short
Add one for the TI K3 AM654 MCU wakeup system controller used in J72xx
SoCs.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +-
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
index fccaabfb1348..3a78a3c1676d 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
@@ -165,7 +165,7 @@ mcu_timer9: timer@40490000 {
};
mcu_conf: syscon@40f00000 {
- compatible = "syscon", "simple-mfd";
+ compatible = "ti,am654-system-controller", "syscon", "simple-mfd";
reg = <0x00 0x40f00000 0x00 0x20000>;
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
index 9349ae07c046..d68e33d71eb3 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
@@ -35,7 +35,7 @@ k3_reset: reset-controller {
};
mcu_conf: syscon@40f00000 {
- compatible = "syscon", "simple-mfd";
+ compatible = "ti,am654-system-controller", "syscon", "simple-mfd";
reg = <0x0 0x40f00000 0x0 0x20000>;
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
index 5ccb04c7c462..1edb71f4a1bb 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
@@ -140,7 +140,7 @@ wkup_gpio_intr: interrupt-controller@42200000 {
};
mcu_conf: syscon@40f00000 {
- compatible = "syscon", "simple-mfd";
+ compatible = "ti,am654-system-controller", "syscon", "simple-mfd";
reg = <0x0 0x40f00000 0x0 0x20000>;
#address-cells = <1>;
#size-cells = <1>;
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/4] arm64: dts: ti: k3-am642-evm: Silence schema warning
2024-06-26 4:42 [PATCH v2 0/4] arm64: dts: k3: Resolve remaining dtbs_check warnings Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 1/4] arm64: dts: ti: k3-j72xx-mcu-wakeup: add dedicated wakeup controller compatible Jan Kiszka
@ 2024-06-26 4:42 ` Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 3/4] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 4/4] arm64: dts: ti: k3-am65-main: add system controller compatible Jan Kiszka
3 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2024-06-26 4:42 UTC (permalink / raw)
To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, linux-kernel, devicetree, Bao Cheng Su,
Diogo Ivo
From: Jan Kiszka <jan.kiszka@siemens.com>
The resolves
k3-am642-evm.dtb: adc: 'ti,adc-channels' is a required property
from schema $id: http://devicetree.org/schemas/iio/adc/ti,am3359-adc.yaml#
As the adc is reserved, thus not used by Linux, this has no practical
impact.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
arch/arm64/boot/dts/ti/k3-am642-evm.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index e20e4ffd0f1f..0e42d09aa785 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -640,6 +640,10 @@ cpsw3g_phy0: ethernet-phy@0 {
&tscadc0 {
/* ADC is reserved for R5 usage */
status = "reserved";
+
+ adc {
+ ti,adc-channels = <0 1 2 3 4 5 6 7>;
+ };
};
&ospi0 {
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/4] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
2024-06-26 4:42 [PATCH v2 0/4] arm64: dts: k3: Resolve remaining dtbs_check warnings Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 1/4] arm64: dts: ti: k3-j72xx-mcu-wakeup: add dedicated wakeup controller compatible Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 2/4] arm64: dts: ti: k3-am642-evm: Silence schema warning Jan Kiszka
@ 2024-06-26 4:42 ` Jan Kiszka
2024-06-28 21:45 ` Rob Herring
2024-06-26 4:42 ` [PATCH v2 4/4] arm64: dts: ti: k3-am65-main: add system controller compatible Jan Kiszka
3 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2024-06-26 4:42 UTC (permalink / raw)
To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, linux-kernel, devicetree, Bao Cheng Su,
Diogo Ivo
From: Jan Kiszka <jan.kiszka@siemens.com>
Expand bindings to cover both the MCU and the main usage of the AM654
system controller.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
.../soc/ti/ti,am654-system-controller.yaml | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
index e79803e586ca..a03e13cf2677 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
@@ -34,6 +34,31 @@ patternProperties:
type: object
$ref: /schemas/phy/ti,phy-gmii-sel.yaml#
+ "^mux-controller$":
+ type: object
+ ref: /schemas/mux/reg-mux.yaml#
+ description:
+ This is the SERDES lane control mux.
+
+ "^clock@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
+
+ "^dss-oldi-io-ctrl@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/mfd/syscon.yaml#
+ properties:
+ compatible:
+ items:
+ - const: ti,am654-dss-oldi-io-ctrl
+ - const: syscon
+
+ "^clock-controller@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
+ description:
+ Clock provider for TI EHRPWM nodes.
+
required:
- compatible
- reg
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 4/4] arm64: dts: ti: k3-am65-main: add system controller compatible
2024-06-26 4:42 [PATCH v2 0/4] arm64: dts: k3: Resolve remaining dtbs_check warnings Jan Kiszka
` (2 preceding siblings ...)
2024-06-26 4:42 ` [PATCH v2 3/4] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain Jan Kiszka
@ 2024-06-26 4:42 ` Jan Kiszka
3 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2024-06-26 4:42 UTC (permalink / raw)
To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, linux-kernel, devicetree, Bao Cheng Su,
Diogo Ivo
From: Jan Kiszka <jan.kiszka@siemens.com>
Now that the TI K3 AM654 system controller bindings also cover the usage
in the main domain, add its compatible to address dtbs_check complaints:
k3-am654-base-board.dtb: scm-conf@100000: compatible: ['syscon', 'simple-mfd'] is too short
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index b08f43812384..258f73fa9b1f 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -471,7 +471,7 @@ sdhci1: mmc@4fa0000 {
};
scm_conf: scm-conf@100000 {
- compatible = "syscon", "simple-mfd";
+ compatible = "ti,am654-system-controller", "syscon", "simple-mfd";
reg = <0 0x00100000 0 0x1c000>;
#address-cells = <1>;
#size-cells = <1>;
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
2024-06-26 4:42 ` [PATCH v2 3/4] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain Jan Kiszka
@ 2024-06-28 21:45 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2024-06-28 21:45 UTC (permalink / raw)
To: Jan Kiszka
Cc: Nishanth Menon, Vignesh Raghavendra, Tero Kristo,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, linux-kernel,
devicetree, Bao Cheng Su, Diogo Ivo
On Wed, Jun 26, 2024 at 06:42:07AM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Expand bindings to cover both the MCU and the main usage of the AM654
> system controller.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> .../soc/ti/ti,am654-system-controller.yaml | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> index e79803e586ca..a03e13cf2677 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> @@ -34,6 +34,31 @@ patternProperties:
> type: object
> $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
>
> + "^mux-controller$":
That's not a pattern, but fixed string. Move to 'properties'. I thought
the tools check this. Maybe it didn't apply to rc1 for the bot and you
didn't test either?
> + type: object
> + ref: /schemas/mux/reg-mux.yaml#
> + description:
> + This is the SERDES lane control mux.
> +
> + "^clock@[0-9a-f]+$":
> + type: object
> + $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
> +
> + "^dss-oldi-io-ctrl@[0-9a-f]+$":
> + type: object
> + $ref: /schemas/mfd/syscon.yaml#
> + properties:
> + compatible:
> + items:
> + - const: ti,am654-dss-oldi-io-ctrl
> + - const: syscon
> +
> + "^clock-controller@[0-9a-f]+$":
> + type: object
> + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
> + description:
> + Clock provider for TI EHRPWM nodes.
> +
> required:
> - compatible
> - reg
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-28 21:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-26 4:42 [PATCH v2 0/4] arm64: dts: k3: Resolve remaining dtbs_check warnings Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 1/4] arm64: dts: ti: k3-j72xx-mcu-wakeup: add dedicated wakeup controller compatible Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 2/4] arm64: dts: ti: k3-am642-evm: Silence schema warning Jan Kiszka
2024-06-26 4:42 ` [PATCH v2 3/4] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain Jan Kiszka
2024-06-28 21:45 ` Rob Herring
2024-06-26 4:42 ` [PATCH v2 4/4] arm64: dts: ti: k3-am65-main: add system controller compatible Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).