devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: rockchip: rk3399: Fix rt5651 compatible values
@ 2024-09-26 13:48 Geert Uytterhoeven
  2024-09-26 13:48 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value Geert Uytterhoeven
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2024-09-26 13:48 UTC (permalink / raw)
  To: Heiko Stuebner, Andy Yan, Jacob Chen
  Cc: linux-arm-kernel, linux-rockchip, devicetree, Geert Uytterhoeven

	Hi all,

This patch series fixes two occurrences of the "rockchip,rt5651"
compatible value, which is not documented in DT bindings or supported in
any upstream driver.  Presumable these are typos for "realtek,rt5651",
as the "simple-audio-card,name" properties in the "rt5651-sound" nodes
refer to Realtek codecs.

This is untested due to lack of hardware.
Thanks for your comments!

Geert Uytterhoeven (2):
  arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value
  arm64: dts: rockchip: rk3399-sapphire-excavator: Fix rt5651 compatible
    value

 arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts          | 2 +-
 arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value
  2024-09-26 13:48 [PATCH 0/2] arm64: dts: rockchip: rk3399: Fix rt5651 compatible values Geert Uytterhoeven
@ 2024-09-26 13:48 ` Geert Uytterhoeven
  2024-09-26 13:48 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-sapphire-excavator: " Geert Uytterhoeven
  2024-09-30 10:55 ` [PATCH 0/2] arm64: dts: rockchip: rk3399: Fix rt5651 compatible values Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2024-09-26 13:48 UTC (permalink / raw)
  To: Heiko Stuebner, Andy Yan, Jacob Chen
  Cc: linux-arm-kernel, linux-rockchip, devicetree, Geert Uytterhoeven

There are no DT bindings and driver support for a "rockchip,rt5651"
codec.  Replace "rockchip,rt5651" by "realtek,rt5651", which matches the
"simple-audio-card,name" property in the "rt5651-sound" node.

Fixes: 904f983256fdd24b ("arm64: dts: rockchip: Add dts for a rk3399 based board EAIDK-610")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts
index 1489eb32e266a748..4feb78797982baa5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts
@@ -541,7 +541,7 @@ &i2c1 {
 	status = "okay";
 
 	rt5651: audio-codec@1a {
-		compatible = "rockchip,rt5651";
+		compatible = "realtek,rt5651";
 		reg = <0x1a>;
 		clocks = <&cru SCLK_I2S_8CH_OUT>;
 		clock-names = "mclk";
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: rk3399-sapphire-excavator: Fix rt5651 compatible value
  2024-09-26 13:48 [PATCH 0/2] arm64: dts: rockchip: rk3399: Fix rt5651 compatible values Geert Uytterhoeven
  2024-09-26 13:48 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value Geert Uytterhoeven
@ 2024-09-26 13:48 ` Geert Uytterhoeven
  2024-09-30 10:55 ` [PATCH 0/2] arm64: dts: rockchip: rk3399: Fix rt5651 compatible values Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2024-09-26 13:48 UTC (permalink / raw)
  To: Heiko Stuebner, Andy Yan, Jacob Chen
  Cc: linux-arm-kernel, linux-rockchip, devicetree, Geert Uytterhoeven

There are no DT bindings and driver support for a "rockchip,rt5651"
codec.  Replace "rockchip,rt5651" by "realtek,rt5651", which matches the
"simple-audio-card,name" property in the "rt5651-sound" node.

Fixes: 0a3c78e251b3a266 ("arm64: dts: rockchip: Add support for rk3399 excavator main board")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
index dbec2b7173a0b677..31ea3d0182c062ef 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
@@ -163,7 +163,7 @@ &i2c1 {
 	status = "okay";
 
 	rt5651: rt5651@1a {
-		compatible = "rockchip,rt5651";
+		compatible = "realtek,rt5651";
 		reg = <0x1a>;
 		clocks = <&cru SCLK_I2S_8CH_OUT>;
 		clock-names = "mclk";
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] arm64: dts: rockchip: rk3399: Fix rt5651 compatible values
  2024-09-26 13:48 [PATCH 0/2] arm64: dts: rockchip: rk3399: Fix rt5651 compatible values Geert Uytterhoeven
  2024-09-26 13:48 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value Geert Uytterhoeven
  2024-09-26 13:48 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-sapphire-excavator: " Geert Uytterhoeven
@ 2024-09-30 10:55 ` Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2024-09-30 10:55 UTC (permalink / raw)
  To: Jacob Chen, Andy Yan, Geert Uytterhoeven
  Cc: Heiko Stuebner, linux-rockchip, linux-arm-kernel, devicetree

On Thu, 26 Sep 2024 15:48:39 +0200, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> This patch series fixes two occurrences of the "rockchip,rt5651"
> compatible value, which is not documented in DT bindings or supported in
> any upstream driver.  Presumable these are typos for "realtek,rt5651",
> as the "simple-audio-card,name" properties in the "rt5651-sound" nodes
> refer to Realtek codecs.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value
      commit: 2f39bba3b4f037d6c3c9174eed5befcef1c79abb
[2/2] arm64: dts: rockchip: rk3399-sapphire-excavator: Fix rt5651 compatible value
      commit: 577b5761679da90e691acc939ebbe7879fff5f31

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-30 10:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-26 13:48 [PATCH 0/2] arm64: dts: rockchip: rk3399: Fix rt5651 compatible values Geert Uytterhoeven
2024-09-26 13:48 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value Geert Uytterhoeven
2024-09-26 13:48 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-sapphire-excavator: " Geert Uytterhoeven
2024-09-30 10:55 ` [PATCH 0/2] arm64: dts: rockchip: rk3399: Fix rt5651 compatible values Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).