From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Lukasz Luba <lukasz.luba@arm.com>, Magnus Damm <magnus.damm@gmail.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH/RFC 0/2] arm64: dts: renesas: Re-add voltages to OPP tables
Date: Tue, 8 Oct 2024 11:14:19 +0200 [thread overview]
Message-ID: <cover.1728377971.git.geert+renesas@glider.be> (raw)
Hi all,
When CONFIG_ENERGY_MODEL=y, an error is printed on RZ/G2E and R-Car E3:
cpu cpu0: EM: invalid perf. state: -22
This happens because the Operating Points Parameters tables do not list
voltages, as they are all identical. Previously, it was assumed they
were optional, and unused, when none of the CPU nodes is tied to a
regulator using the "cpu-supply" property. This assumption turned out
to be incorrect, causing the reported error message.
This RFC patch series fixes this by adding the missing voltages.
Note that the Energy Model calculates energy efficiency by dividing the
(estimated) CPU power consumption by CPU core clock frequency. When all
voltages have the same value, the former is proportional to clock
frequency, and energy efficiency becomes a constant. Hence all
operating points are considered to have the same efficiency, and the
Energy Model always picks the one with the highest clock rate (see also
[1]).
Alternatively, the Energy Model could be changed to silently ignore OPP
tables with missing frequencies. IMHO this is not an unusual case.
Which approach should be taken?
Thanks for your comments!
[1] "PM: EM: Question Potential Issue with EM and OPP Table in cpufreq
ondemand Governor"
https://lore.kernel.org/all/a2ca883e-122e-43a1-b377-c43956b5b3be@arm.com
Geert Uytterhoeven (2):
arm64: dts: renesas: r8a774c0: Re-add voltages to OPP table
arm64: dts: renesas: r8a77990: Re-add voltages to OPP table
arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 3 +++
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 3 +++
2 files changed, 6 insertions(+)
--
2.34.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2024-10-08 9:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 9:14 Geert Uytterhoeven [this message]
2024-10-08 9:14 ` [PATCH/RFC 1/2] arm64: dts: renesas: r8a774c0: Re-add voltages to OPP table Geert Uytterhoeven
2024-10-08 9:14 ` [PATCH/RFC 2/2] arm64: dts: renesas: r8a77990: " Geert Uytterhoeven
2024-10-08 9:29 ` [PATCH/RFC 0/2] arm64: dts: renesas: Re-add voltages to OPP tables Biju Das
2024-10-08 9:37 ` Geert Uytterhoeven
2024-10-22 13:36 ` Geert Uytterhoeven
2024-10-25 15:41 ` Lukasz Luba
2024-10-28 11:34 ` Geert Uytterhoeven
2024-10-28 13:42 ` Lukasz Luba
2024-11-04 15:15 ` Geert Uytterhoeven
2024-11-13 16:58 ` Geert Uytterhoeven
2024-12-10 14:28 ` Geert Uytterhoeven
2025-01-24 11:53 ` Geert Uytterhoeven
2025-02-18 8:25 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1728377971.git.geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).