From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outbound3.mail.transip.nl (outbound3.mail.transip.nl [136.144.136.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2ABC2F8E93; Sun, 31 May 2026 04:09:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.144.136.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780200567; cv=none; b=c299hDrfGFch/Ji0wLyeKj00cuMo309jifTC9Mf0enNgnJjHejzhKAoLWZdIobp2+xGsqSuWPnyWvEeqmylUBwr7FD0oF23VtOVCfTTnvgEQWnjrnMYfRFM55WSmfVqscD79I8rotD6elmueFNsodypbbiWUgmOHcDgrtzgCYW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780200567; c=relaxed/simple; bh=BWj2pViGtvI1piW9aB6/LHKSQnWiWiTeJCCJsCaRFXI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dqsunJZNeSjbFeRfnUDRhMtFzc5dig80y+Hevf5uwwKIUaOd24ng5iQJ5FPXfnb78bbDWEKif6yimzxc50Lhzomx3dPqnzEYGFGPp9ozfsxRF0FNunagrpxO6wOMIWSMOG9T5Y9fs7IC474ba59uTl49Q5q6TAG9+o1DapLXgJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=herrie.org; spf=pass smtp.mailfrom=herrie.org; dkim=pass (2048-bit key) header.d=herrie.org header.i=@herrie.org header.b=rsOGEs7G; arc=none smtp.client-ip=136.144.136.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=herrie.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=herrie.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=herrie.org header.i=@herrie.org header.b="rsOGEs7G" Received: from submission4.mail.transip.nl (unknown [10.103.8.155]) by outbound3.mail.transip.nl (Postfix) with ESMTP id 4gSkB665N0zrJ7T; Sun, 31 May 2026 06:09:18 +0200 (CEST) Received: from herrie-desktop.. (180-93-184-31.ftth.glasoperator.nl [31.184.93.180]) by submission4.mail.transip.nl (Postfix) with ESMTPA id 4gSkB54tTrz3R3nyb; Sun, 31 May 2026 06:09:16 +0200 (CEST) From: Herman van Hazendonk To: Amit Kucheria , Conor Dooley , Daniel Lezcano , devicetree@vger.kernel.org, Krzysztof Kozlowski , Lee Jones , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lukasz Luba , "Rafael J. Wysocki" , Rob Herring , Satya Priya , Thara Gopinath , van Hazendonk , Zhang Rui Subject: [PATCH v2 0/3] thermal: qcom: add PM8901 PMIC temperature-alarm driver Date: Sun, 31 May 2026 06:09:13 +0200 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: ClueGetter at submission4.mail.transip.nl DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=transip-a; d=herrie.org; t=1780200558; h=from:subject:to:references: in-reply-to:date:mime-version; bh=+SyikEMIVA8xJyMKrrK6i1BzcUDkPTpbt93nBPr/Dbg=; b=rsOGEs7GGneDzB3zWp882m5elURRFNReZc9GzDSd44i6XZAbqb+r1559UpH+vklqy9hDl8 rnHEnprEoRn2Ez1lS/+vT2reMPn351H8WaMAwkNA3u83cOH/QN7PuR6fodBfKHmrKnj3UQ DMGolPfSIHKECVEny12hMWuVm8U2pruDwQ3BFyNFECSZM4Uv2HeFh19FoG3e9orWIkZL2e PI8fdsZbDvRIDoUjd3RCEkUgwbL506msCAdYKtI0D338lwHs4IYBU7QHOnn3oBlrIflwcq /Hnuzvzj2FLffFu7iCEWUdkuhRj2xsMC2XkRxuzyLYuXd7WHSyTNQfFBylRbXw== X-Report-Abuse-To: abuse@transip.nl Hi all, Self-review (with Sashiko AI assist) caught issues in v1 before maintainer review reached them; re-rolling promptly. v1: https://lore.kernel.org/linux-arm-msm/cover.1780148149.git.github.com@herrie.org/ v2 changes: - NEW patch 1/3: extend the qcom,pm8xxx parent schema with a `temp-alarm@[0-9a-f]+$` patternProperty so the new sub-node validates as a recognised child of the PMIC. Without this, any board DT instantiating the temp-alarm sub-node fails dt_binding_check (CI bot caught this on v1). - patch 2/3: thermal binding YAML rewritten: * add `allOf: $ref: /schemas/thermal/thermal-sensor.yaml#`; * rewrite the example so the parent qcom,pm8901 node itself satisfies its own schema (reg, address-cells, interrupts, interrupt-controller) - addresses the CI bot's `'interrupts' is a required property` complaint on the embedded pmic node; * reword the commit message; v1 incorrectly said the binding describes the "GIC interrupt" and "parent PMIC reference" (the interrupts are actually PMIC-internal, and the parent relationship is the standard DT parent-child hierarchy). - patch 3/3: driver fixes: * defer the SW-override switch (which disables PMIC HW auto-shutdown) to the very end of probe and install a devm action that restores HW auto-shutdown on unbind, so the part is never left without any thermal protection if an earlier probe step fails; * fix the first-read temperature comment: the formula computes the lower bound of the current stage, not the midpoint; * snapshot chip->stage/thresh/temp under chip->lock before printing the boot banner so the values are consistent now that the ISR is live; * drop the explicit ->remove(), the new devm restore action replaces it. dt_binding_check passes on both the parent qcom,pm8xxx and the new qcom,pm8901-temp-alarm. Driver passes checkpatch with zero warnings or errors. Thanks, Herman Herman van Hazendonk (3): dt-bindings: mfd: qcom-pm8xxx: allow temp-alarm subnode dt-bindings: thermal: qcom: add pm8901-temp-alarm thermal: qcom: add PM8901 PMIC temperature-alarm driver .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 4 + .../thermal/qcom,pm8901-temp-alarm.yaml | 90 ++++ drivers/thermal/qcom/Kconfig | 12 + drivers/thermal/qcom/Makefile | 1 + drivers/thermal/qcom/qcom-pm8901-tm.c | 408 ++++++++++++++++++ 5 files changed, 515 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/qcom,pm8901-temp-alarm.yaml create mode 100644 drivers/thermal/qcom/qcom-pm8901-tm.c -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outbound8.mail.transip.nl (outbound8.mail.transip.nl [136.144.136.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C5F026F46F; Sun, 31 May 2026 04:09:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.144.136.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780200585; cv=none; b=Thmiel8LpXan/nzVOINrQk/BqgzS9S8Jbm37vlOHdF1JCfSpIfP8Ba3YF7saJJeiZYdo13MyV2tvh3YhvbwTo2Ydc7NEg1cSWdJsDe+Pfcb/HOMEp98cI/MgoeqgFyCs+FrG464p0NK17VYxtepHiD4sBikbNDTyL4ct8A1bsLk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780200585; c=relaxed/simple; bh=36NhuOVHY5OtaVczkA7Bdp6fFKvM65k1mtw8NRYVGJM=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FEZmsvu61ndKFXykdYROfKSTXt7BpSxsTkUP4p30nFK4atvkDSTQ7tei6A9MrzhAviHRYCMA7C/nRNMXLEJ3VKb9NRD5NaanGBv8CorRa0NlHZV5EdXehW3BsH0VXCCneoPxHxGrbilZCBVYTpBTHbDpwXo6ICsp/xw/CL13qLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=herrie.org; spf=pass smtp.mailfrom=herrie.org; dkim=pass (2048-bit key) header.d=herrie.org header.i=@herrie.org header.b=DztoHCe/; arc=none smtp.client-ip=136.144.136.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=herrie.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=herrie.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=herrie.org header.i=@herrie.org header.b="DztoHCe/" Received: from submission3.mail.transip.nl (unknown [10.100.4.72]) by outbound8.mail.transip.nl (Postfix) with ESMTP id 4gSk9w3ZYhzY75ZZ; Sun, 31 May 2026 06:09:08 +0200 (CEST) Received: from herrie-desktop.. (180-93-184-31.ftth.glasoperator.nl [31.184.93.180]) by submission3.mail.transip.nl (Postfix) with ESMTPA id 4gSk9v4ppGzf52b6; Sun, 31 May 2026 06:09:07 +0200 (CEST) From: Herman van Hazendonk To: Conor Dooley , devicetree@vger.kernel.org, Georgi Djakov , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Rob Herring Subject: [PATCH v2 0/2] interconnect: qcom: add MSM8x60 NoC driver Date: Sun, 31 May 2026 06:09:05 +0200 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: ClueGetter at submission3.mail.transip.nl DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=transip-a; d=herrie.org; t=1780200547; h=from:subject:to:references: in-reply-to:date:mime-version; bh=NlW9i/XlXywCqjlGWse0QjhnP2pj35gx6iynqe3HBOA=; b=DztoHCe/hVyufbESPee0DHTn8VM3g73jwxtq6fa/KLnjMFWRzQ54Z0r9U+bdw/gAnn3Yqs fcHkffhpxngFqbk3bRIj6qOTJjiaTwfciFwJ1/MTUtb0sIqSZbcn67lL/X4shqkkxZinlP XccuOY+nTj7P4CStJt8HJdtIc9UD47+IlfuIRap5xDbqbiPR5SNBJ0051y+8kr6jCp/XaI gy8BZBM5QGbWWUZ1f5CYxxmqJokgR2bU5SOYLRwgjjBF8vskTn5EBS4l5g89nMDW6z+YkE iEFREv7JQzu6bgwvXg//XKe6R+1RgrclxxOT4LYETrJwPkZGYyLHRVaOXjkuLw== X-Report-Abuse-To: abuse@transip.nl Message-ID: <20260531040905.ZAdI1TQarTaVwyV5T3xfExjsPFLtfkVkMq5lR39VWUA@z> Hi all, Self-review (with Sashiko AI assist) caught five real issues in v1's NoC driver before the maintainer review cycle reached them, so re-rolling promptly. v1: https://lore.kernel.org/linux-arm-msm/cover.1780148149.git.github.com@herrie.org/ v2 changes (driver patch only; the binding header is unchanged from v1): - MMFAB master port collision: mmfab_to_appss claimed port 2, but that port was already owned by mmfab_mas_adm1_port0. Per the fabric's port table the APPS_FAB gateway lives at port 11; fix the DEFINE_QNODE so ADM1 DMA's arbitration vote on MMFAB is no longer overwritten by the gateway. - msm8660_rpm_commit() double-converted bandwidth units: it called icc_units_to_bps() (which already returns bytes/s) and then immediately divided by 8 "bits -> bytes", asking RPM for 1/8 of the bandwidth that consumers had requested. Drop the spurious divide. - Fabric rate cache hoisted to provider scope and divided by the fabric's own bus width rather than the triggering node's local buswidth. A fabric has one shared hardware clock; using each master's local buswidth makes the requested clk rate oscillate depending on which master called icc_set_bw() last, and caching the result on the node lets a subsequent update skip clk_set_rate even though a different node has already moved the hardware. The new layout adds desc->bus_width per fabric (AFAB/SFAB/DFAB=8, MMFAB=16) and qp->rate as the single source of truth. - msm8660_get_rpm() rewritten: * returns ERR_PTR(-EPROBE_DEFER) when the RPM phandle resolves but the device hasn't probed yet, instead of returning NULL and silently disabling ARB forever; * adds a device_link to the RPM device so the devres-managed qcom_rpm struct can't be freed out from under us if the RPM driver is unbound at runtime (previously a use-after-free risk because we kept a pointer past put_device()). Probe propagates IS_ERR(qp->rpm) up so the framework retries. - devm_clk_bulk_get_optional() now distinguishes -EPROBE_DEFER (propagated) from real "no clocks" (continue without scaling). Previously every error was swallowed, which permanently disabled clock scaling if the icc driver happened to probe before the clock provider - which it usually does, given the core_initcall ordering. No functional change intended on the working paths; this is purely correctness work. Thanks, Herman Herman van Hazendonk (2): dt-bindings: interconnect: qcom: add msm8660 fabric IDs interconnect: qcom: add MSM8x60 NoC driver drivers/interconnect/qcom/Kconfig | 10 + drivers/interconnect/qcom/Makefile | 2 + drivers/interconnect/qcom/msm8660.c | 1069 +++++++++++++++++ .../dt-bindings/interconnect/qcom,msm8660.h | 156 +++ 4 files changed, 1237 insertions(+) create mode 100644 drivers/interconnect/qcom/msm8660.c create mode 100644 include/dt-bindings/interconnect/qcom,msm8660.h -- 2.43.0