From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D6EC433EF for ; Thu, 5 May 2022 12:12:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359753AbiEEMPp (ORCPT ); Thu, 5 May 2022 08:15:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244504AbiEEMPo (ORCPT ); Thu, 5 May 2022 08:15:44 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31C166411; Thu, 5 May 2022 05:12:05 -0700 (PDT) X-UUID: 85c1ab05184f4bf5b38b80821f60b2ec-20220505 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:a9a785a5-7a76-42bf-98a6-8a23df82c485,OB:0,LO B:0,IP:0,URL:8,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:8 X-CID-META: VersionHash:faefae9,CLOUDID:144d5216-2e53-443e-b81a-655c13977218,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,File:nil,QS:0,BEC:nil X-UUID: 85c1ab05184f4bf5b38b80821f60b2ec-20220505 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1724677628; Thu, 05 May 2022 20:12:00 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 5 May 2022 20:11:59 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 5 May 2022 20:11:58 +0800 Message-ID: Subject: Re: [PATCH v7 2/2] phy: mediatek: Add PCIe PHY driver From: Jianjun Wang To: AngeloGioacchino Del Regno , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Matthias Brugger , "Chen-Yu Tsai" , Krzysztof Kozlowski CC: Wei-Shun Chang , , , , , , , , , , , Date: Thu, 5 May 2022 20:11:58 +0800 In-Reply-To: References: <20220422142331.17173-1-jianjun.wang@mediatek.com> <20220422142331.17173-3-jianjun.wang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Angelo, On Tue, 2022-04-26 at 18:06 +0200, AngeloGioacchino Del Regno wrote: > Il 22/04/22 16:23, Jianjun Wang ha scritto: > > Add PCIe GEN3 PHY driver support on MediaTek chipsets. > > > > Signed-off-by: Jianjun Wang > > Hello Jianjun, > there's only one last bit to fix, check below: > > > --- > > drivers/phy/mediatek/Kconfig | 11 ++ > > drivers/phy/mediatek/Makefile | 1 + > > drivers/phy/mediatek/phy-mtk-pcie.c | 267 > > ++++++++++++++++++++++++++++ > > 3 files changed, 279 insertions(+) > > create mode 100644 drivers/phy/mediatek/phy-mtk-pcie.c > > > > ..snip.. > > > +static int mtk_pcie_read_efuse(struct mtk_pcie_phy *pcie_phy) > > +{ > > + struct device *dev = pcie_phy->dev; > > + bool nvmem_enabled; > > + int ret, i; > > + > > + /* nvmem data is optional */ > > + nvmem_enabled = device_property_read_bool(dev, "nvmem-cells"); > > device_property_read_bool() returns device_property_present(). > > I would prefer that, instead, you call the latter: > > nvmem_enabled = device_property_present(dev, "nvmem-cells"); > > It's the same, yes, but this will increase human readability, as the > function > name clearly states the intention here. Thanks for your review and sorry for the late response, I'll replace it with 'device_property_present' in the next version. Thanks. > > Thanks, > Angelo >