From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Mavrodiev Subject: Re: [PATCH v2 5/8] arm64: dts: allwinner: Enable AXP803 CHGLED for Olimex boards Date: Tue, 19 Feb 2019 09:43:56 +0200 Message-ID: References: <20190215115013.11098-1-stefan@olimex.com> <20190215115013.11098-6-stefan@olimex.com> <20190215184916.GA17897@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190215184916.GA17897@amd> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Pavel Machek , Stefan Mavrodiev Cc: Jacek Anaszewski , Rob Herring , Mark Rutland , Chen-Yu Tsai , Maxime Ripard , Lee Jones , "open list:LED SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:X-POWERS MULTIFUNCTION PMIC DEVICE DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" List-Id: devicetree@vger.kernel.org On 2/15/19 8:49 PM, Pavel Machek wrote: > On Fri 2019-02-15 13:50:10, Stefan Mavrodiev wrote: >> Teres-I and A64-OLinuXino commes with populated LED connected >> to AXP803. So to be used as battery indication, pass the LED control >> to the charger itself in mode 0 ( FULL while charging, OFF no battery >> or completed). >> >> Signed-off-by: Stefan Mavrodiev >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 6 ++++++ >> arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 6 ++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts >> index f7a4bccaa5d4..7d6930319fba 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts >> @@ -177,6 +177,12 @@ >> >> #include "axp803.dtsi" >> >> +&axp_led { >> + label = "a64-olinuxino:yellow:chgled"; > There's little chance userspace will recognize this led. > > Can you make it "platform:yellow:charging" and fix it for other > boards, too? Sure. Best regards, Stefan Mavrodiev > > Pavel