From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF20CC77B73 for ; Sat, 27 May 2023 06:31:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbjE0Gbx (ORCPT ); Sat, 27 May 2023 02:31:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjE0Gbw (ORCPT ); Sat, 27 May 2023 02:31:52 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75D80B6; Fri, 26 May 2023 23:31:51 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34R6VWDo086599; Sat, 27 May 2023 01:31:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685169093; bh=IOYx4mw7zintF8nEN+qfM8Dxs9EsGfWFPruAo4hnbd4=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=ZrDENuQqM9yy2kK3UFZH+PX9xh9uS+/PTKZ1GiFKu0ESzD5KMWNNZgBI5t55WbjS7 OaIRg/tBOm+UETYY7HBOWaxcF73ZWefeGLcaghwFjj6YgFsy06RQqvlWdO5Zi5pakf yHArV575yVA5Mgoez2RLBzA8wkV1pwjfhtgbyvcY= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34R6VWMt026114 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 27 May 2023 01:31:32 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sat, 27 May 2023 01:31:32 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sat, 27 May 2023 01:31:32 -0500 Received: from [10.249.138.166] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34R6VSNu031014; Sat, 27 May 2023 01:31:29 -0500 Message-ID: Date: Sat, 27 May 2023 12:01:28 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node Content-Language: en-US To: Francesco Dolcini , Nishanth Menon , CC: , , , , , References: <20230417133308.1990057-1-kamlesh@ti.com> <20230417134241.oj5cmrqjeoxj2sb2@power> From: Vignesh Raghavendra In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/05/23 8:14 pm, Francesco Dolcini wrote: > On Mon, Apr 17, 2023 at 08:42:41AM -0500, Nishanth Menon wrote: >> On 19:03-20230417, kamlesh@ti.com wrote: >>> From: Kamlesh Gurudasani >>> >>> With latest firmware update, we can no longer control power of SA3UL from >>> main domain. >> >> How is this backward compatible? > > I just stumbled across this commit since I had an issue with crypto@40900000 > not being probed on Verdin AM62. > > Not sure how this is supposed to work about backward/forward > compatibility, however this is needed for having it working with the > latest firmware. > >From what I understand, newer firmware seems to hate SA3UL PD control requests. But older firmwares just ignored the call as the SA3UL PD is on by default. So as such, this DT patch alone wont break forward/backward compatibility. It looks like newer firmware is broken wrt older kernel which is unfortunate. Kamlesh: can you resubmit this patch with appropriate "Fixes" tag so that it gets backported to stable kernels? > And if there is a proper way that take care of this, it should be > backported IMO. > > Francesco >