From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C46C280A56 for ; Wed, 26 Aug 2026 10:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787739209; cv=none; b=XtJnVaEySjpSCErI3qWGsoV3moLYsKPBlFDSciXkAkrEL0Wjj3y6YSgSw5Klie0Fu5VTRFGsbn9gkwWXa4jS591piVnAO8HBYagtKIMOzhGj1oUxFmWFMyQb/Sosf4mmT2OpaIEXqbl1MZTowETbHgqwDCwgBKO2MDTw6QaeW7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787739209; c=relaxed/simple; bh=KIZQegHnKMBMCN5KurBHB75g+b3yGfCCWsKSLBYpYY4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sV9Cm5ceLq9HD0fbqaiOi7Bcn6fOOCpD8oIMHS/oKAqNIBd/Ik0pGMkfSvmrqQTY5I6IWaLvyCmQhhKA4D9cjALfjzxzRThGhkzF2FrRi0lbZedlYweMHLb2/08HnUj95EJOHYzp4XymNUEae1NgPMOJ3c/9nyVgvHuCjDinsgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oFoMEfi8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kZH04vp6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oFoMEfi8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kZH04vp6" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67Q9CoSi3502405 for ; Wed, 26 Aug 2026 10:13:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MpszJFaxfFemeV0/SZwFeF4b5jqGx1fNaw5whlTiIlQ=; b=oFoMEfi8ydvPgb/Q ioRIl9UCE2Svdffnd0Tg0p/gufbbq0xgocIs0qK5aWaAyAIJUwscOKjw/i3F74bo CBz9bnjwHQKBKlXkxSKm3woKgReR/zTiza/vdfEx0b7ir6pR9Ttqx49Zho5GsOIY 7TE/ArlrjxA3RbKx6WipaMnWzmRY2hICdkJT+SYnn2sSUh56Os+78JOLjCCiFslm C8zqWEJAGIZgztDcoERIqFbIKCZeNXqWgqnCWGJJB58KaEORqU153u0M/UUpc+Nk tKql6CPhu/5NWPRCTlcOSpxKG12c+34dELEm+Qb3IeP9MuAk0+Rp20sA6RUtn1UI yhzH/g== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9uthrmqq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Aug 2026 10:13:26 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1d7886cdso14132321cf.1 for ; Wed, 26 Aug 2026 03:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787739206; x=1788344006; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MpszJFaxfFemeV0/SZwFeF4b5jqGx1fNaw5whlTiIlQ=; b=kZH04vp6+jEi3CReRlnDbCEaziyLmPTiwWYvdTh5fdYy5gcx0jPgg5Eazfue3MZKA7 Rswzvj8aNZNmMJ4reGvDEocqwVGN/0YcxS2cjWd05E7PePIe4Uo+u4IJRw5PVNshq5wH vlqnD6oGCHkpebe9GY2NfysAkaBR/xuNk9usta5fdWLkcHxRSu6ZdBqbojZCrmX3k69o R8X0r6LgVfEFgSRkgjmtPe1AVhR+1CbusCbKoRGVI7Ro8YpZu1pjTJw4wjkEq3mmEHuY dQkd2jQx+VYpykKwH1THwnzjIaOIZI3X5CuXqq3wJNWkdVyT38JSc/33z3shDUfZNjNh OJkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787739206; x=1788344006; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MpszJFaxfFemeV0/SZwFeF4b5jqGx1fNaw5whlTiIlQ=; b=kBAs2ZHxLM0VYKKYHJ3Rk/qxlyuW5ra+kwzZDhYB6zSOCJZV4UluX9Lp8NTMzAJanm EhlEBUbviqtkuaJLOpmYJ3SP1RVIR/P2DOLxtiaLLZL68XzpnOfTlz+/ANZdDB2b+3Ft ME7nXowMT+1fmxM2d0oJO9gGLkEz1PQI2KlYSnlOUGtNfC9LlsOLxMy/Uq9XAYYjDeRX 5uX/fTWZ2K32hgZ/+v8FzS7d9jdVzlmlGCyOCeOx0TxoJgkY3yMIRrw8lLHS2FXL9HiH yMkHT6oOLhzlPiMLcf/WBEAb6SaOSNLaTNg/g+dKkQv312/CQxjzuFtkFzVhD4Pf3jOT fuEg== X-Forwarded-Encrypted: i=1; AHgh+Roszo+stOiCFzEgCS56BdCA+Q3f4mESU0+PjlNLnXRcVfkAUWNEdqzu0xwIbNXo1IimiLcIe3Mqdsvk@vger.kernel.org X-Gm-Message-State: AFuF++nKKVPe5A2QxWay7W9/Lpes/aa4t8c27CIR4P16kodlaw5HBQvS s/XZQK7djGuwd/MkGz9VPWuMAfPC7J3BzsBJTxcyYcNZ0iom++qSDQitS3ziRZGv4hOSx8J3yLE DIJoQebElj/KRn9H2aOCKjBlSd8LF0YH/5hq1qV3zZEs1UaZ9R966kUl7TXSTXw5c X-Gm-Gg: AR+sD130kEmfCRWKjtHGnkHGRC6BonKRZXuqWYhxK0umMQEKYvWKE8JnH/KBOqIl9SK t2GbtXwn9FO4zTCKCdFrbryEyFZsSgD4oPbOhviUISXSjeISgjmKHpbnI/aZjmZJoP5yxGruZOr lO924P401TeS4q0/2AIUFyOlneGK2OTRYNzRT7MMMtzDO1ipUXCtFZv7BqTBnsR5XV2Ehvau049 FrkGKeuw7b5jmxmxFtjEWIiXEQYViL76Vct0FSKm6/ziFw4cH0XuJMUG15uuXiasIiqOk16h6Wl XWiGRIRVuKO+L9CAgdnv++LuRZkvLa+jLhw9zjxgvXJPxZhbntpkBqjshcV2CLtRtX/u1ar0RO2 1ZxSo7ljElbBEaUXojORed1qGGsA= X-Received: by 2002:a05:622a:8c8:b0:51c:1c73:5945 with SMTP id d75a77b69052e-52e42320622mr58935421cf.24.1787739206365; Wed, 26 Aug 2026 03:13:26 -0700 (PDT) X-Received: by 2002:a05:622a:8c8:b0:51c:1c73:5945 with SMTP id d75a77b69052e-52e42320622mr58934941cf.24.1787739205944; Wed, 26 Aug 2026 03:13:25 -0700 (PDT) Received: from [192.168.68.107] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-482e28dc13fsm2201496f8f.24.2026.08.26.03.13.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2026 03:13:25 -0700 (PDT) Message-ID: Date: Wed, 26 Aug 2026 11:13:23 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 8/9] ASoC: qcom: Add Shikra QAIF support To: Harendra Gautam , Mohammad Rafi Shaik Cc: Srinivas Kandagatla , Mark Brown , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prasad Kumpatla , Krzysztof Kozlowski , Sarath Ganapathiraju , Kumar Anurag Singh References: <20260824063627.3595610-1-harendra.gautam@oss.qualcomm.com> <20260824063627.3595610-9-harendra.gautam@oss.qualcomm.com> <9c1dddb8-5f1b-4b7c-b810-64cbd6f7ccac@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=EMA2FVZC c=1 sm=1 tr=0 ts=6a8ebc46 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=DqJvd4i33UI3nbR7U2UA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: D17p3mBySK6EQw9XMnC6xzg-DcsW11N1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDA4NCBTYWx0ZWRfXy6sghefAmUpb BiTR0pxGBMMNcsLEKqJi+abC3r9LnW0GWpin2LXy06eABnrZw7h1sk7AXxZHneLiscb+mKG1hNj sO5IY4V+6tSurCHVr2WAVoe+dNInqTALoh/kKEIUiiCGtnVpjp30b8y7yDh44E4ZdSfezv7N/rd ydYeDKK265Xbe6EgRhqfNOYIbK0FIVHjmLoynDnkCVtQTmVIK8XC+F07MEDgDq/5q7iU5W0Rmho PT1WsTMBdNgb0YZczljSF7GjHz0ASrG1/QsIBXgeuNWeMen0X6yOBai2Uxl9/WEpFqBhE9TzQbN eHwew0G06oOMKjRqbL/cZNNgF4crx+WmCe67MYgEfNHB+AU32EnoVpg+uLMFcXBFYFnInRq5AoX m+HQjo9Kykb8jp5d1ndQL29NyL3D8VyeQfcbe5udW+xXKwvEwQArIa6FOprsskFIYPcXIWyZjbt sCCpK84YAYGo3Fn51cQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDA4NCBTYWx0ZWRfX0YmO8MrinLTw b4GlWfqHROoCFx7IvbK1wXNZ6zikM9gtgcagITPCfSM9z4KjzO6aNLabxzKxuSgPclc6iOl8lbM eBpUsS2/wDPylSIEiiXVJ9PxZ4arvvs= X-Proofpoint-GUID: D17p3mBySK6EQw9XMnC6xzg-DcsW11N1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_02,2026-08-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260084 On 8/26/26 9:58 AM, Harendra Gautam wrote: >>> + .id = QAIF_CDC_DMA_RX0, >>> + .name = "CDC DMA RX0", >>> + .playback = { >>> + .stream_name = "WCD Playback0", >>> + .formats = SNDRV_PCM_FMTBIT_S16, >>> + .rates = SNDRV_PCM_RATE_48000, >>> + .rate_min = 48000, >>> + .rate_max = 48000, >>> + .channels_min = 1, >>> + .channels_max = 2, >>> + }, >>> + .ops = &asoc_qcom_qaif_cif_dai_ops, >>> + }, { >>> + .id = QAIF_CDC_DMA_RX1, >>> + .name = "CDC DMA RX1", >>> + .playback = { >>> + .stream_name = "WCD Playback1", >> No dai for WCD capture (or) it's missing in this patch. >> >> >> Best Regards, >> Rafi. >> > On Shikra, capture is always through the VA Macro, irrespective of > whether the source is WCD AMIC or MSM DMIC and the stream_name is only > a descriptive identifier. WCD naming is totally incorrect w.r.t this driver, WCD is external codec, which can be connected to any dai. QAIF just exposes FE dais It should not have any codec level information either as names or any other. Pl remove and use the correct naming which reflect the dai name w.r.t to QAIF. --srini > -Harendra