From: Andrew Lunn <andrew@lunn.ch>
To: Josua Mayer <josua@solid-run.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Yazan Shhady <yazan.shhady@solid-run.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board
Date: Fri, 26 Apr 2024 20:18:03 +0200 [thread overview]
Message-ID: <d0426bb3-1f40-48ed-9032-6ffdce455cd4@lunn.ch> (raw)
In-Reply-To: <15b79794-41f4-43e0-888e-286ca1fc4321@solid-run.com>
> >> Colours are similar to RJ45 connectors (yellow, green),
> >> and are intended for the same purpose: link, activity.
> > For the switch LEDs you used label = "LED10"; Does the silk screen
> > have similar numbers for these LEDs?
> Correct, on CN9130 Clearfog Pro DSA switch, all LEDs are labeled
> individually on the silk screen.
>
> The SolidWAN SFP leds are dual-colour leds with 3 terminals:
> anode to 3.3V, 2x cathode to gpio-controlled transistors.
> They are labeled on the silk-screen as "LED9", "LED10".
>
> Duplicate labels are not great, is there a better way?
> old style "LED9:green" e.g. ...?
So you have copper LEDs and SFP LEDs, each with the same silk screen
label? Maybe put 'copper' and 'sfp' as a prefix into the label?
Andrew
next prev parent reply other threads:[~2024-04-26 18:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 12:58 [PATCH v3 0/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Josua Mayer
2024-04-14 12:58 ` [PATCH v3 1/4] dt-bindings: arm64: marvell: add solidrun cn9130 som based boards Josua Mayer
2024-04-22 13:38 ` Andrew Lunn
2024-04-14 12:58 ` [PATCH v3 2/4] dt-bindings: arm64: marvell: add solidrun cn9132 CEX-7 evaluation board Josua Mayer
2024-04-22 13:38 ` Andrew Lunn
2024-04-14 12:58 ` [PATCH v3 3/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Josua Mayer
2024-04-14 13:02 ` Josua Mayer
2024-04-14 13:30 ` Krzysztof Kozlowski
2024-04-22 13:38 ` Andrew Lunn
2024-04-14 12:58 ` [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board Josua Mayer
2024-04-14 13:07 ` Josua Mayer
2024-04-14 13:18 ` Josua Mayer
2024-04-22 13:37 ` Andrew Lunn
2024-04-22 13:47 ` Josua Mayer
2024-04-26 18:18 ` Andrew Lunn [this message]
2024-04-26 18:51 ` Josua Mayer
2024-04-26 19:43 ` Andrew Lunn
2024-04-15 18:47 ` [PATCH v3 0/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0426bb3-1f40-48ed-9032-6ffdce455cd4@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=josua@solid-run.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox