From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C06C38142 for ; Mon, 23 Jan 2023 19:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232745AbjAWTnA (ORCPT ); Mon, 23 Jan 2023 14:43:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232528AbjAWTnA (ORCPT ); Mon, 23 Jan 2023 14:43:00 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCF6512046 for ; Mon, 23 Jan 2023 11:42:57 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id l41-20020a05600c1d2900b003daf986faaeso9414622wms.3 for ; Mon, 23 Jan 2023 11:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2bbZbxQ5uVGlh9D/fI2txo5pcGdK/f5Akir30Ty5LuY=; b=cot2k2ijWyoodQXHtjiy3DvScVigolXDLEZseLa1A1QxOqy47+6bCCKB8Z8wCZeCnO 0Y1tw2NrkysgPZU9PAmF+dokp+3lHN+dIdAUc0tcSWX+BjzfdjwYPkKseJsUq2eqO01z pbuSa8zGLgGD5F8dDRyW69pFWHktXUYJ6skl2mJn9F+El5uIJFAbjM3eNyhljqVyXC1/ QNm/AfJAcdz1nQTjs8/3u73KbxNom1nxcp+jn9ZuMEphdFG855jrse7UWXtE/1kTLpv1 7cKT9CBuJNsMbPVhFK5ASAZtu/lFkJ1XgxoSD7yBtpHh8KRq5Fq8fX25u5qtYmSYQq+H XGkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2bbZbxQ5uVGlh9D/fI2txo5pcGdK/f5Akir30Ty5LuY=; b=PcMWz9qbEhvBEV9RaxcqciG56xJsG2I/Hlph2h58/SMy7u3/GMg6yqNb9/TypDlqLx XhD71X+UrvYHZzsRvtkxxNbJfL65TP8dxYvT6Q7X2qhKz7/v4aHNQesy3znWb5QtbRKo WL2jaPu/tAHMHf/VMJxyCwsUxZLuSCxuBmRV7+6nuyiKDD6bz5LTNOnA7t7swA6hjy0U n26z521qfkiiq1GmCR605gG6oDvY+cTPqWsL+GpW9PR1qic4qs+D+UX+iMloGWN6g/UM 2tEtQu8m9o8Ih0MeZ4Rh9OfShmyHoLadebuFHNkcD0+uFs2Na8an3Lwn/kwOmXGHnzGS e1Yw== X-Gm-Message-State: AFqh2kqgTyPQZh9JvQUMAcjEEeNcSTxM1b05od4BGXXA4+sbuIles8QF xopVAy05lRJVoa1JHBTi8HgoIg== X-Google-Smtp-Source: AMrXdXtSLS0mpG09KaQBLwMq3nRzoSYY4U9CZEHM+7j07D15D+Rg4N4o7ThmjqgFezh5GNalUbA/hg== X-Received: by 2002:a05:600c:3b1b:b0:3da:11d7:dba3 with SMTP id m27-20020a05600c3b1b00b003da11d7dba3mr24548270wms.5.1674502976439; Mon, 23 Jan 2023 11:42:56 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id c40-20020a05600c4a2800b003db16770bc5sm11037540wmp.6.2023.01.23.11.42.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 11:42:56 -0800 (PST) Message-ID: Date: Mon, 23 Jan 2023 20:42:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v2 4/5] dt-bindings: mmc: sdhci-cadence: SD6 support Content-Language: en-US To: Piyush Malgujar , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, yamada.masahiro@socionext.com, devicetree@vger.kernel.org Cc: jannadurai@marvell.com, cchavva@marvell.com References: <20230123192735.21136-1-pmalgujar@marvell.com> <20230123192735.21136-5-pmalgujar@marvell.com> From: Krzysztof Kozlowski In-Reply-To: <20230123192735.21136-5-pmalgujar@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/01/2023 20:27, Piyush Malgujar wrote: > From: Jayanthi Annadurai > > Add support for SD6 controller support. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > > Signed-off-by: Jayanthi Annadurai > Signed-off-by: Piyush Malgujar > --- > .../devicetree/bindings/mmc/cdns,sdhci.yaml | 34 +++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > index 8b1a0fdcb5e3e2e8b87d8d7678e37f3dad447fc1..26ef2804aa9e17c583adaa906338ec7af8c4990b 100644 > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/mmc/cdns,sdhci.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Cadence SD/SDIO/eMMC Host Controller (SD4HC) > +title: Cadence SD/SDIO/eMMC Host Controller (SD4HC, SD6HC) > > maintainers: > - Masahiro Yamada > @@ -18,7 +18,9 @@ properties: > - enum: > - microchip,mpfs-sd4hc > - socionext,uniphier-sd4hc > - - const: cdns,sd4hc > + - enum: > + - cdns,sd4hc > + - cdns,sd6hc > > reg: > maxItems: 1 > @@ -111,6 +113,34 @@ properties: > minimum: 0 > maximum: 0x7f > > + cdns,iocell-input-delay: > + description: Delay in ps across the input IO cells Use proper unit suffix -ps, so ref wont' be needed. This comment was also ignored. > + $ref: "/schemas/types.yaml#/definitions/uint32" > + > + cdns,iocell-output-delay: > + description: Delay in ps across the output IO cells Ditto > + $ref: "/schemas/types.yaml#/definitions/uint32" > + > + cdns,delay-element: > + description: Delay element in ps used for calculating phy timings Ditto > + $ref: "/schemas/types.yaml#/definitions/uint32" > + > + cdns,read-dqs-cmd-delay: > + description: Command delay used in HS200 tuning What are the units? > + $ref: "/schemas/types.yaml#/definitions/uint32" Drop quotes (everywhere) > + > + cdns,tune-val-start: > + description: Staring value of data delay used in HS200 tuning Same problem - missing units. > + $ref: "/schemas/types.yaml#/definitions/uint32" > + I don't get why the feedback has to be repeated. It's a bit a waste of time, isn't it? Best regards, Krzysztof