From: <Sergiu.Moga@microchip.com>
To: <krzysztof.kozlowski@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-serial@vger.kernel.org>, <alexandre.belloni@bootlin.com>,
<Nicolas.Ferre@microchip.com>, <richard.genoud@gmail.com>,
<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jirislaby@kernel.org>, <devicetree@vger.kernel.org>,
<Claudiu.Beznea@microchip.com>, <lee@kernel.org>,
<Kavyasree.Kotagiri@microchip.com>, <robh+dt@kernel.org>,
<gregkh@linuxfoundation.org>, <radu_nicolae.pirea@upb.ro>,
<krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v4 2/9] dt-bindings: serial: atmel,at91-usart: convert to json-schema
Date: Tue, 20 Sep 2022 07:51:13 +0000 [thread overview]
Message-ID: <d05e20a6-6c4b-4e72-1abf-8ea5c7dfdaf6@microchip.com> (raw)
In-Reply-To: <20220919170812.l2sj7vyjks62ej44@krzk-bin>
On 19.09.2022 20:08, Krzysztof Kozlowski wrote:
> On Mon, 19 Sep 2022 18:08:40 +0300, Sergiu Moga wrote:
>> Convert at91 USART DT Binding for Atmel/Microchip SoCs to
>> json-schema format. Furthermore, move this binding to the
>> serial directory, since binding directories match hardware,
>> unlike the driver subsystems which match Linux convention.
>>
>> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>
>>
>> v1 -> v2:
>> - only do what the commit says, split the addition of other compatibles and
>> properties in other patches
>> - remove unnecessary "|"'s
>> - mention header in `atmel,usart-mode`'s description
>> - place `if:` under `allOf:`
>> - respect order of spi0's DT properties: compatible, then reg then the reset of properties
>>
>> v2 -> v3:
>> - Previously [PATCH 5]
>> - Check value of `atmel,usart-mode` instead of the node regex
>> - Define all properties top level and disallow them explicitly for other type,
>> since additionalProperties:false conflicts with referencing other schemas
>> - Remove useless else if: after else:
>>
>>
>> v3 -> v4:
>> - add R-b tag, this was previously [PATCH 6]
>>
>>
>>
>>
>> .../devicetree/bindings/mfd/atmel-usart.txt | 98 ----------
>> .../bindings/serial/atmel,at91-usart.yaml | 182 ++++++++++++++++++
>> 2 files changed, 182 insertions(+), 98 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-usart.txt
>> create mode 100644 Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
Hello, thank you for checking :). The above link issues a 404.
Everything should be fine though once all of the below are merged:
https://lore.kernel.org/linux-arm-kernel/53e72e5d-47fc-403d-c969-61b267a9ff15@microchip.com/
https://lore.kernel.org/linux-arm-kernel/1ae89854-74fa-6194-304f-db31d56d3674@microchip.com/
together with the patch series that I linked into the cover letter as a
dependence:
https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/
Thank you,
Sergiu
next prev parent reply other threads:[~2022-09-20 7:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 15:08 [PATCH v4 0/9] Make atmel serial driver aware of GCLK Sergiu Moga
2022-09-19 15:08 ` [PATCH v4 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding Sergiu Moga
2022-09-19 15:08 ` [PATCH v4 2/9] dt-bindings: serial: atmel,at91-usart: convert to json-schema Sergiu Moga
2022-09-19 17:08 ` Krzysztof Kozlowski
2022-09-20 7:51 ` Sergiu.Moga [this message]
2022-09-19 15:08 ` [PATCH v4 3/9] dt-bindings: serial: atmel,at91-usart: Add SAM9260 compatibles to SAM9X60 Sergiu Moga
2022-09-19 15:08 ` [PATCH v4 4/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add USART child node ref binding Sergiu Moga
2022-09-19 15:08 ` [PATCH v4 5/9] dt-bindings: serial: atmel,at91-usart: Add gclk as a possible USART clock Sergiu Moga
2022-09-19 15:08 ` [PATCH v4 6/9] tty: serial: atmel: Define GCLK as USART baudrate source clock Sergiu Moga
2022-09-19 15:08 ` [PATCH v4 7/9] tty: serial: atmel: Define BRSRCCK bitmask of UART IP's Mode Register Sergiu Moga
2022-09-19 15:08 ` [PATCH v4 8/9] tty: serial: atmel: Only divide Clock Divisor if the IP is USART Sergiu Moga
2022-09-19 15:17 ` Ilpo Järvinen
2022-09-19 15:08 ` [PATCH v4 9/9] tty: serial: atmel: Make the driver aware of the existence of GCLK Sergiu Moga
2022-09-21 5:51 ` Claudiu.Beznea
2022-09-21 6:27 ` Claudiu.Beznea
2022-09-21 11:49 ` Sergiu.Moga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d05e20a6-6c4b-4e72-1abf-8ea5c7dfdaf6@microchip.com \
--to=sergiu.moga@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).